http://bugs.winehq.org/show_bug.cgi?id=17437
Summary: ATI and EVE Premium: no models display Product: Wine Version: 1.1.15 Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: hpestilence@gmail.com
Created an attachment (id=19519) --> (http://bugs.winehq.org/attachment.cgi?id=19519) EVE shader log
Currently EVE Premium and ATI cards doesn't show any ship models on the login screen or ingame. I tried all the premium option variations and nothing helps (shadows on, hdr on to shadows off, hdr off).
I ran the Apocrypha beta on the test server to see if it would work under "Premium lite" and it doesn't work either. I used everything from sm 2.0 lo to sm 3.0 hi.
I ran it with WINEDEBUG=d3d_shader and apparently all the shaders compile fine but then fails to link.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #1 from hpestilence hpestilence@gmail.com 2009-02-17 17:11:04 --- Forgot to leave my system specs.
Arch Linux 64 bit OS running kernel-2.6.28.4 Intel Q6600 cpu 4GB 1066 ddr2 memory MSI p43 neo3-f motherboard 512mb ATI HD4850 PCI-E graphics card Catalyst 9.1 driver
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #2 from hpestilence hpestilence@gmail.com 2009-02-18 15:28:54 --- Created an attachment (id=19543) --> (http://bugs.winehq.org/attachment.cgi?id=19543) Space screenshot
I forgot to say that I did use the registry fixes when running EVE Online.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #3 from hpestilence hpestilence@gmail.com 2009-02-18 15:35:14 --- Created an attachment (id=19544) --> (http://bugs.winehq.org/attachment.cgi?id=19544) In station screenshot
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #4 from hpestilence hpestilence@gmail.com 2009-02-18 20:16:43 --- Created an attachment (id=19548) --> (http://bugs.winehq.org/attachment.cgi?id=19548) glxinfo -l log
I ran glxinfo -l to show the capabilities / limitations :) of my hd4850 card
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #5 from hpestilence hpestilence@gmail.com 2009-02-18 23:40:59 --- Created an attachment (id=19551) --> (http://bugs.winehq.org/attachment.cgi?id=19551) ati workaround pic
Thanks to Stefan pointing out that ati drivers have a bug with reporting the wrong varying floats support (17 on my card). I hardcoded 14 varyings into glsl_shader.c which resulted in the models on the login screen rendering but nothing in game. I then reduced it to 12 and everything rendered. I'm going to try 13 next and see how it goes.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #6 from hpestilence hpestilence@gmail.com 2009-02-19 00:12:44 --- It seems 13 varyings (52 / 4) works as well, every model is rendered that I come across.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #7 from hpestilence hpestilence@gmail.com 2009-02-19 01:02:36 --- I installed EVE Online premium on to a 32-bit partition and the client wouldn't load at all with wine 1.1.15. I replaced it with my hacked version of wine and then tried starting the premium client again and it loaded up all models with better performance than using a 64-bit Linux OS. The stability is great, sometimes it crashes when exiting the options menu but not often. HDR works too :D
http://bugs.winehq.org/show_bug.cgi?id=17437
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|ATI and EVE Premium: no |ATI and EVE Premium: no |models display |models display / crashes on | |startup
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #8 from hpestilence hpestilence@gmail.com 2009-02-19 07:51:13 --- A temporary workaround this driver bug is to use glxinfo -l to get the value of GL_MAX_VARYING_FLOATS_ARB divide it by 4 and then subtract 4. For my HD4850 this would be 68 / 4 - 4 = 13.
Go into dlls/wined3d/glsl_shader.c and replace every "(GL_LIMITS(glsl_varyings) / 4" with the value that you calculated, for me that would be "13". This hardcodes the varying value to wine so it isn't a clean fix but it'll work temporarily at least until the bug gets fixed.
http://bugs.winehq.org/show_bug.cgi?id=17437
Christoph Hohmann reboot@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #9 from Christoph Hohmann reboot@gmx.ch 2009-02-19 17:13:42 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=17437
Christoph Hohmann reboot@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |reboot@gmx.ch
--- Comment #10 from Christoph Hohmann reboot@gmx.ch 2009-02-19 17:34:08 --- I have the same problem on the Test Server with an NVIDIA card. No models of ships or the environment are visible.
Wine version: 1.1.15 Graphics card: NVIDIA 7600 GT Graphics card driver version: 177.82
I don't know if it is caused by the same problem, but I found some shader related errors in the WINEDEBUG=d3d_shader output:
fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #1: "Vertex info\n-----------\n0(57) : error C1068: array index out of bounds\n"
I can provide a longer log if you tell me what I should search for, because a full log would be way too big.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #11 from hpestilence hpestilence@gmail.com 2009-02-19 18:31:21 --- Created an attachment (id=19568) --> (http://bugs.winehq.org/attachment.cgi?id=19568) shader compile error
http://www.phoronix.com/forums/showpost.php?p=63420&postcount=100
The problem with the test server is that one of the shaders fails to compile. It's a different bug from the ATI link error though.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #12 from H. Verbeet hverbeet@gmail.com 2009-02-20 04:50:59 --- I posted a reply in that thread. Essentially it looks like the driver reports a wrong value for GL_MAX_VERTEX_UNIFORM_COMPONENTS_ARB.
http://bugs.winehq.org/show_bug.cgi?id=17437
Mathieu Belanger b747xx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |b747xx@gmail.com
--- Comment #13 from Mathieu Belanger b747xx@gmail.com 2009-02-20 08:15:35 --- The file dlls/wined3d/directx.c contain the shader stuff detector:
if (gl_info->supported[ARB_VERTEX_SHADER]) { glGetIntegerv(GL_MAX_VERTEX_UNIFORM_COMPONENTS_ARB, &gl_max); gl_info->vs_glsl_constantsF = gl_max / 4; TRACE_(d3d_caps)("Max ARB_VERTEX_SHADER float constants: %u\n", gl_info->vs_glsl_constantsF); }
I can't do any test as I'm at work.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #14 from H. Verbeet hverbeet@gmail.com 2009-02-20 08:54:38 --- Yes, but I'm pretty sure that code is correct. This is most likely something AMD needs to fix in their driver.
http://bugs.winehq.org/show_bug.cgi?id=17437
A.T. xtc@cyberspace.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xtc@cyberspace.ro
--- Comment #15 from A.T. xtc@cyberspace.ro 2009-02-22 13:05:28 --- maybe a registry key to manualy force the right values for buggy drivers ?
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #16 from Connor connormcl@hotmail.com 2009-02-22 16:46:07 --- Created an attachment (id=19613) --> (http://bugs.winehq.org/attachment.cgi?id=19613) Hulk not rendering with workaround
http://bugs.winehq.org/show_bug.cgi?id=17437
Connor connormcl@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |connormcl@hotmail.com
--- Comment #17 from Connor connormcl@hotmail.com 2009-02-22 16:46:48 --- (In reply to comment #8)
A temporary workaround this driver bug is to use glxinfo -l to get the value of GL_MAX_VARYING_FLOATS_ARB divide it by 4 and then subtract 4. For my HD4850 this would be 68 / 4 - 4 = 13.
Go into dlls/wined3d/glsl_shader.c and replace every "(GL_LIMITS(glsl_varyings) / 4" with the value that you calculated, for me that would be "13". This hardcodes the varying value to wine so it isn't a clean fix but it'll work temporarily at least until the bug gets fixed.
I recompiled wine 1.1.15 with values from 12-14 using a HD3850 and Catalyst 9.2.
Most models render now, but i found at least one that doesn't render:
The Hulk - it shows effects, but not the ship. Instead it shows 6 small spheres.
Commandline output:
fixme:d3d_texture:basetexture_set_autogen_filter_type >>>>>>>>>>>>>>>>> GL_INVALID_ENUM (0x500) from glTexParameteri(textureDimensions, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST) @ basetexture.c / 145
fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #36: "Fragment shader(s) linked, vertex shader(s) linked. \nWARNING: 0:2: extension 'GL_ARB_draw_buffers' is not supported "
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #18 from Connor connormcl@hotmail.com 2009-02-22 16:48:14 --- (In reply to comment #17)
Something went wrong with the attachment.
It is here: http://bugs.winehq.org/attachment.cgi?id=19613
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #19 from hpestilence hpestilence@gmail.com 2009-02-23 17:31:47 --- Created an attachment (id=19623) --> (http://bugs.winehq.org/attachment.cgi?id=19623) atihd4850glcaps
I've been experimenting with my hd4850 and found the numbers so far that seems to still compile shaders and be stable. The patch is just to show what works with my card.
The Apocrypha not showing models issue is due to using vec4's > 225 (I think that's the number after setting max_fragment/vertex_uniform_components to 1024). The highest vec4 number I've seen on an Aprocrypha shader is 245 so far. I think only the highest end nvidia cards will be unaffected. Use glxinfo -l to check your numbers.
Also my guess is I don't think the ati driver is returning the wrong number of supported uniform components, they seem to be focused on supporting the lowest number the opengl specs require. GLSL 1.3 needs 1024 which is why I think that number works. This seems to be related to the unified scalar architecture change since the hd2**0 cards as the that series up to the current hd4**0 cards all return a value of 512. AMD needs to release updated opengl documentation/examples for these cards.
http://bugs.winehq.org/show_bug.cgi?id=17437
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19519|EVE shader log |ativaryingbug.log description| |
http://bugs.winehq.org/show_bug.cgi?id=17437
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19568|0 |1 is obsolete| |
--- Comment #20 from hpestilence hpestilence@gmail.com 2009-02-25 00:43:41 --- Created an attachment (id=19639) --> (http://bugs.winehq.org/attachment.cgi?id=19639) updated apocrypha shader log
New updated shader from the current apocrypha client that's currently affecting nvidia 6*00, 7x00 cards and ati cards.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #21 from Christoph Hohmann reboot@gmx.ch 2009-02-26 13:40:48 --- The problem with the NVIDIA 7600 is that is only support 1024 uniforms.
glxinfo -l:
GL_MAX_VERTEX_UNIFORM_COMPONENTS_ARB = 1024
That means gl_info->vs_glsl_constantsF is 256. And in dlls/wined3d/directx.c max_vshader_constantsF is then set to
gl_info->vs_glsl_constantsF - (MAX_CONST_B / 4) - MAX_CONST_I - 1;
which is then 235, resulting in
uniform vec4 VC[235];
in the shader code. But it seems Apocrypha needs more uniforms. Since i didn't see any reference to VI and VB in the shader code I changed MAX_CONST_B and MAX_CONST_I to 0 and recompiled wine. After that the models were rendered and the overall graphics didn't look bad. There were some miner graphics bugs, but the game worked.
Looks like the TODO in dlls/wined3d/wined3d_private.h needs to be done for EVE:
TODO: Make this dynamic, based on shader limits
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #22 from hpestilence hpestilence@gmail.com 2009-02-26 23:15:25 --- Created an attachment (id=19681) --> (http://bugs.winehq.org/attachment.cgi?id=19681) ati apocrypha workaround patch
This patch currently makes apocyrpha run on my ati hd4850, thx to
http://www.eveonline.com/ingameboard.asp?a=topic&threadID=1002707&pa...
It's a dirty workaround, but it should get eve running post March 10th on some ati cards.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #23 from Keith Geffert keith@penguingurus.com 2009-02-27 11:28:40 --- Created an attachment (id=19697) --> (http://bugs.winehq.org/attachment.cgi?id=19697) only reserve uniform ints when needed. Add registry options for ATI users
Using a 7600GT. Don't have issues with the GL_VARYING's etc. But my I'm stuck with the 1024 max vertex uniforms.
I was using a simliar approach above. But didn't want to just *ignore* the INT reservations if I didn't have to. I believe This->baseShader.uses_int_consts, if its always correct, allows you to selectively use the reservation when ints are used.
As stated above no VC's are ever used with VI/VB so this patches around the not enough uniforms.
Added the ability to change the registry to support changing GL_MAX_* parameters from glxinfo defaults.
Keys used as an ex
[Software\Wine\Direct3D] "MaxVertexUniforms" = "1024" "MaxFragmentUniforms" = "1024" "MaxVaryings" = "52"
Patch may work for nvidia 7x series users without keys (does for me!).
http://bugs.winehq.org/show_bug.cgi?id=17437
Stefan Dösinger stefandoesinger@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefandoesinger@gmx.at
--- Comment #24 from Stefan Dösinger stefandoesinger@gmx.at 2009-03-03 12:19:22 --- I am working on a patchset that addresses the issue with the Wine-reserved uniforms. Basically I always advertise the full amount of GL supported uniforms to d3d(in case of the gf7600 256).
In the shader, if indirect addressing is not used, I always declare the full 256 uniforms. The driver can optimize unused ones away; That way a game can use c255 even if we need reserved ones, as long as it doesn't use indirect addressing in the shader. If the shader does use all 256 uniforms we're still screwed of course.
With indirect addressing, the driver can't optimize away unused uniforms because it can't know which ones are unused and which are used. So I currently subtract the number of really used INT and BOOL uniforms, and 2 vprivately used vec4's(1 for posFixup, one for immediate values). In the best case, a shader can use c253 together with indirect addressing.
The remaining problem is that not all drivers deal with immediate values as efficiently as the nvidia driver. Especially MacOS sucks here, and I found that I have to reserve 10-20 vec4's due to that. I still need some way to could the number of immvals we're using and package them up manually.
As for working around incorrectly advertised varyings: If we do that, this should be integrated with the card detection. E.g. for each PCI ID we detect in the card detection, we could store info such as this:
1) Number of GLSL uniforms and varyings we expect the driver to advertise 2) Number of ARB constants 3) Number of uniforms and varyings that are really supported 4) Use ARB values, GLSL values or hardcoded values?
One important thing is that every workaround is built on some assumptions. The code should be able to detect when the assumptions aren't true any longer(e.g. driver update fixed the bug), and issue a warning. A workaround + a fixed driver might lead to new bugs.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #25 from KeithG keith@penguingurus.com 2009-03-03 14:53:26 --- (In reply to comment #24)
addressing in the shader. If the shader does use all 256 uniforms we're still screwed of course.
yep. But I would assume this would be a case that is theoretical only. As you'd be using all available uniforms just for that shader with no other possible allocations. There was probably a better way to write that shader in the first place. If it truly needs all that room then it needs a higher class of card.
As for working around incorrectly advertised varyings: If we do that, this should be integrated with the card detection. E.g. for each PCI ID we detect in the card detection, we could store info such as this:
- Number of GLSL uniforms and varyings we expect the driver to advertise
- Number of ARB constants
- Number of uniforms and varyings that are really supported
- Use ARB values, GLSL values or hardcoded values?
if ( driver_advertised > expected_values) wine_values = driver_adverstised else WARN("gl driver advertised values are under spec'd for this card") wine_values = expected_values
5) card is not detected by wine (newer gpu or older version of wine), driver under reports values. What happens in this case? Does it take a patch / recompile to fix or is there some other way of reporting proper values to wine until its sorted aka, newer version of wine with the new gpu detected.
One important thing is that every workaround is built on some assumptions. The code should be able to detect when the assumptions aren't true any longer(e.g. driver update fixed the bug), and issue a warning. A workaround + a fixed driver might lead to new bugs.
As far as my patch goes.. its a hack to make it work. Nothing more. I don't have the understanding the material to make any kind of intelligent remarks beyond the very basic. Other than, like everyone else on the cc list, we have a vested interested in making it work *somehow* :)
I tried adding back the reservations of the ints / bools during the process of building the shader string buffer. And while I was able to get it to compile and link shaders successfully. It still never provided rendered models. I assumed at that point the maxF value was used to set something up the stack that would not allow the models to be displayed.
This eventually morphed into... not reserving until ints were called for within baseshader.c and I wanted something quick and dirty. So the yes/no provided that. Modifying the maxF within the shader.limits. struct at that point allowed the models to render properly and removed the issue above.
I'm just glad someone at codeweavers / wine proper is working on it at this point.
http://bugs.winehq.org/show_bug.cgi?id=17437
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |krims0n32@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #26 from hpestilence hpestilence@gmail.com 2009-03-10 07:19:57 --- Created an attachment (id=19861) --> (http://bugs.winehq.org/attachment.cgi?id=19861) wine-1.1.16 ati / uniforms updated patch
same patch as the apocrypha workaround patch, but updated for wine-1.1.16
http://bugs.winehq.org/show_bug.cgi?id=17437
Max Mikhanosha max-wine@openchat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |max-wine@openchat.com
--- Comment #27 from Max Mikhanosha max-wine@openchat.com 2009-03-11 03:45:48 ---
(In reply to comment #23)
Created an attachment (id=19697)
--> (http://bugs.winehq.org/attachment.cgi?id=19697) [details]
only reserve uniform ints when needed. Add registry options for ATI users
Patch may work for nvidia 7x series users without keys (does for me!).
I can confirm that this applies cleanly to latest git sources and fixes 7800GT from no models displayed at all, to all of them seem fine. This is without adding any keys.
Log no longer contains any shader errors.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #28 from Connor connormcl@hotmail.com 2009-03-11 11:58:51 --- (In reply to comment #27)
(In reply to comment #23)
Created an attachment (id=19697)
--> (http://bugs.winehq.org/attachment.cgi?id=19697) [details] [details]
only reserve uniform ints when needed. Add registry options for ATI users
Patch may work for nvidia 7x series users without keys (does for me!).
I can confirm that this applies cleanly to latest git sources and fixes 7800GT from no models displayed at all, to all of them seem fine. This is without adding any keys.
Log no longer contains any shader errors.
Works for ATI 3850 and renders all models.
But i still have a few shader errors in the console:
fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #194: "Fragment shader(s) linked, vertex shader(s) linked. \nWARNING: 0:2: extension 'GL_ARB_draw_buffers' is not supportedWARNING: built-in varying gl_TexCoord [5] has mismatched access semantics between the vertex and fragment shader\nWARNING: built-in varying gl_TexCoord [5] has mismatched access semanti"... fixme:d3d_texture:basetexture_apply_state_changes Unrecognized or unsupported D3DSAMP_MINFILTER value 2 D3DSAMP_MIPFILTER value 3 fixme:imm:NotifyIME NI_CLOSECANDIDATE fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #196: "Fragment shader(s) linked, vertex shader(s) linked. \nWARNING: 0:2: extension 'GL_ARB_draw_buffers' is not supportedWARNING: built-in varying gl_TexCoord [5] has mismatched access semantics between the vertex and fragment shader\nWARNING: built-in varying gl_TexCoord [5] has mismatched access semanti"...
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #29 from Stefan Dösinger stefandoesinger@gmx.at 2009-03-11 18:39:54 --- Those are warings. The GLSL compiler warns about potentially uninitialized data because some constructs in the shader we generate.
E.g. the d3d shader does this
Vertex: mov oT0.xy, r0.xy
Fragment: texld r0, t0
This gets translated to gl_TexCoord[0].xy = r0.xy; ------ t0.xyzw = gl_TexCoord[0].xyzw; r0 = texture2D(sampler0, t0.xy);
The code is correct, but the t0.xyzw = gl_TexCoord[0].xyzw; causes a warning because gl_TexCoord[0].zw are not written in the vertex shader.
http://bugs.winehq.org/show_bug.cgi?id=17437
flyingmayo flyingmayo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingmayo@gmail.com
--- Comment #30 from flyingmayo flyingmayo@gmail.com 2009-03-12 02:22:13 --- The patch also fixed invisi-ships and stations on an NVIDIA GeForce 7950 GT Fabulous work. Many thanks.
http://bugs.winehq.org/show_bug.cgi?id=17437
Eddy Y. jeyoung@priscimon.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeyoung@priscimon.com
--- Comment #31 from Eddy Y. jeyoung@priscimon.com 2009-03-12 11:03:30 --- (In reply to comment #30)
The patch also fixed invisi-ships and stations on an NVIDIA GeForce 7950 GT Fabulous work. Many thanks.
I can confirm that it works on an ATI HD 3470, but suspect that the registry settings that I use are incorrect.
How do I find which values to use?
Cheers.
http://bugs.winehq.org/show_bug.cgi?id=17437
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wbrosz@uvic.ca
--- Comment #32 from Willem Brosz wbrosz@uvic.ca 2009-03-12 13:59:38 --- Fix is confirmed *not* to work with an ATI Radeon HD 3200.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #33 from Eddy Y. jeyoung@priscimon.com 2009-03-12 14:50:41 --- (In reply to comment #31)
(In reply to comment #30)
The patch also fixed invisi-ships and stations on an NVIDIA GeForce 7950 GT Fabulous work. Many thanks.
I can confirm that it works on an ATI HD 3470, but suspect that the registry settings that I use are incorrect.
How do I find which values to use?
Cheers.
Fix works perfectly with correct values for the HD 3470. Values are 512, 68, and 512 in the order of the settings as listed.
http://bugs.winehq.org/show_bug.cgi?id=17437
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq@harik.welp.gs
--- Comment #34 from Dan Merillat winehq@harik.welp.gs 2009-03-12 20:06:42 --- (In reply to comment #32)
Fix is confirmed *not* to work with an ATI Radeon HD 3200.
Fix is confirmed TO work with ATI Radeon HD 3200 and ATI Radeon 2400 pro.
fglrx 9-2, wine 1.1.16 with the most recent patch (as of this post)
I had to specify the VideoMemorySize explictly or it would crash.
[Software\Wine\Direct3D] "DirectDrawRenderer"="opengl" "MaxFragmentUniforms"="1024" "MaxVaryings"="52" "MaxVertexUniforms"="1024" "OffscreenRenderingMode"="fbo" "PixelShaderMode"="enabled" "VertexShaderMode"="hardware" "VideoMemorySize"="256"
Radeon 2400 pro doesn't work with MaxVaryings=52, does work with 48, I haven't bisected the gap yet.
Both machines 2.6.28 on AMD64.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #35 from Mathieu Belanger b747xx@gmail.com 2009-03-13 12:25:59 --- Created an attachment (id=19907) --> (http://bugs.winehq.org/attachment.cgi?id=19907) Patch updated for Wine 1.1.17
I just updated the patch for Wine 1.1.17!
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #36 from Connor connormcl@hotmail.com 2009-03-13 18:17:26 --- (In reply to comment #35)
Created an attachment (id=19907)
--> (http://bugs.winehq.org/attachment.cgi?id=19907) [details]
Patch updated for Wine 1.1.17
I just updated the patch for Wine 1.1.17!
Patch doesn't work during patching:
connor@prometheus:/work/wine-1.1.17> patch -p1 < apocrypha-1.1.17.patch patching file dlls/wined3d/baseshader.c Hunk #1 FAILED at 351. Hunk #2 FAILED at 478. 2 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/baseshader.c.rej patching file dlls/wined3d/directx.c Hunk #1 FAILED at 425. Hunk #2 FAILED at 969. 2 out of 2 hunks FAILED -- saving rejects to file dlls/wined3d/directx.c.rej patching file dlls/wined3d/wined3d_main.c Hunk #1 FAILED at 304. 1 out of 1 hunk FAILED -- saving rejects to file dlls/wined3d/wined3d_main.c.rej patching file dlls/wined3d/wined3d_private.h connor@prometheus:/work/wine-1.1.17> more dlls/wined3d/baseshader.c.rej
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #37 from Mathieu Belanger b747xx@gmail.com 2009-03-13 22:56:21 --- Created an attachment (id=19924) --> (http://bugs.winehq.org/attachment.cgi?id=19924) Same patch, for Wine 1.1.17
Use this one. I used copy/paste to publish the patch from my work place... This one is from the source (I run it actually).
Tanith wine-1.1.17.orig # patch -p1 < /home/destroyfx/apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h
http://bugs.winehq.org/show_bug.cgi?id=17437
Henrik Pihl henrik@saarlane.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |henrik@saarlane.ee
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #38 from Willem Brosz wbrosz@uvic.ca 2009-03-15 00:09:07 --- (In reply to comment #34)
Fix is confirmed TO work with ATI Radeon HD 3200 and ATI Radeon 2400 pro.
Confirmed as well, for real this time. Not sure what I was doing earlier
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #39 from Eddy Y. jeyoung@priscimon.com 2009-03-15 04:07:14 --- (In reply to comment #35)
Created an attachment (id=19907)
--> (http://bugs.winehq.org/attachment.cgi?id=19907) [details]
Patch updated for Wine 1.1.17
I just updated the patch for Wine 1.1.17!
Thanks for this patch! Works great and even fixes the problem that prevented me from dragging probes around.
Is anyone committing these patches to the main dev stream?
http://bugs.winehq.org/show_bug.cgi?id=17437
Stephan Sperling sperling.stephan@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sperling.stephan@googlemail. | |com
--- Comment #40 from Stephan Sperling sperling.stephan@googlemail.com 2009-03-15 09:39:26 --- Is it possible to get a patched wine as rpm file, i'm sitting here for araoung 20 hours and will compile, but it breaks everytime with the same error and i couldn't find the problem.
I have a OpenSuse 10.3 64Bit.
When someone can help me, so feel free for write to me.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #41 from Nikita Skvortsov lykanthropos@gmail.com 2009-03-15 10:07:19 --- Created an attachment (id=19964) --> (http://bugs.winehq.org/attachment.cgi?id=19964) eve warn log
(In reply to comment #37)
Created an attachment (id=19924)
--> (http://bugs.winehq.org/attachment.cgi?id=19924) [details]
Same patch, for Wine 1.1.17
Use this one. I used copy/paste to publish the patch from my work place... This one is from the source (I run it actually).
Tanith wine-1.1.17.orig # patch -p1 < /home/destroyfx/apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h
EVE Apocrypha fails to run with this patch in following configuration:
-- Linux kit-laptop 2.6.27-11-generic #1 SMP Thu Jan 29 19:24:39 UTC 2009 i686 GNU/Linux -- ATI Xpress 1100 (Integrated graphics, RV370) -- FGL 9-2 (OpenGL version string: 2.1.8494 Release)
Unhandled page access occures when entering station.
Log attached is for following command:
WINEDEBUG=warn+all /usr/local/bin/wine /home/kit/.wine/drive_c/Program\ Files/CCP/EVE/eve.exe &> eve_debug.log
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #42 from Eddy Y. jeyoung@priscimon.com 2009-03-15 11:15:22 --- (In reply to comment #39)
(In reply to comment #35)
Created an attachment (id=19907)
--> (http://bugs.winehq.org/attachment.cgi?id=19907) [details] [details]
Patch updated for Wine 1.1.17
I just updated the patch for Wine 1.1.17!
Thanks for this patch! Works great and even fixes the problem that prevented me from dragging probes around.
Is anyone committing these patches to the main dev stream?
To anyone interested in the bug that prevents probe cubes and arrows from being moved (keywords: eve online, wine, linux, probe, move, drag and drop, cube), the solution is as follows:
* Apply patch here and re-compile * Add the registry settings further up in this thread *and*
"OffscreenRenderingMode"="fbo"
Good luck!
http://bugs.winehq.org/show_bug.cgi?id=17437
Matthieu Bertin bertinm@esiee.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bertinm@esiee.fr
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #43 from Matthieu Bertin bertinm@esiee.fr 2009-03-16 14:53:26 --- Is it possible to have the patch included in the main dev stream ? that would be nice, i try not to install stuff i've compiled myself as it is quite hard to explain to apt what i've installed myself and how to get it updated ! :)
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #44 from Stefan Dösinger stefandoesinger@gmx.at 2009-03-20 07:25:19 --- Created an attachment (id=20033) --> (http://bugs.winehq.org/attachment.cgi?id=20033) Rough pathset proposal
Here are the patches I have been working on over the last time.
Patch 5 changes the way the constant reservation works to allow each backend to control things.
Patch 6 enables all 256 constants with GLSL, with an exception for indirect addressing
Patch 14 adds a more formal framework for overriding driver advertised limits etc, with one such override for ATI r300 to r500 cards.
Patch 17 moves some old quirks into the new table
Patch 18 allows reserving additional private constants per card/driver. This is used to get cards broken by patch 5 running again.
(Other patches were unrelated patches in my wine tree)
14, 17, 18 are mostly untested, I wrote them during a plane flight with an nvidia card. I plan to send it in once I tested it a bit. What needs to/can be done on top of this:
*) Add a varying override *) Add entries for other ATI cards *) Optionally add the registry keys proposed by some other patch and construct a driver quirk entry from the registry
http://bugs.winehq.org/show_bug.cgi?id=17437
Bozhan Boiadzhiev bozhan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bozhan@gmail.com
--- Comment #45 from Bozhan Boiadzhiev bozhan@gmail.com 2009-03-21 17:20:46 --- Kubuntu 9.04 alpha6 AMD Athlon(tm) 64 X2 Dual Core Processor 3600+
onboard GeForce 6100 nForce 405 :) :) :)
latest git wine
with patch i can see 3d objects
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #46 from Stephen Milton smmilton@gmail.com 2009-03-25 00:27:52 --- I can confirm that the patch to Wine-1.1.17 posted above by Matheiu (5.61kb) applies cleanly against 1.1.17, and fixes the missing stations and ships issue in Eve Online for me.
System Details: Wine 1.1.17 (patched with http://bugs.winehq.org/attachment.cgi?id=19924) EVE Online - Apocrypha Client - Version 6.10.84609 RHEL 5.3 64-bit ATI HD4650 ATI Catalyst 9.2 Driver Intel Core i7 - 920 6GB DDR3 RAM
http://bugs.winehq.org/show_bug.cgi?id=17437
Casey caseyjp1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |caseyjp1@gmail.com
--- Comment #47 from Casey caseyjp1@gmail.com 2009-03-29 13:43:24 --- Just wondering when the patch will be updated for wine 1.1.18 as this was just released, and the issue still exists.
http://bugs.winehq.org/show_bug.cgi?id=17437
Mathieu Belanger b747xx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19907|0 |1 is obsolete| |
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #48 from Mathieu Belanger b747xx@gmail.com 2009-03-29 14:36:40 --- The patch http://bugs.winehq.org/attachment.cgi?id=19924 (apocrypha.shaders.1.1.17) still apply.
http://bugs.winehq.org/show_bug.cgi?id=17437
Thomas Raschbacher lordvan@lordvan.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lordvan@lordvan.com
http://bugs.winehq.org/show_bug.cgi?id=17437
Kai I kai@stg24.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kai@stg24.at
--- Comment #49 from Kai I kai@stg24.at 2009-04-03 04:13:16 --- tried the patches on my laptop (lenovo W500, specs http://www.thinkwiki.org/wiki/Category:W500), and they apply without problems and compiling works too, but when i start eve online with patched wine the computer hangs/crashes only rebooting is possible.
http://bugs.winehq.org/show_bug.cgi?id=17437
Kai I kai@stg24.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kai@stg24.at
--- Comment #49 from Kai I kai@stg24.at 2009-04-03 04:13:16 --- tried the patches on my laptop (lenovo W500, specs http://www.thinkwiki.org/wiki/Category:W500), and they apply without problems and compiling works too, but when i start eve online with patched wine the computer hangs/crashes only rebooting is possible.
--- Comment #50 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 02:02:59 --- i tried to apply M. Belanger's patch with no success on my laptop. Is it possible that someone posts a compiled version ? I might have been doing something wrong, cause i have seen absolutely no improvment... :(
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #51 from Eddy Y. jeyoung@priscimon.com 2009-04-09 02:34:37 --- (In reply to comment #50)
i tried to apply M. Belanger's patch with no success on my laptop. Is it possible that someone posts a compiled version ? I might have been doing something wrong, cause i have seen absolutely no improvment... :(
Can you attach any output that you get when running EVE?
Also remember that this patch works in conjunction with the latest drivers.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #52 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:19:34 --- Created an attachment (id=20346) --> (http://bugs.winehq.org/attachment.cgi?id=20346) eve execution trace, on laptop with HD34xx.
log when patch isn't working. however I might have screwed up the patching somehow .
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #53 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:23:47 --- Created an attachment (id=20347) --> (http://bugs.winehq.org/attachment.cgi?id=20347) eve execution trace, on laptop with HD34xx.
I might have screwed up patching the sources or compiling it... It's very long, i had to configure my terminal to keep 65536 lines of history.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #53 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:23:47 --- Created an attachment (id=20347) --> (http://bugs.winehq.org/attachment.cgi?id=20347) eve execution trace, on laptop with HD34xx.
I might have screwed up patching the sources or compiling it... It's very long, i had to configure my terminal to keep 65536 lines of history.
--- Comment #54 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:24:27 --- Created an attachment (id=20348) --> (http://bugs.winehq.org/attachment.cgi?id=20348) eve execution trace, on laptop with HD34xx.
I might have screwed up patching the sources or compiling it... It's very long, i had to configure my terminal to keep 65536 lines of history.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #53 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:23:47 --- Created an attachment (id=20347) --> (http://bugs.winehq.org/attachment.cgi?id=20347) eve execution trace, on laptop with HD34xx.
I might have screwed up patching the sources or compiling it... It's very long, i had to configure my terminal to keep 65536 lines of history.
--- Comment #54 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:24:27 --- Created an attachment (id=20348) --> (http://bugs.winehq.org/attachment.cgi?id=20348) eve execution trace, on laptop with HD34xx.
I might have screwed up patching the sources or compiling it... It's very long, i had to configure my terminal to keep 65536 lines of history.
--- Comment #55 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:26:48 --- posted. Sorry for triple posting, i had quite a lot of troubles with it :/
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #56 from Eddy Y. jeyoung@priscimon.com 2009-04-09 03:46:19 --- (In reply to comment #55)
posted. Sorry for triple posting, i had quite a lot of troubles with it :/
It is most likely the patch was not successful. Please get fresh source and apply patch again.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
--- Comment #100 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-23 13:50:01 --- Maybe the dx10 clip pos uniform needs some adjustments for ati cards.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from H. Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from H. Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
--- Comment #100 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-23 13:50:01 --- Maybe the dx10 clip pos uniform needs some adjustments for ati cards.
--- Comment #101 from hpestilence hpestilence@gmail.com 2009-05-23 16:16:31 --- Created an attachment (id=21273) --> (http://bugs.winehq.org/attachment.cgi?id=21273) wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Hulks and other mining ships rendered, but not a POS up close. If I moved the camera away then it would show the model and also the model would render fine when viewing it with the preview screen. However I've seen windows users complaining about how a POS was "aligning" with their ship so it could be a problem with the EVE client itself. Also there weren't any opengl error messages that would cause the POS not to render from my logs.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from Henri Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from Henri Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
--- Comment #100 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-23 13:50:01 --- Maybe the dx10 clip pos uniform needs some adjustments for ati cards.
--- Comment #101 from hpestilence hpestilence@gmail.com 2009-05-23 16:16:31 --- Created an attachment (id=21273) --> (http://bugs.winehq.org/attachment.cgi?id=21273) wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Hulks and other mining ships rendered, but not a POS up close. If I moved the camera away then it would show the model and also the model would render fine when viewing it with the preview screen. However I've seen windows users complaining about how a POS was "aligning" with their ship so it could be a problem with the EVE client itself. Also there weren't any opengl error messages that would cause the POS not to render from my logs.
--- Comment #102 from Connor connormcl@hotmail.com 2009-05-25 13:46:41 --- (In reply to comment #101)
Created an attachment (id=21273)
--> (http://bugs.winehq.org/attachment.cgi?id=21273) [details]
wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Game seems to work so far. Only when the map is opened, i get many lines of these:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
But the map works and seems to show everything.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from Henri Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from Henri Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
--- Comment #100 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-23 13:50:01 --- Maybe the dx10 clip pos uniform needs some adjustments for ati cards.
--- Comment #101 from hpestilence hpestilence@gmail.com 2009-05-23 16:16:31 --- Created an attachment (id=21273) --> (http://bugs.winehq.org/attachment.cgi?id=21273) wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Hulks and other mining ships rendered, but not a POS up close. If I moved the camera away then it would show the model and also the model would render fine when viewing it with the preview screen. However I've seen windows users complaining about how a POS was "aligning" with their ship so it could be a problem with the EVE client itself. Also there weren't any opengl error messages that would cause the POS not to render from my logs.
--- Comment #102 from Connor connormcl@hotmail.com 2009-05-25 13:46:41 --- (In reply to comment #101)
Created an attachment (id=21273)
--> (http://bugs.winehq.org/attachment.cgi?id=21273) [details]
wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Game seems to work so far. Only when the map is opened, i get many lines of these:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
But the map works and seems to show everything.
--- Comment #103 from hpestilence hpestilence@gmail.com 2009-05-25 20:31:01 --- It looks like a shader needing 248 uniforms is created when the map is used. The only way to easily workaround that is to subtract 2 instead of 3 in the max_constantsF of dlls/wined3d/glsl_shader.c but I didn't notice any difference in the map.
Also I found some GL_INVALID_ENUMs caused by bug http://bugs.winehq.org/show_bug.cgi?id=11167 so I added it to the bugs list for EVE.
http://bugs.winehq.org/show_bug.cgi?id=17437
Florian Sievert floriansievert@phobeus.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |floriansievert@phobeus.de
Willem Brosz wbrosz@uvic.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|wbrosz@uvic.ca |
rig0r krims0n32@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|krims0n32@gmail.com |
Dan Merillat winehq@harik.welp.gs changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@harik.welp.gs |
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mah301s@hotmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20746|0 |1 is obsolete| |
Mads madsvibe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madsvibe@gmail.com
Joachim Rousseau syrion.com@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syrion.com@gmail.com
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #20974|0 |1 is obsolete| | Attachment #20998|0 |1 is obsolete| |
Aigars Mahinovs aigarius@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |aigarius@gmail.com
--- Comment #57 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 03:54:14 --- how do you remove the compiled version of wine then ? before i compile it again...
--- Comment #58 from Eddy Y. jeyoung@priscimon.com 2009-04-09 04:19:17 --- (In reply to comment #57)
how do you remove the compiled version of wine then ? before i compile it again...
You just overwrite the current version with the one you will be compiling.
First, patch your source code, making sure that you have the corresponding code version and patch (ie. do not apply a patch meant for wine 1.1.7 to wine 1.1.6).
Second, check where your existing wine is with 'whereis wine'.
If it's in /usr/bin, then use
$ ./configure --prefix=/usr
Otherwise, do
$ ./configure
Then,
$ make $ sudo make install
--- Comment #59 from Matthieu Bertin bertinm@esiee.fr 2009-04-09 17:47:25 --- Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
here is a short version:
brzhk@gauss:~/winecomp/wine-1.1.18$ patch -p1 < apocrypha.shaders.1.1.17.patch patching file dlls/wined3d/baseshader.c patching file dlls/wined3d/directx.c patching file dlls/wined3d/wined3d_main.c patching file dlls/wined3d/wined3d_private.h Hunk #1 succeeded at 290 (offset -8 lines). brzhk@gauss:~/winecomp/wine-1.1.18$ ./configure (conf. trace) brzhk@gauss:~/winecomp/wine-1.1.18$ make depend && make (traces) brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
--- Comment #60 from Eddy Y. jeyoung@priscimon.com 2009-04-10 03:13:49 --- (In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
See http://bugs.winehq.org/show_bug.cgi?id=17437#c23
brzhk@gauss:~/winecomp/wine-1.1.18$ sudo make install
i also tried with --prefix=/usr/local as it was the path shown by whereis wine.
I'm out of ideas.
What error are you getting? Does EVE not run at all? Or, does it run with graphics glitches?
--- Comment #61 from Matthieu Bertin bertinm@esiee.fr 2009-04-10 03:58:51 --- (In reply to comment #60)
(In reply to comment #59)
Here it is. I did what you said, and it still doesn't work. I downloaded 1.1.18 from sourceforge and i am using latest proprietary drivers available on synaptic.
I use the latest drivers from ATI. Could you try with that please? Also, do you have the user.reg settings specified earlier in the thread?
IT JUST DID THE TRICK ! Thanks a lot.
everything works fine now !
--- Comment #62 from Florian Sievert floriansievert@phobeus.de 2009-04-10 15:27:01 ---
IT JUST DID THE TRICK ! Thanks a lot.
I can confirm this. I tried for some days now to get the patch for my ati card. However, everything seems to fail. Adding the options to the user.reg and the patch seems to work fine for ati users. Thanks!
--- Comment #63 from Connor connormcl@hotmail.com 2009-04-12 18:11:29 --- We need a new patch for wine 1.1.19.
Tried to use the 1.1.17 patch on wine-1.1.19 with ATI HD3850 and Catalyst 9.3.
Patched wine compiles, but too much has changed and models are gone again.
Cmd-line shows:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 573
--- Comment #64 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:12:13 --- Created an attachment (id=20410) --> (http://bugs.winehq.org/attachment.cgi?id=20410) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #65 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:14:14 --- Created an attachment (id=20411) --> (http://bugs.winehq.org/attachment.cgi?id=20411) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #66 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:16:22 --- Created an attachment (id=20412) --> (http://bugs.winehq.org/attachment.cgi?id=20412) Wine 1.1.19 patch for Apocrypha
Here the new patch for Wine 1.1.19!
Enjoy!
--- Comment #67 from Mathieu Belanger b747xx@gmail.com 2009-04-12 22:17:41 --- Sorry for the triple post, got a Time out error from winehq....
--- Comment #68 from A.T. xtcdj15@yahoo.com 2009-04-13 14:06:02 --- author Stefan Dösinger stefan@codeweavers.com
Sun, 22 Mar 2009 11:24:28 +0000 (12:24 +0100)
committer Alexandre Julliard julliard@winehq.org
Fri, 10 Apr 2009 09:22:55 +0000 (11:22 +0200)
commit 754b5cf2adc73a917d7d60c35d5cad5897a5e92d
tree fe1490bead9bf88cc15e0b6d58d17b9c1f35fafe tree | snapshot
parent 0af0bafd6ae40f9832d9c630c24a6696ac284631 commit | diff
wined3d: Deal with reserved shader constants in the backend.
This moves the GLSL and ARB specific reserved constants out of directx.c into
the get_caps methods of the shader backends. That way the number of reserved
constants remains in the backend.
GL_LIMITS({v/p}shader_constantsF) now contains the real number of constants as
advertised by GL instead of some mixture of GL info and backend implementation
specifics. This makes it easier for backends to decide how many constants to
use.
===========================================================
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
the only things missing seems to be the registry keys to force correct values for buggy drivers ( ati 9.3 or older ???.... some people who tested 9.4 beta reported on phoronix forum that 9.4 solved this issue, lets hope is true....9.4 for M$ WIN was released few days ago, so linux 9.4 final seems to be just around the corner)
--- Comment #69 from Henri Verbeet hverbeet@gmail.com 2009-04-13 14:25:18 --- (In reply to comment #68)
from what i understand this is the (partial) patch already integrated by Stefan in 1.1.19 (should work for nvidia 7xxx series ? ...i will test asap and post results for 7600GT);
No, it's related, but doesn't solve this issue yet. You need http://www.winehq.org/pipermail/wine-patches/2009-April/071698.html and (for fglrx) the following patches for that. Those still need some work though.
--- Comment #70 from Mathieu Belanger b747xx@gmail.com 2009-04-13 15:03:06 --- This patch (apocrypha.shaders.1.1.19.patch) is still needed for EVE on ATI card and Nvidia 7xxx-
- The ATI Drivers are still buggy and still need overide via registery key for uniform and varying.
- The max_constantsF = GL_LIMITS(vshader_constantsF) stuff moved but the patch is still needed for that because the formula are the same : max_constantsF = GL_LIMITS(vshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 1 and MAX_CONST_B & MAX_CONST_I are still static constantes (16 and 16).... So without the patch, ATI and Nvidia 7xxx don't have enough vec4 for EVE Shader.
--- Comment #71 from hpestilence hpestilence@gmail.com 2009-04-14 23:10:35 --- I tested out the patches on the mailing list and the wine from git with my HD4850 and here are the results:
Everything seems to render fine on medium and low shader settings, including shadows and hdr.
On high shaders the title screen was black with hdr and bloom on, turning those off gave me a normal title screen. When I logged on in the game the station / models didn't render regardless if hdr or bloom was on or off.
Looking through my logs it seems it's related to the original ati varyings bug which is easily worked around by hardcoding a lower varying number. Only a problem if you want to run in high settings though. :)
If your a nvidia card owner everything should work for you guys "out of the box" if these patches get accepted.
--- Comment #72 from hpestilence hpestilence@gmail.com 2009-04-22 01:53:28 --- Created an attachment (id=20605) --> (http://bugs.winehq.org/attachment.cgi?id=20605) shader error from wine git
I found a few models that didn't render specifically the covetor (possibly other mining ships) and the dreadnoughts. I found the error and it seems a shader uses 246 uniforms and only 245 is defined.
This is with the current wine in the git and just a little patch to lower my varyings to 52.
--- Comment #73 from Vitaliy Margolen vitaliy@kievinfo.com 2009-04-26 02:00:26 --- *** Bug 18217 has been marked as a duplicate of this bug. ***
--- Comment #74 from hpestilence hpestilence@gmail.com 2009-04-27 02:58:03 --- Created an attachment (id=20746) --> (http://bugs.winehq.org/attachment.cgi?id=20746) wine-1.1.20 patch
This patch is a mix of Stefan's "official" fix for the uniforms issue and the registry option to change the max varyings for ATI users.
This should allow all models to render on medium or low shader settings with all other settings on high, but on high shaders the mining ships and dreadnoughts don't render and maybe some other stuff.
--- Comment #75 from hpestilence hpestilence@gmail.com 2009-04-27 03:03:23 --- oops looks like it copied a whole file into the patch, I'll fix it tomorrow :)
--- Comment #76 from Henri Verbeet hverbeet@gmail.com 2009-04-27 03:07:17 --- For what it's worth, "git apply" is better at applying patches than "patch".
--- Comment #77 from hpestilence hpestilence@gmail.com 2009-04-27 17:46:11 --- Created an attachment (id=20762) --> (http://bugs.winehq.org/attachment.cgi?id=20762) fixed wine-1.1.20 patch
--- Comment #78 from Mads madsvibe@gmail.com 2009-04-28 12:25:10 --- still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
--- Comment #79 from Connor connormcl@hotmail.com 2009-04-28 14:53:20 --- (In reply to comment #78)
still same problem here.. 7900GS - Ubuntu 9.04 - Wine 1.1.20 - tried the patch above with no luck so far
Patch from post #70 for wine-1.1.19 work for wine-1.1.20 on ATI 3850/3870 with Catalyst 9.4.
The patch from post #77 gives the usual errors and shows no models at all:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3757
--- Comment #80 from Joachim Rousseau syrion.com@gmail.com 2009-04-28 16:40:37 --- (In reply to comment #79)
All patches until 1.1.19 solved the issue with my NVidia 6800GT. With last patch for wine 1.1.20 I had a crash at first Eve run (between the charachter choice end the station loading), but the second launch was fine. And this crash may be unrelated, or due to some odd cache effect. Not tested for a long time.
--- Comment #81 from Bozhan Boiadzhiev bozhan@gmail.com 2009-04-30 15:08:26 --- why patch isn't accepted yet? i hate to compile things... :((((
--- Comment #82 from Joachim Rousseau syrion.com@gmail.com 2009-04-30 17:59:58 --- (In reply to comment #80)
(In reply to comment #79)
Only one problem : salvaging effect is very slow (less than 0.5fps) though I set shader quality to low. I may discover other issues like that I suppose.
--- Comment #83 from hpestilence hpestilence@gmail.com 2009-05-08 17:39:36 --- Created an attachment (id=20974) --> (http://bugs.winehq.org/attachment.cgi?id=20974) wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
--- Comment #84 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-08 18:31:32 --- I recommend to define a driver quirk in the quirk table in directx.c for this card/driver. I cannot do this because I do not have a dx10 ATI card to test with.
Besides, I think this should be fixed in fglrx 9.4, or am I mistaken?
--- Comment #85 from hpestilence hpestilence@gmail.com 2009-05-08 20:04:38 --- Nothing involving uniforms or varyings is fixed in the 9.4 drivers for my card at least glxinfo -l seems to report the same as the previous drivers. One of the people who beta tests the driver says 9.5 has more wine fixes, not sure which ones specifically though.
--- Comment #86 from Connor connormcl@hotmail.com 2009-05-09 08:36:33 --- (In reply to comment #83)
Created an attachment (id=20974)
--> (http://bugs.winehq.org/attachment.cgi?id=20974) [details]
wine-1.1.21 ati varying patch
This is just the part of the previous patch that makes it optional to set the varyings in the registry for dx10 ATI cards that have problems displaying models when they're used in a shader.
[Software\Wine\Direct3D] "MaxVaryings" = "52" (multiple of 4, example of a 68 varying card)
This is an example of a card supporting 68 varyings, use glxinfo -l to find out what fglrx is reporting. A lower value than 52 might be needed for some cards.
wine-1.1.21 with the patch does not work for me on ATI 3870.
wine compiles fine but hangs on login. Console says:
err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0024, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0028, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0025, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0027, blocked by 0021, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110054 "heap.c: main process heap section" wait timed out in thread 0026, blocked by 0021, retrying (60 sec)
--- Comment #87 from Connor connormcl@hotmail.com 2009-05-09 08:40:01 --- (In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
--- Comment #88 from hpestilence hpestilence@gmail.com 2009-05-10 00:17:34 --- Created an attachment (id=20998) --> (http://bugs.winehq.org/attachment.cgi?id=20998) ati dx10 varying float fix patch
This patch should work for those with dx10 ATI cards and using fglrx, it changes the max varying floats from 68 to 48 through the quirk table. I chose 48 to cover all hd2000 to hd4000 cards since it's been reported that 52 is too high for some.
--- Comment #89 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-10 04:47:40 --- This patch looks good to me. If it works, go ahead and send it to wine-patches.
--- Comment #90 from Connor connormcl@hotmail.com 2009-05-11 17:09:41 --- (In reply to comment #87)
(In reply to comment #86)
(In reply to comment #83)
The above was wine-1.1.21 at log in into a station.
When i use another account to log into space wine crashes and closes:
wine: Unhandled page fault on write access to 0x6c666556 at address 0x7ef93ca5 (thread 0019), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ef93ca5
wine-1.1.19 and wine-1.1.20 work fine
I did a git regression test and received this as the patch causing the crash:
f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 is first bad commit commit f9276a64295e5fdff6e8b68958ed9ef0e9a29c31 Author: Stefan Dösinger stefan@codeweavers.com Date: Thu May 7 17:31:20 2009 +0200
wined3d: Keep track of used float constants.
:040000 040000 ae0082c6c1dfce84694ea90dcab94cdf2d67d107 3d6199e8e08684e6c71188ee40a8b9a41ad3d82a M dlls
--- Comment #91 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:46:09 --- Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
Maybe we need to change something there to prevent a driver bug from causing a memory corruption in wined3d. The game will still not work, but at least we don't corrupt memory.
--- Comment #92 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-12 04:48:18 --- { match_ati_r300_to_500, quirk_ati_dx9, "ATI GLSL constant and normalized texrect quirk" },
Ah yeah, I limited the uniform fixup to <= r500 cards because (a) I expected a fixed r600+ driver soon, and (b) I don't have an r600 card to test. So someone may look into adding the uniform quirk for r600 cards too. (but don't do that normalized texrect stuff on r600. It has real NP2 support)
--- Comment #93 from Connor connormcl@hotmail.com 2009-05-12 09:02:17 --- (In reply to comment #91)
Maybe the crash is related to the incorrectly reported constants? Ie, if the driver says 128 constants and the fixup code doesn't catch it, the code will allocate a bitmap for 128 constants. If the shader uses 256 it will blow up memory.
What i did notice is that my driver does not report any maxvalues when "glxinfo -l" is issued.
I use opensuse 11.1 64bit, ATI 3850 and 3870 with Catalyst 9.4 and a "glxinfo -l" reports no maxvaryings or uniforms.
--- Comment #94 from hpestilence hpestilence@gmail.com 2009-05-14 20:53:53 --- Created an attachment (id=21105) --> (http://bugs.winehq.org/attachment.cgi?id=21105) atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
--- Comment #95 from hpestilence hpestilence@gmail.com 2009-05-14 23:53:38 --- Oh yeah, I did leave a bug report at the unofficial ATI bugzilla about the varying vec4 array > 13 is used.
Other ATI DX10 card users should report there too if you can't use 64 max_glsl_varyings.
http://ati.cchtml.com/show_bug.cgi?id=1555
--- Comment #96 from Connor connormcl@hotmail.com 2009-05-15 13:58:21 --- (In reply to comment #94)
Created an attachment (id=21105)
--> (http://bugs.winehq.org/attachment.cgi?id=21105) [details]
atidx10quirks.patch
Sorry, my card was getting the ati dx9 quirks applied so I didn't include the arb constants quirk.
This patch should apply to all ATI DX10 hardware.
I'm currently running EVE in high shader mode with everything rendering including exhumers and dreadnoughts :)
Confirming patch working on opensuse 11.1 64bit, wine-1.1.21, catalyst 9.4, ATI 3850.
No crash on login anymore.
--- Comment #97 from hpestilence hpestilence@gmail.com 2009-05-15 16:50:33 --- grr, catalyst 9.5 still reports the wrong opengl capabilities.
--- Comment #98 from Connor connormcl@hotmail.com 2009-05-23 09:07:26 --- The atidx10quirks patch still applies to wine-1.1.22 and works.
http://bugs.winehq.org/attachment.cgi?id=21105
--- Comment #99 from Connor connormcl@hotmail.com 2009-05-23 09:26:41 --- (In reply to comment #98)
The atidx10quirks patch still applies to wine-1.1.22 and works.
Correction:
The Hulk and other models do not render. And the camera at a POS does weird things.
Command line gives a few of these:
fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 582 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
--- Comment #100 from Stefan Dösinger stefandoesinger@gmx.at 2009-05-23 13:50:01 --- Maybe the dx10 clip pos uniform needs some adjustments for ati cards.
--- Comment #101 from hpestilence hpestilence@gmail.com 2009-05-23 16:16:31 --- Created an attachment (id=21273) --> (http://bugs.winehq.org/attachment.cgi?id=21273) wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Hulks and other mining ships rendered, but not a POS up close. If I moved the camera away then it would show the model and also the model would render fine when viewing it with the preview screen. However I've seen windows users complaining about how a POS was "aligning" with their ship so it could be a problem with the EVE client itself. Also there weren't any opengl error messages that would cause the POS not to render from my logs.
--- Comment #102 from Connor connormcl@hotmail.com 2009-05-25 13:46:41 --- (In reply to comment #101)
Created an attachment (id=21273)
--> (http://bugs.winehq.org/attachment.cgi?id=21273) [details]
wine-1.1.22-atidx10quirks.patch
This is the patch I used with git and 1.1.22, basically I removed all the reserved uniforms in the quirks part.
Game seems to work so far. Only when the map is opened, i get many lines of these:
fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3872
But the map works and seems to show everything.
--- Comment #103 from hpestilence hpestilence@gmail.com 2009-05-25 20:31:01 --- It looks like a shader needing 248 uniforms is created when the map is used. The only way to easily workaround that is to subtract 2 instead of 3 in the max_constantsF of dlls/wined3d/glsl_shader.c but I didn't notice any difference in the map.
Also I found some GL_INVALID_ENUMs caused by bug http://bugs.winehq.org/show_bug.cgi?id=11167 so I added it to the bugs list for EVE.
http://bugs.winehq.org/show_bug.cgi?id=17437
Henrik Pihl henrik@saarlane.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|henrik@saarlane.ee |
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #104 from hpestilence hpestilence@gmail.com 2009-06-05 23:17:01 --- With wine-1.1.23 eve started crashing on startup for me, the patch from comment 5 of bug http://bugs.winehq.org/show_bug.cgi?id=18794 fixes it.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #105 from hpestilence hpestilence@gmail.com 2009-06-09 18:04:17 --- Looks like catalyst 9.6 has the opengl capability fixes in it and it gets released next week, I can't wait :) :
http://www.ozone3d.net/gpu/db/index.php?which=ecd621de1fccf14785e61c76fede62...
Also I suggest running eve-online with OffscreenRenderingMode = backbuffer in the registry. It greatly improved my fps and stopped the random crashes in wine-1.1.23 (even with Henri's patch) but stopped rendering hdr and shadows which I think requires fbo.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #106 from Mathieu Belanger b747xx@gmail.com 2009-06-10 08:47:08 --- I see in my old bug report on ATI unofficial bugzilla : http://ati.cchtml.com/show_bug.cgi?id=1462 that the problem has been fixed in internal Catalyst release near march 02. Post by pierre.boudier@amd.com also state that a latency of +- 3 months exist between internal and public release of catalyst! So this match with the hpestilence post about the bug fixed in the next cata version!
I will hunt for this Catalyst 9.6 and repost here if I find it!
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #107 from hpestilence hpestilence@gmail.com 2009-06-13 00:47:15 --- Created an attachment (id=21767) --> (http://bugs.winehq.org/attachment.cgi?id=21767) atidx10caps + reserved_color_varyings patch
I decided to looking into the varyings again since the fixed catalyst 9.6 release is upon us soon. Looking through the wine logs and source I realized that I tested the test program wrong. I was setting both fragment and vertex shaders to use an array of 12 varyings in order to compile successfully, but I only needed to set 12 in the fragment shader.
So testing again I found out that gl_FrontColor and gl_FrontSecondaryColor are part of the total 64 varyings that can be used. For example, wine is setting an array of varying vec4 IN[15] (-1 for clip varyings) then uses them all and then ends with gl_FrontColor and gl_FrontSecondaryColor which is 17 varyings for ATI.
I fxied it by reserving 2 varyings in the vec4_varyings function and combined it in with the opengl capabilities fixes, but I'll clean it up and submit it without the opengl cap fixes if it looks alright.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #108 from hpestilence hpestilence@gmail.com 2009-06-15 13:03:28 --- http://www.phoronix.com/forums/showthread.php?t=17728
Catalyst 9.6 is out. Looks like it has to be compiled the same way 9.5 had to be for kernel > 2.6.28, but I'm running it currently and it does fix the uniforms and varyings that are reported.
http://bugs.winehq.org/show_bug.cgi?id=17437
hpestilence hpestilence@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #21767|0 |1 is obsolete| |
--- Comment #109 from hpestilence hpestilence@gmail.com 2009-06-16 10:07:16 --- Created an attachment (id=21827) --> (http://bugs.winehq.org/attachment.cgi?id=21827) varying fix for ati
This patch is from the wine-devel mailing list, use it together with catalyst 9.6 and the current wine from git (so that fbo works) to make shaders work.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #110 from Henri Verbeet hverbeet@gmail.com 2009-06-17 15:33:35 --- (In reply to comment #109)
Created an attachment (id=21827)
--> (http://bugs.winehq.org/attachment.cgi?id=21827) [details]
varying fix for ati
This patch is from the wine-devel mailing list, use it together with catalyst 9.6 and the current wine from git (so that fbo works) to make shaders work.
Should be fixed in current git by 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #111 from hpestilence hpestilence@gmail.com 2009-06-17 16:17:21 --- Confirming it's fixed for me, thanks :D
http://bugs.winehq.org/show_bug.cgi?id=17437
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #112 from Dmitry Timoshkov dmitry@codeweavers.com 2009-06-18 01:34:28 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #113 from Eddy Y. jeyoung@priscimon.com 2009-06-18 04:03:35 --- (In reply to comment #110)
(In reply to comment #109)
Created an attachment (id=21827)
--> (http://bugs.winehq.org/attachment.cgi?id=21827) [details] [details]
varying fix for ati
This patch is from the wine-devel mailing list, use it together with catalyst 9.6 and the current wine from git (so that fbo works) to make shaders work.
Should be fixed in current git by 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002.
I am fairly new to git.
How do I get that specific 'changeset'?
Thanks.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #114 from Henri Verbeet hverbeet@gmail.com 2009-06-18 04:09:19 --- (In reply to comment #113)
(In reply to comment #110)
Should be fixed in current git by 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002.
I am fairly new to git.
How do I get that specific 'changeset'?
"git show 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002" will show you the specific patch, but if you just checkout today's git it will have that patch included.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #115 from Eddy Y. jeyoung@priscimon.com 2009-06-18 04:17:15 --- (In reply to comment #114)
(In reply to comment #113)
(In reply to comment #110)
Should be fixed in current git by 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002.
I am fairly new to git.
How do I get that specific 'changeset'?
"git show 2c009e4d874722c1a7b50b1c0ecf7a7eaa3e9002" will show you the specific patch, but if you just checkout today's git it will have that patch included.
In this case, I have built the correct source, and I would like to report the following problems.
Ubuntu 9.04 Jaunty AMD64 ATI Radeon HD 3450 Catalyst 9.6
Registry settings are set as follows:
[Software\Wine\Direct3D] "DirectDrawRenderer"="opengl" "OffscreenRenderingMode"="fbo" "PixelShaderMode"="enabled" "VertexShaderMode"="hardware"
(I understand that tme MAX_* values need not be set with Catalyst 9.6. Is this correct?)
1. Adapter reported as Radeon 9500 in EVE Online. I believe it showed as Direct3D HAL before that.
2. Station models are not showing.
Cheers.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #116 from Connor connormcl@hotmail.com 2009-06-18 10:39:04 --- (In reply to comment #108)
http://www.phoronix.com/forums/showthread.php?t=17728
Catalyst 9.6 is out. Looks like it has to be compiled the same way 9.5 had to be for kernel > 2.6.28, but I'm running it currently and it does fix the uniforms and varyings that are reported.
I just installed Catalyst 9.6 on opensuse 11.1, 64bit using an ATI 3850 and 3870 graphics card.
The output of "glxinfo -l" remains unchanged. There are still no values listed regarding MaxVertexUniforms, MaxFragmentUniforms or MaxVaryings.
I have attached the output of "glxinfo -l".
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #117 from Connor connormcl@hotmail.com 2009-06-18 10:40:51 --- Created an attachment (id=21873) --> (http://bugs.winehq.org/attachment.cgi?id=21873) output of glxinfo -l with ATI 3870
Output of glxinfo -l with ATI 3870 and catalyst 9.6.
Varyings etc. still missing.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #118 from hpestilence hpestilence@gmail.com 2009-06-18 14:56:12 --- Created an attachment (id=21874) --> (http://bugs.winehq.org/attachment.cgi?id=21874) Add 3400 renderer string patch
Try this patch Eddy, it seems a "HD 3400" string was missing in the ati card list.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #119 from hpestilence hpestilence@gmail.com 2009-06-18 15:54:24 --- As for Conrad,
According to http://en.opensuse.org/Product_Highlights/11.1
Your using Mesa 7.2 but I don't think the opengl shader limits were added until 7.3 (mesa is where glxinfo comes from). Wine gets the correct values for varyings, uniforms, and other opengl limits by directly asking the driver. I was just using glxinfo as an easy way to see the previously broken shader limits :)
I'm currently using Mesa 7.4 on archlinux btw.
http://bugs.winehq.org/show_bug.cgi?id=17437
--- Comment #120 from Eddy Y. jeyoung@priscimon.com 2009-06-19 02:39:19 --- (In reply to comment #118)
Created an attachment (id=21874)
--> (http://bugs.winehq.org/attachment.cgi?id=21874) [details]
Add 3400 renderer string patch Try this patch Eddy, it seems a "HD 3400" string was missing in the ati card list.
Thanks. I'll try this tonight. Is there any chance it will have made it in git?
http://bugs.winehq.org/show_bug.cgi?id=17437
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #121 from Alexandre Julliard julliard@winehq.org 2009-06-19 11:04:10 --- Closing bugs fixed in 1.1.24.
-
wine-bugs＠winehq.org