[Bug 16310] New: The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

Summary: The Blizzard game downloader hangs on startup
           Product: Wine
           Version: 1.1.9
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When installing a Blizzard game (in this case, the StarCraft & BroodWars combo
pack), starting the Blizzard downloader to download the game the application
hangs after initially showing the window.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

Reece Dunn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]-
                   |                            |berlin.de

--- Comment #1 from Reece Dunn   2008-12-02 17:02:11 ---
Doing a regression test has found the following commit:

commit afb17f29e17b8b2cd6e62b8bf0d2ae02166db573
Author: Michael Karcher 
Date:   Sat Nov 29 10:52:24 2008 +0100

msxml3: attach_xmldoc may fail.

The upcoming new implementation of attach_xmldoc needs HeapAlloc. Prepare
    for the failure case.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #2 from Michael Karcher   2008-12-02 17:07:03 ---
Could you please attach a msxml debug log?

Regards,
  Michael Karcher

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #3 from Reece Dunn   2008-12-02 17:20:51 ---
Hmmm... that's strange: it is working now. It's possible that the widl changes
did not rebuild everything they needed to, but they got shaken out when I
resynched from that commit to HEAD.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #4 from Michael Karcher   2008-12-03 02:36:38 ---
It might also have an external cause. If that patch broke behaviour when the
xml download via network failed, the breakage is only visible when the primary
(i.e. first tried) download server is down. I reviewed that patch and still
consider it safe, but I feel I have to stress-test the failure case.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #5 from Reece Dunn   2008-12-03 02:45:54 ---
I also had a look at that specific patch and couldn't see anything wrong with
it.

Maybe, as you said, the issue is transitory and/or environmental. I only ran
the downloader once in each bisect, so if it is an intermittent failure then
the bisect results would be unreliable - hence it picking up a good patch.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #6 from Reece Dunn   2008-12-03 02:53:07 ---
Ok, so I have tried starting the downloader several times and have it hanging 4
times out of 15 tries (about 1 in 4 attempts).

I will perform another bisect to get a more accurate location for the issue.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #7 from Michael Karcher   2008-12-03 03:32:54 ---
As your bisect only got false "good", but no false "bad" results, you can set
the upper limit at the patch you identified. My gut feeling tells me, that the
previous patch, although I currently can't see any code flow where that patch
might harm:

Author: Michael Karcher 
 Date:   Tue Nov 25 00:33:49 2008 +0100

msxml3: remove attach_xmldoc(This, NULL) calls

might be the real culprit. In any case, if it is any patch of the msxml3
series, please attach a msxml log of a failed attempt.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #8 from Reece Dunn   2008-12-03 03:45:47 ---
When I tested it with wine-1.1.8, it failed on the first go, so it can't be
your patches.

Trying with wine-1.1.5, it failed once in 15 tries. I'll need to retest
wine-1.1.8 to see how often it fails. I don't fully understand this yet, so I
don't really trust the bisect results here.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #9 from Reece Dunn   2008-12-03 03:49:34 ---
Looking at the error output on the console, I am seeing:

fixme:shell:BrsFolder_OnCreate flags BIF_NEWDIALOGSTYLE partially implemented
fixme:bidi:mirror stub: mirroring of characters not yet implemented
err:ntdll:RtlpWaitForCriticalSection section 0x7ea35fe0 "freetype.c:
freetype_cs" wait timed out in thread 003a, blocked by 002d, retrying (60 sec)
err:ntdll:RtlpWaitForCriticalSection section 0x7ea36080 "gdiobj.c: GDI_level"
wait timed out in thread 002d, blocked by 003a, retrying (60 sec)
Killed

on wine-1.1.5, so I suspect that these may be the real culprit - that would
better explain the hang.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #10 from Michael Karcher   2008-12-03 04:56:50 ---
You might also want to try with native msxml3[1]. It works quite well under
wine. If you still get problems in wine-1.1.9, the problem is definitely
elsewhere.

1: wintricks can do that.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #11 from Reece Dunn   2008-12-03 16:08:43 ---
I have tried one of the movie downloaders for StarCraft 2 to see if these
exhibit the same issue (tried it about 15 times). Testing with yesterday's git
tip, these do not show the lockup.

These are similar applications, but the movie one uses a standard file open
dialog, whereas the game one uses the browse for folders (BIF_NEWDIALOGSTYLE)
dialog.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

--- Comment #12 from Austin English   2009-06-02 10:38:02 ---
Is this still an issue in current (1.1.22 or newer) wine?

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #13 from Austin English   2010-03-11 17:24:51 ---
No response in 8 months, marking abandoned. If you still have an issue in
current (1.1.40 or newer) wine, and can provide the needed information, feel
free to reopen.

[Bug 16310] The Blizzard game downloader hangs on startup

http://bugs.winehq.org/show_bug.cgi?id=16310

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Austin English   2010-03-11 17:26:05 ---
Closing.