[Bug 33720] New: user32:menu

http://bugs.winehq.org/show_bug.cgi?id=33720

Bug #: 33720
           Summary: user32:menu
           Product: Wine
           Version: 1.5.19
          Platform: x86
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

A number of VMs report one or both of this pair of test failures:

menu.c:1222: ANSI tests: string 0028FB98 hbm BF050D4A txt 0028FD18
menu.c:1400: Test failed: InsertMenuItem should have failed.
menu.c:1222: Unicode tests: string 0028FB98 hbm BF050D4A txt 0028FE18
menu.c:1400: Test failed: InsertMenuItem should have failed.

They have been seen on the following systems:

user32 6.0.6002.18005 WVISTAX64 (old TestBot VM)
user32 6.0.6002.18005 Windows Vista Home Premium SP2+IE9 (new TestBot VM)
user32 6.1.7600.16385 W7PROX64 (old TestBot VM)
user32 6.1.7600.16385 Windows 7 Ultimate 64-bit (+IE8) (32-bit tests)
user32 6.1.7601.17514 Windows 7 Ultimate SP1 64-bit + IE9 (32-bit tests)
user32 6.1.7601.17514 Windows 7 SP1 64-bit (Cookiezzz97)
user32 6.1.7601.17514 Windows 7 SP1 64-bit (Alistair)

[Bug 33720] user32:menu

http://bugs.winehq.org/show_bug.cgi?id=33720

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 33720] user32:menu

http://bugs.winehq.org/show_bug.cgi?id=33720

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 33720] user32:menu

https://bugs.winehq.org/show_bug.cgi?id=33720

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                URL|                            |http://test.winehq.org/data
                   |                            |/tests/user32:menu.html
    Regression SHA1|                            |b34868dffa0df144ea9d6e1586a
                   |                            |67cff70ae9c4e

--- Comment #1 from François Gouget  ---
These test failures are still present and impact Vista, Windows 7 and Windows
8/8.1 (e.g. my Acer laptop) systems. See:

http://test.winehq.org/data/tests/user32:menu.html

The commit that introduced this test is:

commit b34868dffa0df144ea9d6e1586a67cff70ae9c4e
Author: Rein Klazes 
Date:   Tue Jan 3 13:23:28 2006 +0100

user32: Separate menu bitmaps and strings.
    Store bitmaps and bitmaps always in separate fields in the internal
    menu structure.  Get rid of a lot of assumptions in the code that the
    menu can have strings only when it is not some other type and that
    bitmaps come in two flavors.
    Add a lot of conformance tests, including some submitted by Jason
    Edmeades.

[Bug 33720] user32:menu

https://bugs.winehq.org/show_bug.cgi?id=33720

--- Comment #2 from Alexandre Julliard  ---
Is this still happening?

[Bug 33720] user32:menu

https://bugs.winehq.org/show_bug.cgi?id=33720

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from François Gouget  ---
It looks like this got fixed by an unidentified commit. Marking as resolved.

[Bug 33720] user32:menu

https://bugs.winehq.org/show_bug.cgi?id=33720

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.8-rc2.