http://bugs.winehq.org/show_bug.cgi?id=28645
Bug #: 28645 Summary: Classic Shell installer fails to extract setup file Product: Wine Version: 1.3.30 Platform: x86-64 URL: http://sourceforge.net/projects/classicshell/files/Ver sion%203.2.0%20general%20release/ClassicShellSetup_3_2 _0.exe/download OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: RandomAccountName@mail.com Classification: Unclassified
Running the installer (with the reported Windows version set to Vista or later - XP is not supported) fails immediately with the following error:
Failed to extract setup file '%ALLUSERSPROFILE%\ClassicShellSetup32_3_2_0.msi'
Complete terminal output: fixme:shell:DoEnvironmentSubstW (L"%ALLUSERSPROFILE%\ClassicShellSetup32_3_2_0.msi", 260): stub
http://bugs.winehq.org/show_bug.cgi?id=28645
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer, source
http://bugs.winehq.org/show_bug.cgi?id=28645
Louis Lenders xerox_xerox2000@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |xerox_xerox2000@yahoo.co.uk Ever Confirmed|0 |1
--- Comment #1 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2011-10-11 09:27:22 CDT --- Confirming.
I guess we should just improve the stub to expand the environmentstring. I'll see if i can write some tests + fix later this week, but if anyone else would like to do so, beat me to it
http://bugs.winehq.org/show_bug.cgi?id=28645
--- Comment #2 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2011-10-11 13:51:22 CDT --- Created attachment 36826 --> http://bugs.winehq.org/attachment.cgi?id=36826 patch
it appears that DoEnvironmentSubstA is already more or less implemented, so a simple copy and paste patch is enough to fix this bug (try the attached patch)
i'll see if i can add some tests as well
http://bugs.winehq.org/show_bug.cgi?id=28645
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #3 from A Wine user RandomAccountName@mail.com 2011-10-12 03:41:58 CDT --- (In reply to comment #2)
it appears that DoEnvironmentSubstA is already more or less implemented, so a simple copy and paste patch is enough to fix this bug (try the attached patch)
The patch works fine for me, thanks. Then the program hits unimplemented functions, but I see you've sent patches for those already. With all three patches, the included configuration programs seem to work (with some visual problems).
http://bugs.winehq.org/show_bug.cgi?id=28645
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shell32
http://bugs.winehq.org/show_bug.cgi?id=28645
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com 2012-12-05 16:36:27 CST --- A patch implementing DoEnvironmentSubstW was commited: http://source.winehq.org/git/wine.git/?a=commit;h=ff2f4941951b99acdb46fa67d6...
http://bugs.winehq.org/show_bug.cgi?id=28645
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ff2f4941951b99acdb46fa67d64 | |c8069431171c0 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #5 from A Wine user RandomAccountName@mail.com 2012-12-06 02:42:34 CST --- (In reply to comment #4)
A patch implementing DoEnvironmentSubstW was commited: http://source.winehq.org/git/wine.git/?a=commit;h=ff2f4941951b99acdb46fa67d6...
Classic Shell installation is now successful (wine-1.5.18-261-g60195ff). Thanks Detlef!
http://bugs.winehq.org/show_bug.cgi?id=28645
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2012-12-07 13:36:03 CST --- Closing bugs fixed in 1.5.19.
-
wine-bugs＠winehq.org