[Bug 54761] New: D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

Bug ID: 54761
           Summary: D3D12CreateDevice no longer in ABI of
                    libvkd3d-utils.so.1
           Product: vkd3d
           Version: 1.7
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vkd3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While looking at updating Debian's vkd3d package from 1.2 to 1.7, I noticed
that `D3D12CreateDevice@VKD3D_1_0` disappeared from the ABI of
libvkd3d-utils.so.1. Was this intentional?

(D3D12CreateDeviceVKD3D@VKD3D_1_0 is still there, but if I'm understanding the
intention of this library correctly, D3D12CreateDevice@VKD3D_1_0 should have
continued to be present for backwards compat with older library binaries.)

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

--- Comment #1 from Henri Verbeet  ---
Created attachment 74255
  --> https://bugs.winehq.org/attachment.cgi?id=74255
patch

No, that was unintentional. It looks like this may have been an unfortunate
side effect of commit d27fee64ab51c60078215f461a797edd32bc8871. I believe the
attached patch should help; thank you for bringing this to our attention.

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression
    Regression SHA1|                            |d27fee64ab51c60078215f461a7
                   |                            |97edd32bc8871

--- Comment #2 from Zeb Figura  ---
Ouch, sorry about that one :-(

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

--- Comment #3 from Simon McVittie  ---
(In reply to Henri Verbeet from comment #1)
> Created attachment 74255

Yes, I confirm this patch reinstates the missing symbol and dpkg's ABI checking
is happy again. Thanks!

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

--- Comment #4 from Henri Verbeet  ---
This should be fixed by commit 4e32adb8c1173a9a380ec3fd54d3c2b497a63f15.

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |4e32adb8c1173a9a380ec3fd54d
                   |                            |3c2b497a63f15
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Henri Verbeet  ---
Resolving FIXED.

[Bug 54761] D3D12CreateDevice no longer in ABI of libvkd3d-utils.so.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54761

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Henri Verbeet  ---
This was released as part of the vkd3d 1.7.1 and 1.8 releases.