[Bug 13810] New: D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

Summary: D3DSwapChainImpl_Destroy() shouldn't call
                    SetDisplayMode() in D3D7
           Product: Wine
           Version: 1.0-rc4
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=13851)
 --> (http://bugs.winehq.org/attachment.cgi?id=13851)
Add a dx version check before calling SetDisplayMode in
D3DSwapChainImpl_Destroy

D3DSwapChainImpl_Destroy() function in dlls/wined3d/swapchain.c shouldn't call
SetDisplayMode() when D3D7 is used. This problem cause some 2D graphics
corruptions and switch to wrong screen resolution in Speed Busters game.
The patch in attachment add just a dx version check before calling
SetDisplayMode() to prevent a redundant call with one done by ddraw module.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English   2008-06-09 15:35:02 ---
Please add a conformance test to prove this behavior is correct in windows and
submit to [e-mail]

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

--- Comment #2 from Austin English   2008-12-08 04:19:49 ---
Is this still an issue in current (1.1.10 or newer) wine?

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

--- Comment #3 from Austin English   2009-06-08 11:35:18 ---
Ping.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

--- Comment #4 from Guillaume Prouvot   2009-06-16 13:27:33 ---
Sorry for the long time response, I'am very busy this days...

This problem is still present in current version (1.1.23). The small program I
sent to [e-mail] some months ago report same results.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

--- Comment #5 from Austin English   2010-05-19 16:25:41 ---
Still present.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from joaopa  2011-05-26 09:33:24 CDT ---
Does the bug still occur?

If yes, does it occurs with the demo

http://www.jeuxvideo.com/telecharger/jeux-et-demos/00000476-speed-busters-pc...

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #7 from Austin English  2012-02-23 15:19:56 CST ---
Removing deprecated 'All' Platform/OS.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

http://bugs.winehq.org/show_bug.cgi?id=13810

--- Comment #8 from Bruno Jesus  2013-09-03 11:36:14 CDT ---
The swapchain.c file has changed completely since this bug was opened, the
patch cannot be applied even manually.

If we can't find a way to test this bug I'll close it as abandoned soon.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

https://bugs.winehq.org/show_bug.cgi?id=13810

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |ABANDONED

--- Comment #9 from Austin English  ---
(In reply to Bruno Jesus from comment #8)
> The swapchain.c file has changed completely since this bug was opened, the
> patch cannot be applied even manually.
>
> If we can't find a way to test this bug I'll close it as abandoned soon.

Abandoned.

[Bug 13810] D3DSwapChainImpl_Destroy() shouldn't call SetDisplayMode() in D3D7

https://bugs.winehq.org/show_bug.cgi?id=13810

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Austin English  ---
Closing.