[Bug 57575] New: dmsynth: incorrect condition for buffer underrun in synthsink.c:synth_sink_write_data

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57575

Bug ID: 57575
           Summary: dmsynth: incorrect condition for buffer underrun in
                    synthsink.c:synth_sink_write_data
           Product: Wine
           Version: 9.22
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dmusic
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

Noting this here, so it won't get forgotten.

In synth_sink_write_data there's following condition:

if (current_pos - play_pos <= write_pos - play_pos)

it causes a lot of console spam while current_pos == write_pos.

I though it was perhaps some odd way of preventing integer over/underflow, but
the author of that line, when asked on irc, basically said 'yeah, it's bogus'.