[Bug 36571] New: valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Bug ID: 36571
           Summary: valgrind shows some invalid memory use in
                    shell32/tests/path.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]

==5658== Invalid read of size 1
==5658==    at 0x402EB35: bcmp (vg_replace_strmem.c:965)
==5658==    by 0x4ED0EED: is_knownfolder (shellpath.c:3790)
==5658==    by 0x4ED1052: foldermanager_GetFolder (shellpath.c:3819)
==5658==    by 0x4CDAB24: test_knownFolders (shobjidl.h:16490)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==  Address 0x49cc458 is 0 bytes inside a block of size 1,664 free'd
==5658==    at 0x7BC4C72C: notify_free (heap.c:263)
==5658==    by 0x7BC51071: RtlFreeHeap (heap.c:1762)
==5658==    by 0x5B02C4E: IMalloc_fnFree (ifs.c:265)
==5658==    by 0x5B0311D: CoTaskMemFree (objidl.h:1242)
==5658==    by 0x4CDA857: test_knownFolders (shellpath.c:2164)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==

==5658== Invalid read of size 1
==5658==    at 0x402EB35: bcmp (vg_replace_strmem.c:965)
==5658==    by 0x4ED0EED: is_knownfolder (shellpath.c:3790)
==5658==    by 0x4ED1052: foldermanager_GetFolder (shellpath.c:3819)
==5658==    by 0x4CDAFDC: test_knownFolders (shobjidl.h:16490)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==  Address 0x49cc458 is 0 bytes inside a block of size 1,664 free'd
==5658==    at 0x7BC4C72C: notify_free (heap.c:263)
==5658==    by 0x7BC51071: RtlFreeHeap (heap.c:1762)
==5658==    by 0x5B02C4E: IMalloc_fnFree (ifs.c:265)
==5658==    by 0x5B0311D: CoTaskMemFree (objidl.h:1242)
==5658==    by 0x4CDA857: test_knownFolders (shellpath.c:2164)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==

==5658== Invalid free() / delete / delete[] / realloc()
==5658==    at 0x7BC4C72C: notify_free (heap.c:263)
==5658==    by 0x7BC51071: RtlFreeHeap (heap.c:1762)
==5658==    by 0x4ED0B05: foldermanager_Release (shellpath.c:3710)
==5658==    by 0x4CDD44E: test_knownFolders (shobjidl.h:16477)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==  Address 0x49cc458 is 0 bytes inside a block of size 1,664 free'd
==5658==    at 0x7BC4C72C: notify_free (heap.c:263)
==5658==    by 0x7BC51071: RtlFreeHeap (heap.c:1762)
==5658==    by 0x5B02C4E: IMalloc_fnFree (ifs.c:265)
==5658==    by 0x5B0311D: CoTaskMemFree (objidl.h:1242)
==5658==    by 0x4CDA857: test_knownFolders (shellpath.c:2164)
==5658==    by 0x4CDE323: func_shellpath (shellpath.c:2660)
==5658==    by 0x4D14454: run_test (test.h:584)
==5658==    by 0x4D14843: main (test.h:654)
==5658==

[Bug 36571] valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.7.18                      |1.7.19

[Bug 36571] valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36571] valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Thomas Faller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Thomas Faller  ---
I can't reproduce this issue.
Is this still present in your test runs?

[Bug 36571] valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e4868d563574853d40ca04adfc2
                   |                            |8db1c19ca9dbf
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
       Distribution|---                         |Fedora

--- Comment #2 from Austin English  ---
No, fixed by:
commit e4868d563574853d40ca04adfc28db1c19ca9dbf
Author: Andrew Eikum 
Date:   Wed Apr 8 10:59:33 2015 -0500

shell32: Allocate returned array in IKnownFolderManager::GetFolderIds.

[Bug 36571] valgrind shows some invalid memory use in shell32/tests/path.c

https://bugs.winehq.org/show_bug.cgi?id=36571

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.52.