[Bug 14711] New: 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Summary: 'Type' command in cmd.exe does not line feed in the end
                    of a file
           Product: Wine
           Version: 1.1.2
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

1. Run Wine's cmd.exe
2. Enter command 'type file.txt'
3. The command prompt after the file printed on the screen would appear not in
the new line, but in the end of the last line in file file.txt.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #1 from Lei Zhang   2008-08-01 13:42:13 ---
seems to work fine here:

$ echo hi > foo.txt
$ cat foo.txt
hi
$ wine cmd
CMD Version 1.1.2

Z:\home\thestig>type foo.txt
hi
Z:\home\thestig>

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
         OS/Version|All                         |other
           Platform|All                         |Other

--- Comment #2 from Vitaliy Margolen   2008-08-01 23:47:34 ---
Well Wine duplicates _correct_ behavior of the *NIX word. But I'm guessing you
talking about brain damage of windows that always prints new line at the and:

vitaliy@dragon:tmp $echo -ne "123\n456" > test
vitaliy@dragon:tmp $wine cmd /c type test
123
456vitaliy@dragon:tmp $echo -ne "123\n456\n" > test
vitaliy@dragon:tmp $wine cmd /c type test
123
456
vitaliy@dragon:tmp $

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #3 from Austin English   2009-02-17 11:05:46 ---
Still present in git.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #4 from Nikolay Sivov   2009-02-17 14:03:53 ---
Patch's in list

http://www.winehq.org/pipermail/wine-patches/2009-February/069505.html

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Ilya Chernykh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #5 from Nikolay Sivov   2009-02-18 10:56:43 ---
Patch is in git.
http://source.winehq.org/git/wine.git/?a=commit;h=78f38a742fb48a723392687615...

Test with current version.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #6 from Austin English   2009-02-18 11:54:34 ---
(In reply to comment #5)
> Patch is in git.
> http://source.winehq.org/git/wine.git/?a=commit;h=78f38a742fb48a723392687615...
>
> Test with current version.

Seems to add two newlines:

XP:
C:\Documents and Settings\Austin\Desktop>type a.txt
asdf
C:\Documents and Settings\Austin\Desktop>

Wine:
austin@SERVER1:~$ cat /home/austin/wine-git/foo.txt
asdf
austin@SERVER1:~$

CMD Version 1.1.15

Z:\home\austin\wine-git>type foo.txt
asdf

Z:\home\austin\wine-git>

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #7 from Nikolay Sivov   2009-02-18 12:03:06 ---
(In reply to comment #6)
> Seems to add two newlines:
>
> XP:
> C:\Documents and Settings\Austin\Desktop>type a.txt
> asdf
> C:\Documents and Settings\Austin\Desktop>
>
> Wine:
> austin@SERVER1:~$ cat /home/austin/wine-git/foo.txt
> asdf
> austin@SERVER1:~$
>
> CMD Version 1.1.15
>
> Z:\home\austin\wine-git>type foo.txt
> asdf
>
> Z:\home\austin\wine-git>

Post a test file for that case.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Austin English   2009-02-18 14:12:08 ---
I'll take a look tomorrow at work. Trying again at home, could've been an error
on my part.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #9 from Nikolay Sivov   2009-02-28 05:04:06 ---
Test this again please with 1.1.16.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #10 from Ilya Chernykh   2009-02-28 06:03:06 ---
Well it seems unlike Windows it now skips one more line: between the last file
line and new prompt there is now one empty line.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #11 from Ilya Chernykh   2009-02-28 06:05:52 ---
But if to type from a device such as console it works in old manner: does not
skip the last line and shows prompt in the same line:

Z:\home\nxx>type con
dffgbfg
dffgbfg
gbfgbgh
gbfgbgh
fbvfgbf
fbvfgbf
^Cnxx@nxx-desktop:~$

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #12 from Ilya Chernykh   2009-02-28 06:07:05 ---
Sorry the last pos is a mistake: it seems afteer Ctrl+C it exited Wine at all.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #13 from Nikolay Sivov   2009-02-28 06:32:13 ---
(In reply to comment #10)
> Well it seems unlike Windows it now skips one more line: between the last file
> line and new prompt there is now one empty line.

Post a test file for this please.

(In reply to comment #12)
> Sorry the last pos is a mistake: it seems afteer Ctrl+C it exited Wine at all.

Exactly, but this could be a general problem for Wine CMD.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #14 from Ilya Chernykh   2009-02-28 09:45:44 ---
Yes. There is a more major problem: it does not support Cyrillic.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #15 from Nikolay Sivov   2009-02-28 09:56:13 ---
(In reply to comment #14)
> Yes. There is a more major problem: it does not support Cyrillic.

Still, what about a test text file that shows redundant trailing newlines for
you?

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #16 from Ilya Chernykh   2009-02-28 10:28:38 ---
It does show one empty line. If this is a general problem of CMD, I have
nothing to add.

Anyway it's much better than what was before the patch.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Ilya Chernykh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Ilya Chernykh   2009-03-25 15:39:15 ---
I think this bug should be closed as DOSBox behaves the same way as Wine now
after the patch. I suppose Windows works also the same way, but cannot check.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

--- Comment #18 from Austin English   2009-03-25 16:03:35 ---
Yeah, I can't find one that's broken, tried a few different combos.
Mac/Unix/Windows style new lines all seem to work fine.

[Bug 14711] 'Type' command in cmd.exe does not line feed in the end of a file

http://bugs.winehq.org/show_bug.cgi?id=14711

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard   2009-03-27 13:53:41 ---
Closing bugs fixed in 1.1.18.