[Bug 28684] New: Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

Bug #: 28684
           Summary: Incomplete check for Mesa's gl_vendor_string in
                    wined3d_guess_card_vendor.
           Product: Wine
           Version: unspecified
          Platform: All
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

wined3d_guess_card_vendor checks for Mesa by comparing gl_vendor_string to
"Mesa", "Tungsten Graphics, Inc" and "VMware, Inc.". The GDI driver (no idea
about the other drivers) reports "Brian Paul" as can be seen here:
http://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n88 thus
Mesa is not recognized. The easiest solution would be adding another comparison
for "Brian Paul" to the check.

[Bug 28684] Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
           Severity|normal                      |minor

--- Comment #1 from Dmitry Timoshkov  2011-10-12 23:45:36 CDT ---
Wine version? Are you really running on Windows platform?

[Bug 28684] Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

--- Comment #2 from [e-mail] 2011-10-13 06:06:45 CDT ---
I'm running on Windows using Mesa's Windows GDI driver. As I said I didn't try
what version Mesa reports with other drivers / on other platforms as I only
built Win binary. Wine version is 1.3.21 but I checked master HEAD and it's the
same.

This is what wined3d says:
fixme:(dlls/wined3d/directx.c:1395) Received unrecognized GL_VENDOR "Brian
Paul". Returning HW_VENDOR_NVIDIA.

wined3d_guess_gl_vendor works because it checks for occurence of "Mesa" in the
vendor string which for the GDI driver is "Mesa Windows GDI Driver".

[Bug 28684] Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.3.30

[Bug 28684] Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |aacbc7e2b7f711cb508c2b21ceb
                   |                            |afd40017e7ea3
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English  2011-10-13 14:29:12 CDT ---
Fixed by
http://source.winehq.org/git/wine.git/commitdiff/aacbc7e2b7f711cb508c2b21ceb...

[Bug 28684] Incomplete check for Mesa's gl_vendor_string in wined3d_guess_card_vendor.

http://bugs.winehq.org/show_bug.cgi?id=28684

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2011-10-21 13:49:07 CDT ---
Closing bugs fixed in 1.3.31.