[Bug 36383] New: valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

Bug ID: 36383
           Summary: valgrind shows several uninitialized values in
                    ddraw_CreateSurface() in ddraw/tests/dsurface.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

fixme:win:EnumDisplayDevicesW ((null),0,0x549f568,0x00000000), stub!
==5763== Conditional jump or move depends on uninitialised value(s)
==5763==    at 0x4AEBCC2: ddraw_surface_create (surface.c:5849)
==5763==    by 0x4AC147F: ddraw1_CreateSurface (ddraw.c:2962)
==5763==    by 0x515E72E: SrcColorKey32BlitTest (dsurface.c:240)
==5763==    by 0x516CEB4: func_dsurface (dsurface.c:3949)
==5763==    by 0x50CC30B: main (test.h:584)
==5763==  Uninitialised value was created by a stack allocation
==5763==    at 0x515E671: SrcColorKey32BlitTest (dsurface.c:217)
==5763==

==5763== Conditional jump or move depends on uninitialised value(s)
==5763==    at 0x4AEBCC2: ddraw_surface_create (surface.c:5849)
==5763==    by 0x4AC147F: ddraw1_CreateSurface (ddraw.c:2962)
==5763==    by 0x515E7C8: SrcColorKey32BlitTest (dsurface.c:251)
==5763==    by 0x516CEB4: func_dsurface (dsurface.c:3949)
==5763==    by 0x50CC30B: main (test.h:584)
==5763==  Uninitialised value was created by a stack allocation
==5763==    at 0x515E671: SrcColorKey32BlitTest (dsurface.c:217)
==5763==

==5763== Conditional jump or move depends on uninitialised value(s)
==5763==    at 0x4AEBCC2: ddraw_surface_create (surface.c:5849)
==5763==    by 0x4AC147F: ddraw1_CreateSurface (ddraw.c:2962)
==5763==    by 0x515E224: PaletteTest (dsurface.c:2225)
==5763==    by 0x516E484: func_dsurface (dsurface.c:3962)
==5763==    by 0x50CC30B: main (test.h:584)
==5763==  Uninitialised value was created by a stack allocation
==5763==    at 0x515DB07: PaletteTest (dsurface.c:2137)
==5763==

==5763== Conditional jump or move depends on uninitialised value(s)
==5763==    at 0x4AEBCC2: ddraw_surface_create (surface.c:5849)
==5763==    by 0x4AC147F: ddraw1_CreateSurface (ddraw.c:2962)
==5763==    by 0x515E003: PaletteTest (dsurface.c:2260)
==5763==    by 0x516E484: func_dsurface (dsurface.c:3962)
==5763==    by 0x50CC30B: main (test.h:584)
==5763==  Uninitialised value was created by a stack allocation
==5763==    at 0x515DB07: PaletteTest (dsurface.c:2137)
==5763==

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

--- Comment #1 from Austin English  ---
For reference, this was on:
OpenGL renderer string: GeForce GTX 460/PCIe/SSE2
OpenGL core profile version string: 4.3.0 NVIDIA 337.12

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

--- Comment #2 from Austin English  ---
Still in 1.7.43-40-gf479071, also on intel/mesa 10.5

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

--- Comment #3 from Austin English  ---
*** Bug 36355 has been marked as a duplicate of this bug. ***

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

--- Comment #4 from Henri Verbeet  ---
6c9e1a4735f5b025b3432fc9150356f97fccc63b probably made this go away.

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6c9e1a4735f5b025b3432fc9150
                   |                            |356f97fccc63b

--- Comment #5 from Austin English  ---
Thanks. The test crashes (valgrind issue), so I'll trust it was fixed.

[Bug 36383] valgrind shows several uninitialized values in ddraw_CreateSurface() in ddraw/tests/dsurface.c

https://bugs.winehq.org/show_bug.cgi?id=36383

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.7.