http://bugs.winehq.org/show_bug.cgi?id=18915
Summary: FAR Manager: crashes shortly after startup Product: Wine Version: 1.1.17 Platform: PC URL: http://farmanager.com/nightly/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shdocvw AssignedTo: wine-bugs@winehq.org ReportedBy: yurivkhan@gmail.com
Ubuntu 9.04 Jaunty Jackalope wine-1.1.17-123-g8e12ad4 and newer FAR Manager 2.0 builds 908 and newer
When started in wineconsole, FAR displays empty file panels and over them an access violation error message:
Internal error "Access violation (read from 0x00000004)" Exception address: 0x00000004 in module:
(addresses vary depending on Wine version, but are close to zero)
FAR has to be killed then.
In Wine 1.0.1 FAR starts normally.
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #1 from Yuri Khan yurivkhan@gmail.com 2009-06-12 12:31:16 --- I have run the regression test and it points at this patch:
8e12ad4faeb9274a6a038638eed261f3cfae63f6 is first bad commit commit 8e12ad4faeb9274a6a038638eed261f3cfae63f6 Author: Henri Verbeet hverbeet@codeweavers.com Date: Tue Mar 24 10:09:25 2009 +0100
shdocvw: Add a stub ITaskbarList implementation.
Based on a patch by Louis Lenders. Although MSDN claims this should be in shell32, it really is in shdocvw.
:040000 040000 e62b56f5579c2943ada67d31f64b59429a1fe4f6 a6f1d4963fa7c84bd2e8744f60cf2915ab981359 M dlls :040000 040000 73b71d886ed76916e3c994c2e2756c352b6df6c1 da408b56e12c9c1af4f834840c6a0fcf263595eb M include
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #2 from Yuri Khan yurivkhan@gmail.com 2009-06-12 12:38:50 --- I have reviewed the code in file dlls/shdocvw/taskbarlist.c and identified the crash reason. The factory function
HRESULT TaskbarList_Create(IUnknown *outer, REFIID riid, void **taskbar_list)
does not check its riid parameter and always returns a pointer to the ITaskbarList interface of the newly created object, no matter what the client asked for.
If the client asks for an unrelated interface, trouble will happen when the client tries to invoke that interface's methods (code of the ITaskbarList method with the same vtable index will be called).
If the client asks for an extension of ITaskbarList (e.g. ITaskbarList2 or ITaskbarList3) and tries to call any extended methods, it will read the vtbl beyond its end and jump to a bogus location.
The ITaskbarList3 interface, in particular, is used to provide Windows 7 taskbar integration.
The conventional way to implement a COM class factory is to QueryInterface the newly created object for the requested riid.
http://bugs.winehq.org/show_bug.cgi?id=18915
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #3 from Henri Verbeet hverbeet@gmail.com 2009-06-12 12:51:41 --- I'll send a patch.
http://bugs.winehq.org/show_bug.cgi?id=18915
Sic Volo sickvolo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sickvolo@gmail.com
--- Comment #4 from Sic Volo sickvolo@gmail.com 2009-06-12 13:15:58 --- *** Bug 18914 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #5 from Henri Verbeet hverbeet@gmail.com 2009-06-15 04:06:46 --- Created an attachment (id=21803) --> (http://bugs.winehq.org/attachment.cgi?id=21803) patch
Does this patch help?
http://bugs.winehq.org/show_bug.cgi?id=18915
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #21803|0 |1 is obsolete| |
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2009-06-15 04:10:59 --- Created an attachment (id=21804) --> (http://bugs.winehq.org/attachment.cgi?id=21804) patch
Actually, try this one instead.
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #7 from Yuri Khan yurivkhan@gmail.com 2009-06-16 01:51:54 --- (In reply to comment #6)
Created an attachment (id=21804)
--> (http://bugs.winehq.org/attachment.cgi?id=21804)
Actually, try this one instead.
Tested, works. You might want to ask the original requester of ITaskbarList implementation, too.
http://bugs.winehq.org/show_bug.cgi?id=18915
--- Comment #8 from Henri Verbeet hverbeet@gmail.com 2009-06-16 12:18:46 --- Should be fixed in current git.
http://bugs.winehq.org/show_bug.cgi?id=18915
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #9 from Dmitry Timoshkov dmitry@codeweavers.com 2009-06-16 23:22:39 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=18915
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2009-06-19 11:10:18 --- Closing bugs fixed in 1.1.24.
https://bugs.winehq.org/show_bug.cgi?id=18915
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |8e12ad4faeb9274a6a038638eed | |261f3cfae63f6 Fixed by SHA1| |697e529c195ca3cea1dd4dc64e1 | |b2897a219324a CC| |focht@gmx.net
-
wine-bugs＠winehq.org