https://bugs.winehq.org/show_bug.cgi?id=49494
Bug ID: 49494 Summary: Branching on uninitialized variables in unix_to_win_locale. Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: jeffersoncarpenter2@gmail.com Distribution: ---
Created attachment 67621 --> https://bugs.winehq.org/attachment.cgi?id=67621 Configure output.
This is a very recent problem, introduced in b6722aa752
Steps to reproduce:
* Build wine b6722aa752 (my configure output is attached) * Build 'int main() { return 0; }' using i686-w64-mingw-gcc * Run under valgrind (valgrind output attached)
Valgrind emits many warnings such as this:
==17065== Conditional jump or move depends on uninitialised value(s) ==17065== at 0x403C51E: strpbrk (vg_replace_strmem.c:1689) ==17065== by 0x4839781: unix_to_win_locale (env.c:664) ==17065== by 0x4839956: init_locale (env.c:716) ==17065== by 0x48399A2: init_environment (env.c:780) ==17065== by 0x484B4BB: __wine_main (loader.c:1825) ==17065== by 0x7C0018E4: main (main.c:285)
https://bugs.winehq.org/show_bug.cgi?id=49494
--- Comment #1 from jeffersoncarpenter2@gmail.com --- Created attachment 67622 --> https://bugs.winehq.org/attachment.cgi?id=67622 Valgrind output.
https://bugs.winehq.org/show_bug.cgi?id=49494
jeffersoncarpenter2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind
https://bugs.winehq.org/show_bug.cgi?id=49494
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC| |gijsvrm@gmail.com Keywords| |regression Regression SHA1| |b6722aa7527abc71cb46ab75e4b | |875c288408d52
--- Comment #2 from Andrey Gusev andrey.goosev@gmail.com --- Also breaks existing user profile and ability to create a new one in Sherlock Holmes and The Hound of The Baskervilles game.
https://bugs.winehq.org/show_bug.cgi?id=49494
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |gijsvrm@gmail.com
--- Comment #3 from Gijs Vermeulen gijsvrm@gmail.com --- Created attachment 67623 --> https://bugs.winehq.org/attachment.cgi?id=67623 try
Sorry about that.
Does this patch work?
https://bugs.winehq.org/show_bug.cgi?id=49494
--- Comment #4 from Andrey Gusev andrey.goosev@gmail.com --- (In reply to Gijs Vermeulen from comment #3)
Patch fixes it, yes.
https://bugs.winehq.org/show_bug.cgi?id=49494
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |21f1fa82a8c7bd1b077f0289141 | |972ed619c5a5f Resolution|--- |FIXED
--- Comment #5 from Andrey Gusev andrey.goosev@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commit/21f1fa82a8c7bd1b077f0289141972...
https://bugs.winehq.org/show_bug.cgi?id=49494
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=49494
--- Comment #6 from jeffersoncarpenter2@gmail.com --- Fixed in 21f1fa82
https://bugs.winehq.org/show_bug.cgi?id=49494
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.12.