https://bugs.winehq.org/show_bug.cgi?id=38353
Bug ID: 38353 Summary: DIRT3 crashes after showing racing results screen Product: Wine Version: 1.7.40 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: yurishish@gmail.com Distribution: ---
Created attachment 51197 --> https://bugs.winehq.org/attachment.cgi?id=51197 Backtarce
Game crashes after showing race results screen (which shows players names, ranks and race finishing times). I'm using russian version of the game. Backtrace is provided in the attachment.
https://bugs.winehq.org/show_bug.cgi?id=38353
Yuri Shishenko yurishish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yurishish@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=38353
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #1 from Sebastian Lackner sebastian@fds-team.de --- Based on the stacktrace it looks like the lpKeyState argument of ToUnicodeEx() should be optional and accept a NULL pointer. It will probably fallback to the current keystate then. Will do some testing.
https://bugs.winehq.org/show_bug.cgi?id=38353
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|DIRT3 crashes after showing |DIRT3 crashes after showing |racing results screen |racing results screen | |(ToUnicodeEx should accept | |NULL pointer as keystate)
--- Comment #2 from Sebastian Lackner sebastian@fds-team.de --- According to the information on the internet the keystate should be ignored when a NULL pointer is passed.
Could you please test the following patch? https://github.com/wine-compholio/wine-staging/blob/master/patches/winex11-T...
https://bugs.winehq.org/show_bug.cgi?id=38353
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- (In reply to Sebastian Lackner from comment #2)
According to the information on the internet the keystate should be ignored when a NULL pointer is passed.
Could you please test the following patch? https://github.com/wine-compholio/wine-staging/blob/master/patches/winex11- ToUnicodeEx/0001-winex11-Allow-NULL-pointer-as-keystate-in-X11DRV_ToU.patch
That's questionable - ToUnicode() keystate argument is indeed annotated as optional in PSDK, while ToUnicodeEx() is not. Wine always forwards to ToUnicodeEx(). So yes, only tests will tell the truth.
https://bugs.winehq.org/show_bug.cgi?id=38353
--- Comment #4 from Yuri Shishenko yurishish@gmail.com --- (In reply to Sebastian Lackner from comment #2)
According to the information on the internet the keystate should be ignored when a NULL pointer is passed.
Could you please test the following patch? https://github.com/wine-compholio/wine-staging/blob/master/patches/winex11- ToUnicodeEx/0001-winex11-Allow-NULL-pointer-as-keystate-in-X11DRV_ToU.patch
This patch fixes the problem. Results screen can be passed and game continues to work.
https://bugs.winehq.org/show_bug.cgi?id=38353
--- Comment #5 from Sebastian Lackner sebastian@fds-team.de --- A similar patch was added in http://source.winehq.org/git/wine.git/commit/1059ee3cba030988091b54254a13d58..., please retest.
https://bugs.winehq.org/show_bug.cgi?id=38353
--- Comment #6 from Yuri Shishenko yurishish@gmail.com --- (In reply to Sebastian Lackner from comment #5)
A similar patch was added in http://source.winehq.org/git/wine.git/commit/ 1059ee3cba030988091b54254a13d5899621e3c5, please retest.
No crashes. So, is this bug fixed in wine-git?
https://bugs.winehq.org/show_bug.cgi?id=38353
--- Comment #7 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Yuri Shishenko from comment #6)
(In reply to Sebastian Lackner from comment #5)
A similar patch was added in http://source.winehq.org/git/wine.git/commit/ 1059ee3cba030988091b54254a13d5899621e3c5, please retest.
No crashes. So, is this bug fixed in wine-git?
Yes, feel free to mark this bug as fixed then.
https://bugs.winehq.org/show_bug.cgi?id=38353
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1059ee3cba030988091b54254a1 | |3d5899621e3c5 Status|UNCONFIRMED |RESOLVED Component|-unknown |user32 Resolution|--- |FIXED
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com --- Fixed with 1059ee3cba030988091b54254a13d5899621e3c5.
https://bugs.winehq.org/show_bug.cgi?id=38353
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.41.
-
wine-bugs＠winehq.org