http://bugs.winehq.org/show_bug.cgi?id=15070
Summary: HxD cant find Internetupdate Product: Wine Version: 1.1.3 Platform: PC-x86-64 URL: http://mh-nexus.de/de/hxd OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wininet AssignedTo: wine-bugs@winehq.org ReportedBy: nerv@dawncrow.de
Created an attachment (id=15741) --> (http://bugs.winehq.org/attachment.cgi?id=15741) wininet trace
The Function HttpQueryInfoW returns False in Wine with lpdwIndex=1 in XP it returns True with lpdwIndex=0. Sample Delphi Code: HttpQueryInfo(hRequest, HTTP_QUERY_STATUS_CODE, @Result[1], len, dummy) [len and dummy are 0] The attachment contains a Trace with WINEDEBUG=wininet and improved TRACE-Functions by me: TRACE("(%p, 0x%08x)--> %d with lpdwIndex=%d (Adress) and value=%d\n", hHttpRequest, dwInfoLevel, dwInfoLevel, lpdwIndex, *lpdwIndex);
http://bugs.winehq.org/show_bug.cgi?id=15070
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net
--- Comment #1 from Hans Leidekker hans@meelstraat.net 2008-08-30 07:57:36 --- Can you translate that code into a Wine conformance test and add it to dlls/wininet/tests/http.c?
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #2 from André H. nerv@dawncrow.de 2008-08-30 08:12:56 --- i'll try my best!
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #3 from André H. nerv@dawncrow.de 2008-08-30 10:31:42 --- The Dev of HxD thinks the Function should contain something like:
if (bSuccess && lpdwIndex && "lpdwIndex + 1 is a valid index") (*lpdwIndex)++; . . . return bSuccess;
But i had great success with this:
if (bSuccess && lpdwIndex) (*lpdwIndex)++; . . . return bSuccess;
in HTTP_HttpQueryInfoW (internal)
Would someone please generate a patch, i am too stupid for that.
http://bugs.winehq.org/show_bug.cgi?id=15070
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #4 from André H. nerv@dawncrow.de 2008-09-03 12:38:22 --- Created an attachment (id=15809) --> (http://bugs.winehq.org/attachment.cgi?id=15809) This fixes the Problem and should not affect other Apps
Should i send it to wine-patches@winehq.org?
http://bugs.winehq.org/show_bug.cgi?id=15070
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Difficulty|--- |Hours Resolution| |FIXED
--- Comment #5 from André H. nerv@dawncrow.de 2008-09-03 12:40:20 --- Resolving bug, changing resolution to Fixed
http://bugs.winehq.org/show_bug.cgi?id=15070
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |WORKSFORME
--- Comment #6 from André H. nerv@dawncrow.de 2008-09-03 12:51:24 --- Oh, Sorry i think WORKSFORME is better for now
http://bugs.winehq.org/show_bug.cgi?id=15070
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Difficulty|Hours |--- Resolution|WORKSFORME |
--- Comment #7 from Vitaliy Margolen vitaliy@kievinfo.com 2008-09-03 13:04:19 --- (In reply to comment #6)
Oh, Sorry i think WORKSFORME is better for now
Neither. Until the patch in Wine source code, this bug is still open.
Yes please send patches to wine-patches with better subject and explanation of why it's necessary.
http://bugs.winehq.org/show_bug.cgi?id=15070
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |patch
--- Comment #8 from Vitaliy Margolen vitaliy@kievinfo.com 2008-09-03 13:04:57 --- Confirming since patch is present that fixes the problem.
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #9 from Austin English austinenglish@gmail.com 2008-09-03 13:06:23 --- Please put your real name/e-mail in the patch when sending.
A testcase would also be useful.
http://bugs.winehq.org/show_bug.cgi?id=15070
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #10 from Austin English austinenglish@gmail.com 2008-09-07 05:22:10 --- *** Bug 14035 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #11 from Rotem Zach rotemz@gmail.com 2008-09-08 13:33:16 --- Created an attachment (id=15932) --> (http://bugs.winehq.org/attachment.cgi?id=15932) Fixes HttpQueryInfo
Andre, your patch never increments the index because at that point the bSuccess is always false.
I did some testing and saw that windows XP only increments the index when the HTTP_QUERY_FLAG_REQUEST_HEADERS flag is set.
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #12 from André H. nerv@dawncrow.de 2008-09-09 13:19:38 --- I think in your test you should check if your index increments, because thats the point. But thanks for your work.
http://bugs.winehq.org/show_bug.cgi?id=15070
Rotem Zach rotemz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rotemz@gmail.com
--- Comment #13 from Rotem Zach rotemz@gmail.com 2008-09-10 04:59:30 --- If it increments the first time the second time fails. That's the check. Test it withand without the patch. Maybe it would have been smarter to check directly.
http://bugs.winehq.org/show_bug.cgi?id=15070
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.1.3 |1.1.4
--- Comment #14 from André H. nerv@dawncrow.de 2008-09-10 11:29:51 --- Ok, hope the patch was sent to wine-patches@winehq.org too and will be released next time. So we improved the http.c a bit. Good work guys and thanks to Rotem Zach!
http://bugs.winehq.org/show_bug.cgi?id=15070
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.1.4 |1.1.3
--- Comment #15 from Dan Kegel dank@kegel.com 2008-09-10 13:34:23 --- Please don't change the originally reported version number. It's supposed to reflect the earliest known version with the problem, more or less.
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #16 from André H. nerv@dawncrow.de 2008-11-17 10:10:59 --- This Bug is fixed at Application-Site in HxD Version 1.7.6.6! It is still not fixed in Wine(1.1.8), but why? The Test-Result were positiv...
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #17 from Hans Leidekker hans@meelstraat.net 2008-12-01 08:49:31 --- Should be fixed by this patch: http://www.winehq.org/pipermail/wine-patches/2008-December/065350.html
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #18 from Hans Leidekker hans@meelstraat.net 2008-12-03 02:58:20 --- Patch was commited. Reporter, can you retest with an old version of HxD?
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #19 from André H. nerv@dawncrow.de 2008-12-03 13:15:43 --- Hi, I am not able to compile my git version of wine at present. would you please test hxd 1.7.6.4 yourself. that would be nice.
Thank you!
Best regards André H.
http://bugs.winehq.org/show_bug.cgi?id=15070
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #20 from Austin English austinenglish@gmail.com 2008-12-03 15:59:33 --- Works fine for me.
http://bugs.winehq.org/show_bug.cgi?id=15070
--- Comment #21 from André H. nerv@dawncrow.de 2008-12-04 12:13:48 --- Nice! Thats all i ever wanted since i reported this bug three month ago.
http://bugs.winehq.org/show_bug.cgi?id=15070
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #22 from Alexandre Julliard julliard@winehq.org 2008-12-05 11:15:39 --- Closing bugs fixed in 1.1.10.
https://bugs.winehq.org/show_bug.cgi?id=15070
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://mh-nexus.de/de/hxd |https://web.archive.org/web | |/20081111192359/http://mh-n | |exus.de/downloads/HxDen.zip Summary|HxD cant find |Multiple applications fail |Internetupdate |due to | |wininet.HttpQueryInfo(..., | |HTTP_QUERY_STATUS_CODE, | |..., &index) incrementing | |index (HxD 1.7.x, Microsoft | |Virtual Earth 3D beta) Keywords| |download CC| |focht@gmx.net Fixed by SHA1| |d1076aeab488c5ce1716a2d3d01 | |47da2d1159dcc