[Bug 13000] New: Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Summary: Audiosurf crashes on startup
           Product: Wine
           Version: 0.9.61.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=12758)
 --> (http://bugs.winehq.org/attachment.cgi?id=12758)
Audiosurf run log / error output

Audiosurf crashes during loading, while displaying the current news.

This only occurs after the 2008-05-05 update.

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Gary Pendergast  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12758|application/octet-stream    |text/plain
          mime type|                            |

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

--- Comment #1 from Gary Pendergast   2008-05-06 19:44:13 ---
Several reports of Audiosurf working when downgrading to 0.9.58, courtesy of:
http://www.audio-surf.com/forum/index.php/topic,40.msg29392.html#msg29392

Will run through regression testing, see which patch broke it.

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Gary Pendergast  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-d3d                 |quartz

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Gary Pendergast  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Gary Pendergast   2008-05-07 01:36:57 ---
Results from git bisect:

#
79349513435aa677e584bcad66865cafbac95db9 is first bad commit
commit 79349513435aa677e584bcad66865cafbac95db9
Author: Maarten Lankhorst 
Date:   Fri Apr 25 14:25:49 2008 -0700

quartz: Make the EnumPins interface dynamic.

Take a reference to the ibasefilter and request it for the pins and a
    cookie. This seems to be the easiest way to ensure correctness.

:040000 040000 0497ddf137ccbd672f725e7deec8195e0c57051f
717e65c13f2412e12dbde2d4336537a2f1a711c7 M      dlls
#

Maarten, as the above patch was written by you, I've copied you into this bug.
Is there any more information I can provide that would help track down this
problem?

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

--- Comment #3 from Maarten Lankhorst   2008-05-07 02:07:25 ---
Can you attach audiosurf run with WINEDEBUG=+quartz,+tid ?

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Olivier Samyn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Olivier Samyn   2008-05-07 03:21:26 ---
Isn't this related to the problem I found I bug #12979 ?

In from dlls/quartz/filesource.c, function AsyncReader_GetPin, sometimes,
This->pOutputPin is null => crash when you try to add a reference on it.

Just adding a test and returning S_FALSE if null resolved my problem.

diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c
index f410b56..a4e708f 100644
--- a/dlls/quartz/filesource.c
+++ b/dlls/quartz/filesource.c
@@ -533,6 +533,10 @@ static HRESULT AsyncReader_GetPin(IBaseFilter *iface,
ULONG
         return S_FALSE;

*pin = (IPin *)This->pOutputPin;
+    
+    if(!(*pin))
+        return S_FALSE;
+    
     IPin_AddRef(*pin);
     return S_OK;
 }

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

--- Comment #5 from Gary Pendergast   2008-05-07 03:23:10 ---
Created an attachment (id=12792)
 --> (http://bugs.winehq.org/attachment.cgi?id=12792)
Error output with WINEDEBUG=+quartz,+tid

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Andrej Kilian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Andrej Kilian   2008-05-07 18:28:39 ---
*** This bug has been confirmed by popular vote. ***

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #7 from Maarten Lankhorst   2008-05-09 17:19:54 ---
Duplicate

*** This bug has been marked as a duplicate of bug 12979 ***

[Bug 13000] Audiosurf crashes on startup

http://bugs.winehq.org/show_bug.cgi?id=13000

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Austin English   2008-10-31 13:59:14 ---
Closing duplicate.