http://bugs.winehq.org/show_bug.cgi?id=18900
Summary: Wineserver crashes starting Team Fortress 2 Product: Wine Version: 1.1.23 Platform: PC-x86-64 OS/Version: Linux Status: NEW Severity: critical Priority: P2 Component: wineserver AssignedTo: wine-bugs@winehq.org ReportedBy: vitaliy@kievinfo.com
Created an attachment (id=21742) --> (http://bugs.winehq.org/attachment.cgi?id=21742) Backtrace and additional info
With current git & Steam updates wineserver crashes when starting Team Fortress 2:
Program terminated with signal 11, Segmentation fault. #0 0x08072893 in wake_thread (thread=0xf8) at ../../wine.git/server/thread.c:604 604 for (count = 0; thread->wait; count++)
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #1 from Jonathan Cruickshanks wine-bugzilla@cruicky.co.uk 2009-06-12 06:07:43 --- Created an attachment (id=21751) --> (http://bugs.winehq.org/attachment.cgi?id=21751) Debugging with Valgrind and gdb
From this debugging info, I believe that the 'next' local variable becomes
invalid due to a free caused by waking up the thread in the list entry referenced by 'ptr', as 0xa8aed7c is no longer in obj->wait_queue. Infact, it would appear that obj->wait_queue is empty at the point where gdb is started.
This debugging info was generated by the 1.1.23 Ubuntu 9.04 package built from source with no optimisation.
http://bugs.winehq.org/show_bug.cgi?id=18900
Jonathan Cruickshanks wine-bugzilla@cruicky.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #21751|application/octet-stream |text/plain mime type| |
http://bugs.winehq.org/show_bug.cgi?id=18900
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nukedclx@gmail.com
--- Comment #2 from Jeff Zaroyko jeffz@jeffz.name 2009-06-12 08:00:09 --- *** Bug 18907 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #3 from Austin English austinenglish@gmail.com 2009-06-12 11:17:34 --- How is this critical?
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #4 from nukedclx nukedclx@gmail.com 2009-06-12 11:23:26 --- because steam is actually big game platform, many games using it, everyone playing or played cs/hl
http://bugs.winehq.org/show_bug.cgi?id=18900
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal
--- Comment #5 from Austin English austinenglish@gmail.com 2009-06-12 11:39:12 --- (In reply to comment #4)
because steam is actually big game platform, many games using it, everyone playing or played cs/hl
I'm aware of what Steam is. That doesn't make this bug critical: 'Critical problem that prevents all applications from working'.
http://bugs.winehq.org/show_bug.cgi?id=18900
Michael Abbott michael@araneidae.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@araneidae.co.uk
--- Comment #6 from Michael Abbott michael@araneidae.co.uk 2009-06-12 12:18:30 --- Oh, blast. My bug 18913 is a duplicate of this.
I've pinned this down to this commit:
commit 7560a890225a8ab56c326206224fe9bedc69aefa Author: Alexandre Julliard julliard@winehq.org Date: Tue Dec 30 15:15:06 2008 +0100
server: Make padding explicit in the wake_up_reply structure.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #7 from Michael Abbott michael@araneidae.co.uk 2009-06-12 12:19:44 --- *** Bug 18913 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=18900
Michael Abbott michael@araneidae.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org
--- Comment #8 from Michael Abbott michael@araneidae.co.uk 2009-06-12 12:24:15 --- Adding Alexandre Julliard to CC list, per regression instructions.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2009-06-12 12:52:48 --- Please attach a +server trace of the crash.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #10 from Michael Abbott michael@araneidae.co.uk 2009-06-12 13:16:08 --- (In reply to comment #9)
Please attach a +server trace of the crash.
Damn, I'm stuck. I've generated a trace, but it's over 90M before compression, and bzip2 brings it down to 1.7M -- which is still too large for this bug database. I don't have any web space to upload it to.
If someone can tell me how to launch TF2 without steam, that might save quite a bit of the trace.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #11 from Michael Abbott michael@araneidae.co.uk 2009-06-12 13:21:50 --- (In reply to comment #9)
Please attach a +server trace of the crash.
Ok, I've been pointed to FileBin: http://filebin.ca/aafnum/wine.log.bz2
http://bugs.winehq.org/show_bug.cgi?id=18900
Onur Aslan onuraslan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |onuraslan@gmail.com
--- Comment #12 from Onur Aslan onuraslan@gmail.com 2009-06-12 14:48:45 --- I was using wine 1.1.15. After the latest steam update (to 54 / 872), wine crashing when starting a game in Steam. Counter Strike and Team Fortress 2 doesn't start. I tried with wine 1.1.22, it's same.
Also, some game starting normally, like Counter Strike Source, Portal.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2009-06-12 14:56:49 --- Created an attachment (id=21763) --> (http://bugs.winehq.org/attachment.cgi?id=21763) Avoid dups in object wait list
Give this a try.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #14 from nukedclx nukedclx@gmail.com 2009-06-12 15:55:47 --- for me that patch is working, many thanks.
http://bugs.winehq.org/show_bug.cgi?id=18900
Arnaud Soyez weboide+wine@codealpha.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |weboide+wine@codealpha.net
--- Comment #15 from Arnaud Soyez weboide+wine@codealpha.net 2009-06-12 16:09:22 --- Allexandre's patch works for me too. (with latest git version)
http://bugs.winehq.org/show_bug.cgi?id=18900
Matt Smith mreedsmith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mreedsmith@gmail.com
--- Comment #16 from Matt Smith mreedsmith@gmail.com 2009-06-12 17:25:00 --- patch works for me as well, both Team Fortress 2 and Left 4 Dead, on 1.1.23
http://bugs.winehq.org/show_bug.cgi?id=18900
Kernel Lenrek frenchford@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |frenchford@gmail.com
--- Comment #17 from Kernel Lenrek frenchford@gmail.com 2009-06-12 19:16:47 --- (In reply to comment #13)
Created an attachment (id=21763)
--> (http://bugs.winehq.org/attachment.cgi?id=21763) [details]
Avoid dups in object wait list
Give this a try.
patch works here as well (with natural selection at least)
http://bugs.winehq.org/show_bug.cgi?id=18900
Jonathan Cruickshanks wine-bugzilla@cruicky.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine-bugzilla@cruicky.co.uk
--- Comment #18 from Jonathan Cruickshanks wine-bugzilla@cruicky.co.uk 2009-06-12 19:17:48 --- Patch works for me too, thanks.
http://bugs.winehq.org/show_bug.cgi?id=18900
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical
--- Comment #19 from Vitaliy Margolen vitaliy@kievinfo.com 2009-06-12 20:07:08 --- wineserver crash == critical. I'd be suprized if TF2 and L4D are the only two applications affected by this.
Patch from comment #13 works here as well. Thanks Alenxadre.
http://bugs.winehq.org/show_bug.cgi?id=18900
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal
--- Comment #20 from Dmitry Timoshkov dmitry@codeweavers.com 2009-06-13 07:00:54 --- Lowering the priority since there is a working patch now.
http://bugs.winehq.org/show_bug.cgi?id=18900
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical
--- Comment #21 from Vitaliy Margolen vitaliy@kievinfo.com 2009-06-13 11:43:38 --- So what that you have a patch? Is it committed? No. Does it change the fact that wineserver crash _does_ affect _all_ applications? No. So why do we even have "critical" severity?
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #22 from Ken Sharp kennybobs@o2.co.uk 2009-06-13 12:01:08 --- Not really helpful but there have been reports of Wineserver crashing on the AppDB, usually with people with ATI cards.
Sorry, I didn't keep the specific comments as I get hundreds of emails daily from the AppDB.
In short: It does seem to affect more than just those two apps.
http://bugs.winehq.org/show_bug.cgi?id=18900
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #23 from Austin English austinenglish@gmail.com 2009-06-13 14:14:24 --- (In reply to comment #22)
In short: It does seem to affect more than just those two apps.
AFAICT, it only affects Steam users, which is not _ALL_ applications.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #24 from Ken Sharp kennybobs@o2.co.uk 2009-06-13 14:17:06 --- (In reply to comment #23)
(In reply to comment #22)
In short: It does seem to affect more than just those two apps.
AFAICT, it only affects Steam users, which is not _ALL_ applications.
I didn't say it did.
http://bugs.winehq.org/show_bug.cgi?id=18900
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #25 from Jerome Leclanche adys.wh@gmail.com 2009-06-13 14:37:19 --- (In reply to comment #24)
(In reply to comment #23)
(In reply to comment #22)
In short: It does seem to affect more than just those two apps.
AFAICT, it only affects Steam users, which is not _ALL_ applications.
I didn't say it did.
Does it even matter? There's a patch, hopefully it'll be committed asap, there is really, really no need to fight over the priority (even though I agree anything affecting wineserver has the potential of affecting all applications).
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #26 from Alexandre Julliard julliard@winehq.org 2009-06-13 16:47:15 --- Any wineserver crash is a serious bug. Marking them critical is totally appropriate.
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #27 from Michael Abbott michael@araneidae.co.uk 2009-06-14 13:18:00 --- I'm fascinated to know: what was the linkage between the commit my bisect turned up and the underlying bug that's fixed by the patch? The commit seems to just explicitly add some alignment fields in a structure; I'm baffled as to how this could lead to duplicates in the object wait list!
http://bugs.winehq.org/show_bug.cgi?id=18900
--- Comment #28 from Alexandre Julliard julliard@winehq.org 2009-06-15 03:21:49 --- (In reply to comment #27)
I'm fascinated to know: what was the linkage between the commit my bisect turned up and the underlying bug that's fixed by the patch? The commit seems to just explicitly add some alignment fields in a structure; I'm baffled as to how this could lead to duplicates in the object wait list!
It doesn't, the duplicates have always been there. Since we are accessing invalid data, the crash may behave differently because of changes in the memory layout, but the bug was already present before that commit.
http://bugs.winehq.org/show_bug.cgi?id=18900
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #29 from Alexandre Julliard julliard@winehq.org 2009-06-15 09:34:52 --- Should be fixed by fd78e6e3a51091a8cbe049237a55347390d9570b.
http://bugs.winehq.org/show_bug.cgi?id=18900
Casey Jones jonescaseyb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonescaseyb@gmail.com
--- Comment #30 from Casey Jones jonescaseyb@gmail.com 2009-06-15 12:40:56 --- (In reply to comment #19)
wineserver crash == critical. I'd be suprized if TF2 and L4D are the only two applications affected by this.
Patch from comment #13 works here as well. Thanks Alenxadre.
It also affected Red Orchestra.
http://bugs.winehq.org/show_bug.cgi?id=18900
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #31 from Alexandre Julliard julliard@winehq.org 2009-06-19 11:09:54 --- Closing bugs fixed in 1.1.24.
http://bugs.winehq.org/show_bug.cgi?id=18900
Saulius K. saulius2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=18900
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jason.bogstie@gmail.com
--- Comment #32 from Vitaliy Margolen vitaliy@kievinfo.com 2009-07-05 13:22:24 --- *** Bug 19192 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=18900
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |fd78e6e3a51091a8cbe049237a5 | |5347390d9570b CC| |focht@gmx.net
-
wine-bugs＠winehq.org