[Bug 49555] New: Wine-Staging compilation fails after 046f6604b763ca494bece1ff16a0919077ecb9d4 (../ntdll/unix/file.c)
https://bugs.winehq.org/show_bug.cgi?id=49555
Bug ID: 49555 Summary: Wine-Staging compilation fails after 046f6604b763ca494bece1ff16a0919077ecb9d4 (../ntdll/unix/file.c) Product: Wine-staging Version: unspecified Hardware: x86 OS: Linux Status: NEW Keywords: download, regression, source Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: gyebro69@gmail.com CC: leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
Since yesterday's rebase compiling Wine-Staging fails somewhere in ../ntdll/unix/file.c. https://github.com/wine-staging/wine-staging/commit/046f6604b763ca494bece1ff...
gcc -m64 -c -o unix/file.o ../../../dlls/ntdll/unix/file.c -I. -I../../../dlls/ntdll -I../../include \ -I../../../include -D__WINESRC__ -D_NTSYSTEM_ -D_ACRTIMP= -D_MSVCR_VER=0 -D_REENTRANT -fPIC \ -fasynchronous-unwind-tables -Wall -pipe -fcf-protection=none -fno-stack-protector \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \ -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -pipe -O2 -ftree-vectorize ../../../dlls/ntdll/unix/file.c:3566:16: error: conflicting types for ‘nt_to_unix_file_name’ 3566 | NTSTATUS CDECL nt_to_unix_file_name( const UNICODE_STRING *nameW, char **unix_name_ret, | ^~~~~~~~~~~~~~~~~~~~ In file included from ../../../dlls/ntdll/unix/file.c:128: ../../../dlls/ntdll/unix/unix_private.h:243:17: note: previous declaration of ‘nt_to_unix_file_name’ was here 243 | extern NTSTATUS nt_to_unix_file_name( const UNICODE_STRING *nameW, char **name_ret, UINT disposition ) DECLSPEC_HIDDEN; | ^~~~~~~~~~~~~~~~~~~~ ../../../dlls/ntdll/unix/file.c: In function ‘NtCreateFile’: ../../../dlls/ntdll/unix/file.c:3790:31: warning: unused variable ‘objattr’ [-Wunused-variable] 3790 | struct object_attributes *objattr; | ^~~~~~~ ../../../dlls/ntdll/unix/file.c:3789:17: warning: unused variable ‘len’ [-Wunused-variable] 3789 | data_size_t len; | ^~~ ../../../dlls/ntdll/unix/file.c:3788:23: warning: unused variable ‘unix_attr’ [-Wunused-variable] 3788 | OBJECT_ATTRIBUTES unix_attr; | ^~~~~~~~~ ../../../dlls/ntdll/unix/file.c:3787:27: warning: unused variable ‘empty_string’ [-Wunused-variable] 3787 | static UNICODE_STRING empty_string; | ^~~~~~~~~~~~ At top level: ../../../dlls/ntdll/unix/file.c:3787:27: warning: ‘empty_string’ defined but not used [-Wunused-variable] make[1]: *** [Makefile:1287: unix/file.o] Error 1 make[1]: Leaving directory '/home/gyebro/sources/test/wine-staging/wine64-build/dlls/ntdll' make: *** [Makefile:8823: dlls/ntdll] Error 2
https://bugs.winehq.org/show_bug.cgi?id=49555
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |bb79717d86506d4267b5a453d20 | |6e742782fd2f5 Version|unspecified |5.12 Status|NEW |RESOLVED
--- Comment #1 from Zebediah Figura z.figura12@gmail.com --- Thanks, fixed by https://github.com/wine-staging/wine-staging/commit/bb79717d86506d4267b5a453d206e742782fd2f5.
https://bugs.winehq.org/show_bug.cgi?id=49555
--- Comment #2 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Zebediah Figura from comment #1)
Thanks, fixed by https://github.com/wine-staging/wine-staging/commit/ bb79717d86506d4267b5a453d206e742782fd2f5.
At least the source compiles now :)
However, a WOW64 build is broken, simply issuing 'winecfg' to create/update a WOW64 wineprefix results in multiple unhandled page faults and other nasty issues. 32bit-only builds seem to work (at least the prefix creation part).
Sorry, no new bug report this time because I have other things to do for the rest of the day, I hope you can sort it out.
Cheers, Béla
Tested with wine-5.12-166-gcaa41d4917 (Staging)
https://bugs.winehq.org/show_bug.cgi?id=49555
--- Comment #3 from Zebediah Figura z.figura12@gmail.com --- I couldn't reproduce quite the same symptoms, but I eventually managed to track down memory corruption, which should hopefully be fixed by https://github.com/wine-staging/wine-staging/commit/4d315a60980e1a1f171ba4bcb2076554e6b8229e. Please let me know if you're still seeing problems after that commit.
https://bugs.winehq.org/show_bug.cgi?id=49555
--- Comment #4 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Zebediah Figura from comment #3)
I couldn't reproduce quite the same symptoms, but I eventually managed to track down memory corruption, which should hopefully be fixed by https://github.com/wine-staging/wine-staging/commit/ 4d315a60980e1a1f171ba4bcb2076554e6b8229e. Please let me know if you're still seeing problems after that commit.
The problem is indeed fixed with that commit, thank you.
https://bugs.winehq.org/show_bug.cgi?id=49555
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be
--- Comment #5 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- (In reply to Béla Gyebrószki from comment #2)
However, a WOW64 build is broken, simply issuing 'winecfg' to create/update a WOW64 wineprefix results in multiple unhandled page faults and other nasty issues. 32bit-only builds seem to work (at least the prefix creation part).
Sorry, no new bug report this time because I have other things to do for the rest of the day, I hope you can sort it out.
Hello,
I have a similar issue running 'wineboot -u' to update wineprefixes from 5.10 to 5.11 or 5.12 (both vanilla wine and staging).
The commit 6f9d20806e821ab07c8adf81ae6630fae94b00ef was identified as the cause. Reverting it (and dependent commit 145cfce1135a7e59cc4c89cd05b572403f188161), fixes the update issue in both 5.11 and 5.12 for me.
I hope that this information will help you avoid a full regression test.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=49555
--- Comment #6 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Olivier F. R. Dierick from comment #5)
(In reply to Béla Gyebrószki from comment #2)
However, a WOW64 build is broken, simply issuing 'winecfg' to create/update a WOW64 wineprefix results in multiple unhandled page faults and other nasty issues. 32bit-only builds seem to work (at least the prefix creation part).
Sorry, no new bug report this time because I have other things to do for the rest of the day, I hope you can sort it out.
Hello,
I have a similar issue running 'wineboot -u' to update wineprefixes from 5.10 to 5.11 or 5.12 (both vanilla wine and staging).
The commit 6f9d20806e821ab07c8adf81ae6630fae94b00ef was identified as the cause. Reverting it (and dependent commit 145cfce1135a7e59cc4c89cd05b572403f188161), fixes the update issue in both 5.11 and 5.12 for me.
I hope that this information will help you avoid a full regression test.
Regards.
Hello Olivier,
thanks for the heads up, I'll note that commit. I'm also seeing strange errors in the terminal when updating an existing prefix, but didn't take time to track it down. They appeared recently, in 5.11 I think.
00a8:err:x11settings:X11DRV_Settings_AddOneMode Maximum modes (116) exceeded
appears multiple times in the terminal when running 'wineboot -u', but it doesn't seem to affect anything negatively.
However, this bug report was against a recent regression which occurred only in Staging and it's already fixed in current staging/master.
Regards, Béla
https://bugs.winehq.org/show_bug.cgi?id=49555
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing bugs fixed in Staging 5.15.
-
WineHQ Bugzilla