[Bug 54923] New: Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54923

Bug ID: 54923
           Summary: Drag and drop is not working in Delphi based
                    applications
           Product: Wine
           Version: 8.1
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The drag and drop does not work inside applications that are based on Delphi by
default anymore.

For example, when using HeidiSQL, I'm not able to move entries in the
connection session manager into a folder to organize my connections.

WORKAROUND:
It is working, if i select "Windows XP" in winecfg, but not working for example
for "Windows 10". So it seems that the drag and drop feature got lost at later
"windows versions". On a real Windows 10 machine it works without any problems.

Might be related with "gdiplus_winxp" -> see other Delphi applications with the
same problem:
https://github.com/TES5Edit/TES5Edit/issues/774

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54923

Bartosz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bartosz  ---
Please install gdiplus via winetricks, and check if it helps.

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54923

Neko-san  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54923

--- Comment #2 from magynhard  ---
(In reply to Bartosz from comment #1)
> Please install gdiplus via winetricks, and check if it helps.

I installed gdiplus and gdiplus_winxp with winetricks, but the problem still
persists.

On new wine version 9.16-1, even choosing "Windows XP" does not workaround the
problem anymore. From 8.1 it stopped working first time, but the workaround was
possible.

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

Lorenzo Ferrillo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Lorenzo Ferrillo  ---
I think xEdit Ddrag and drop issue is due to:
015c:fixme:shell:DragSourceHelper2_SetFlags (02EEAFE0)->(00000001): stub
015c:fixme:shell:DragSourceHelper2_InitializeFromBitmap (02EEAFE0)->(0208F998,
0531B300): stub
015c:fixme:shell:SHDoDragDrop (0002012C 0531B300 00000000 0x00000001
0208FA54):stub.

I suspect it's possible DragSourceHelper2_InitializeFromBitmap have to
initialize some data of IDataObject*

and yes winxp mode is a workaround

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

--- Comment #4 from Lorenzo Ferrillo  ---
Created attachment 78554
  --> http://bugs.winehq.org/attachment.cgi?id=78554
Create dummy IDropSource when not provided to ShDoDragDrop

According to documentation SHDoDragDrop create a IDropDataSource when not
provided, and the ole32 DoDragDrop require it to be not null to work. 
This allow xEdit drag and drop to work (even if without the cell draws during
dragging)

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

--- Comment #5 from Lorenzo Ferrillo  ---
Created attachment 78556
  --> http://bugs.winehq.org/attachment.cgi?id=78556
Create IDropSource when not provided to SHDoDragDrop, try to implement bitmap
cursor

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

Lorenzo Ferrillo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78556|0                           |1
        is obsolete|                            |

--- Comment #6 from Lorenzo Ferrillo  ---
Created attachment 78557
  --> http://bugs.winehq.org/attachment.cgi?id=78557
Create IDropSource when not provided to SHDoDragDrop, try to implement bitmap
cursor

now properly destroy bitmaps and cursor when the drop is released

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

--- Comment #7 from Lorenzo Ferrillo  ---
I can confirm that with the last patch drag and dropping connection into
folders works

[Bug 54923] Drag and drop is not working in Delphi based applications

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=54923

--- Comment #8 from Lorenzo Ferrillo  ---
sorry, misclicked

I checked HeidiSQL too and moving connection to folder works too