http://bugs.winehq.org/show_bug.cgi?id=27775
Summary: Picasa 3.8 crashes due to IWiaDevMgr->EnumDeviceInfo stub Product: Wine Version: 1.3.24 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: focht@gmx.net
Hello,
Picasa 3.8 crashes if you click "import from" menu item (or "import" tool button).
IWiaDevMgr->EnumDeviceInfo (wiadevmgr_EnumDeviceInfo) is a stub, returning E_NOTIMPL. Picasa doesn't check HRESULT and tries to directly dereference IEnumWIA_DEV_INFO **ppIEnum out parameter, leading to crash.
WINEDEBUG=+tid,+seh,+loaddll,+sti,+wia wine ./Picasa3.exe
--- snip --- ... 0043:trace:wia:WIASERVC_IClassFactory_CreateInstance IID: {5eb2502a-8cf1-11d1-bf92-0060081ed811} 0043:trace:wia:wiadevmgr_Constructor ((nil),0x93e350) 0043:trace:wia:wiadevmgr_QueryInterface (0x12bba0, {5eb2502a-8cf1-11d1-bf92-0060081ed811}, 0x93e564) 0043:trace:wia:wiadevmgr_QueryInterface (0x12bba0, {00000003-0000-0000-c000-000000000046}, 0x93e26c) 0043:fixme:wia:wiadevmgr_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0043:trace:wia:wiadevmgr_QueryInterface (0x12bba0, {00000003-0000-0000-c000-000000000046}, 0x93e198) 0043:fixme:wia:wiadevmgr_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0043:trace:wia:wiadevmgr_QueryInterface (0x12bba0, {5eb2502a-8cf1-11d1-bf92-0060081ed811}, 0x93e050) 0043:trace:loaddll:load_builtin_dll Loaded L"C:\windows\system32\oleaut32.dll" at 0x207a0000: builtin 0043:trace:loaddll:load_builtin_dll Loaded L"C:\windows\system32\sti.dll" at 0x20770000: builtin 0043:trace:sti:DllMain (0x0x20770000, 1, (nil)) 0043:trace:sti:DllGetClassObject {4db1ad10-3391-11d2-9a33-00c04fa36145} {d5f569d0-593b-101a-b569-08002b2dbf7a} 0x93e04c 0043:trace:wia:wiadevmgr_QueryInterface (0x12bba0, {5eb2502a-8cf1-11d1-bf92-0060081ed811}, 0x93df90) 0009:trace:loaddll:load_builtin_dll Loaded L"C:\windows\system32\sti.dll" at 0x20070000: builtin 0009:trace:sti:DllMain (0x0x20070000, 1, (nil)) 0009:trace:sti:DllGetClassObject {4db1ad10-3391-11d2-9a33-00c04fa36145} {d5f569d0-593b-101a-b569-08002b2dbf7a} 0x329bd4 0046:fixme:wia:wiadevmgr_EnumDeviceInfo (0x12bba0, 16, 0xb3e564): stub 0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0x691934 ip=00691934 tid=0009 0009:trace:seh:raise_exception info[0]=00000000 0009:trace:seh:raise_exception info[1]=00000000 0009:trace:seh:raise_exception eax=00000000 ebx=028ec5b0 ecx=00110000 edx=00000002 esi=80004001 edi=028ec5a4 0009:trace:seh:raise_exception ebp=028ec5a0 esp=0032a258 cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00210246 0009:trace:seh:call_vectored_handlers calling handler at 0x6948a2bf code=c0000005 flags=0 0009:trace:seh:call_vectored_handlers handler at 0x6948a2bf returned 0 0009:trace:seh:call_stack_handlers calling handler at 0xa47050 code=c0000005 flags=0 --- snip ---
Regards
http://bugs.winehq.org/show_bug.cgi?id=27775
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://dl.google.com/picasa | |/picasa38-setup.exe
--- Comment #1 from Anastasius Focht focht@gmx.net 2011-07-12 14:51:14 CDT --- Hello,
filling some fields...
$ sha1sum picasa38-setup.exe 18e627bfb2869aff4aa185a23ae82b8327bf998b picasa38-setup.exe
$ wine --version wine-1.3.24-42-g4ebbd0e
Regards
http://bugs.winehq.org/show_bug.cgi?id=27775
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=27775
blizz blizzi@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blizzi@wp.pl
--- Comment #2 from blizz blizzi@wp.pl 2011-08-14 08:08:23 CDT --- I have exactly same problem.
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #3 from blizz blizzi@wp.pl 2011-08-14 08:18:51 CDT --- This bug still exists in wine-1.3.26. After installation of native wininet, got different effect. Picassa have freeze in the same place.
I'll do some debug later.
Best Regards,
http://bugs.winehq.org/show_bug.cgi?id=27775
Jonathan Ernst jonathan@ernstfamily.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan@ernstfamily.ch
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #4 from Anastasius Focht focht@gmx.net 2013-05-01 08:28:38 CDT --- Hello folks,
still present.
Source: http://source.winehq.org/git/wine.git/blob/c4e71c2e09b51a46d1b93e3bc8f4e2827...
--- snip --- 72 static HRESULT WINAPI wiadevmgr_EnumDeviceInfo(IWiaDevMgr *iface, LONG lFlag, IEnumWIA_DEV_INFO **ppIEnum) 73 { 74 wiadevmgr *This = impl_from_IWiaDevMgr(iface); 75 FIXME("(%p, %d, %p): stub\n", This, lFlag, ppIEnum); 76 return E_NOTIMPL; 77 } --- snip ---
$ du -sh picasa38-setup.exe 14M picasa38-setup.exe
$ sha1sum picasa38-setup.exe 18e627bfb2869aff4aa185a23ae82b8327bf998b picasa38-setup.exe
$ wine --version wine-1.5.29-38-g8e4317c
Regards
http://bugs.winehq.org/show_bug.cgi?id=27775
Mikael Ståldal temp17@staldal.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |temp17@staldal.nu
--- Comment #5 from Mikael Ståldal temp17@staldal.nu --- I have a problem with Adobe Lightroom 4.4.1, the import dialog fails to open. I think it is related to this, since I get this message in the console several times: fixme:wia:wiadevmgr_EnumDeviceInfo (0x129ad0, 16, 0xb4e538): stub
I don't want to use WIA, I just want to import files on my disk, but Lightroom get stuck and the import dialog never shows up.
I use Wine 1.6.
Would it be possible to make an implementation of wiadevmgr_EnumDeviceInfo which always returns an empty IEnumWIA_DEV_INFO, telling the app that there are no WIA devices available?
I found the documentation here:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms630142%28v=vs.85%2...
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com --- It's probably a reasonable request, yes. As a "temporary" stub solution anyway.
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #7 from Mikael Ståldal temp17@staldal.nu --- Created attachment 48369 --> http://bugs.winehq.org/attachment.cgi?id=48369 Patch for Wine 1.6
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #8 from Mikael Ståldal temp17@staldal.nu --- This did not help for Lightroom 4, but feel free to try it for Picasa.
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #9 from Anastasius Focht focht@gmx.net --- Hello Mikael,
your patch is good enough to avoid the crash for Picasa.
Please consider sending to wine-patches for review process (it needs split). Thanks.
$ wine --version wine-1.7.21-61-gf9f3b21
Regards
http://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #10 from Mikael Ståldal temp17@staldal.nu --- I have tried to submit the patch twice already, but it was ignored.
What do you mean by "it needs split"?
https://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #11 from Austin English austinenglish@gmail.com --- (In reply to Mikael Ståldal from comment #10)
I have tried to submit the patch twice already, but it was ignored.
What do you mean by "it needs split"?
Split the patch into smaller patches that are functionally independent. E.g., add a missing interface in one, the stub dll in the next, then a function in a following patch, etc.
https://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #12 from Mikael Ståldal temp17@staldal.nu --- Why should this patch be split into smaller pieces? No subset of the whole patch will be useful.
https://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #13 from Austin English austinenglish@gmail.com --- (In reply to Mikael Ståldal from comment #12)
Why should this patch be split into smaller pieces? No subset of the whole patch will be useful.
It makes it easier to review the changes proposed. See http://wiki.winehq.org/SubmittingPatches for some other tips
https://bugs.winehq.org/show_bug.cgi?id=27775
--- Comment #14 from Mikael Ståldal temp17@staldal.nu --- I find it silly to split this small patch into multiple pieces. I am not playing by silly rules.
If anyone else wants to split and submit my patch, feel free to do so.
https://bugs.winehq.org/show_bug.cgi?id=27775
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #15 from Ken Sharp imwellcushtymelike@gmail.com --- Still a stub.
https://bugs.winehq.org/show_bug.cgi?id=27775
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #16 from super_man@post.com --- still an issue 1.7.50(git)
https://bugs.winehq.org/show_bug.cgi?id=27775
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |michael@fds-team.de, | |sebastian@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wiaservc-IEnum | |WIA_DEV_INFO
https://bugs.winehq.org/show_bug.cgi?id=27775
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |wia
https://bugs.winehq.org/show_bug.cgi?id=27775
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |bunglehead@gmail.com
--- Comment #17 from Nikolay Sivov bunglehead@gmail.com --- I'll improve this patch and will send it soon.
https://bugs.winehq.org/show_bug.cgi?id=27775
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead@gmail.com |wine-bugs@winehq.org
--- Comment #18 from Nikolay Sivov bunglehead@gmail.com --- Should be fixed with http://source.winehq.org/git/wine.git/?a=commit;h=9cb1981e304bc54e9378ae52a5.... Committed version is more honest about method return values but still is enough for me to display Import dialog in Picasa 3.8. But please retest to make sure.
https://bugs.winehq.org/show_bug.cgi?id=27775
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9cb1981e304bc54e9378ae52a53 | |67d9db576872a Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #19 from Anastasius Focht focht@gmx.net --- Hello folks,
this is fixed by commit https://source.winehq.org/git/wine.git/commitdiff/9cb1981e304bc54e9378ae52a5...
Thanks Nikolay and Mikael for the initial patch.
Regards
https://bugs.winehq.org/show_bug.cgi?id=27775
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.53.
https://bugs.winehq.org/show_bug.cgi?id=27775
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://dl.google.com/picasa |https://web.archive.org/web |/picasa38-setup.exe |/20120721231240/http://dl.g | |oogle.com/picasa/picasa38-s | |etup.exe
--- Comment #21 from Anastasius Focht focht@gmx.net --- Hello folks,
adding stable download link via Internet Archive for documentation.
https://web.archive.org/web/20120721231240/http://dl.google.com/picasa/picas...
https://www.virustotal.com/gui/file/2c20719a4cb3b1948db221790167e22153fef978...
$ sha1sum picasa38-setup.exe 18e627bfb2869aff4aa185a23ae82b8327bf998b picasa38-setup.exe
$ du -sh picasa38-setup.exe 14M picasa38-setup.exe
Regards