[Bug 38064] New: Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Bug ID: 38064
           Summary: Using alt+enter to fullscreen any rpgmaker XP game
                    causes keyboard input lose and not fullscreen
           Product: Wine
           Version: 1.7.36
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Full screen used to work fine in wine-1.7.31 and broke in wine-1.7.31.

Now when I try to go full screen it doesn't take input from the keyboard
meaning I can't exit and have to power off my laptop.
Also it doesn't fullscreen properly just part of the window is redrawn in the
top left.

I've bisected the input issue to this commit:

45d530461bf29c953f5f4532cc0e917b4c4fc296 is the first bad commit
commit 45d530461bf29c953f5f4532cc0e917b4c4fc296
Author: Stefan Dösinger 
Date:   Thu Nov 13 20:39:25 2014 +0100

wined3d: Minimize device windows on focus loss.

And bisected the drawing issue to:

commit f6dde7062413a1dfdd71acc92c5178ac66f3ade0
Author: Stefan Dösinger 
Date:   Tue Nov 18 21:26:57 2014 +0100

wined3d: Restore the display mode on focus change.

Example app:
http://www.itsqueeze.com/wp-content/uploads/2015/02/Custom_Mouse_System.tar....

You also need the run time package for Rpgmaker XP:

http://www.rpgmakerweb.com/download/additional/run-time-packages

Just run Game.exe and press alt+enter

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Timothy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Timothy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #1 from Timothy  ---
> Full screen used to work fine in wine-1.7.31 and broke in wine-1.7.31.

That should be:

Full screen used to work fine in wine-1.7.31 and broke in wine-1.7.32.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |45d530461bf29c953f5f4532cc0
                   |                            |e917b4c4fc296

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #2 from Stefan Dösinger  ---
Created attachment 50728
  --> https://bugs.winehq.org/attachment.cgi?id=50728
user32: Silently ignore temporary foreground loss.

Does this patch fix the regressions? It fixes a few other problems that were
introduced with focus loss handling in wined3d.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #3 from Timothy  ---
Nope. Both issues still happen with this patch applied.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #4 from Stefan Dösinger  ---
The sample app switches fullscreen and windowed modes fine for me. I tested it
in KDE and inside a Wine virtual desktop. Which window manager are you using?

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #5 from Timothy  ---
I'm seeing the issue on Fedora 21 running Mate. I tried yesterday to reproduce
under Gnome 3 just in case it was a window manager thing but I couldn't get it
to even try to fullscreen but that's a different issue and a gnome one by the
looks of things.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #6 from Stefan Dösinger  ---
I just tested it on MATE, and indeed the behavior is broken. Can you see if
https://github.com/mate-desktop/marco/pull/167 fixes things? For reference have
a look at https://github.com/mate-desktop/marco/issues/166, I've been
discussing the related Marco bug there.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #7 from Timothy  ---
Ok thanks. It may take me a little while to test this out as I haven't built
Marco before.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #8 from Timothy  ---
The Marco patch fixes most of the problems, however it still doesn't work 100%
correctly.

When using alt+enter to fullscreen the application fullscreens but then it
loses focus and you end up back at the desktop where you need to re-select the
application from the taskbar.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #9 from Stefan Dösinger  ---
I guess there are two problems here: One where the application gets stuck
because Marco doesn't minimize it (solved by my patch), and another one where
the application thinks it loses focus even though it has not. The focus loss
(and thus minimization to the desktop) doesn't happen inside a virtual desktop
and with KDE, so I guess this is another case where Wine's interaction with
Marco goes wrong. I'll try to debug it to find out if it is our bug or Marco's,
but I can't give you an ETA at this point.

(Also I have to do more pushing to get the fix for the other issue upstream. It
has been accepted into Muffin already, so that's 1 out of 3 Metacity forks)

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #10 from Stefan Dösinger  ---
Can you retest this game? Patch ccf430eb52fb9a3a7c8bfdcbe7805025fb6f5dec fixed
a few focus loss regressions, it may have an effect on this game too.

Also I believe my Metacity fix is now upstream in all Metacity forks. I think
Marco only applies it to fullscreen windows, which uncovers a different bug in
Wine. If it doesn't work, try setting the game's fullscreen resolution to your
native screen resolution.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |[e-mail]

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

--- Comment #11 from Henri Verbeet  ---
Is this still an issue?

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Timothy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Timothy  ---
Testing on the Mate and Wine version that come with Fedora 27 alt+enter causes
the window to loose focus and I end up back at the desktop but selecting the
app again I enter fullscreen mode and everything is drawn correctly and
keyboard input it working.

The loose of focus might be another bug but the more serious issues seem to
have been fixed so I'm closing this. Thanks.

[Bug 38064] Using alt+enter to fullscreen any rpgmaker XP game causes keyboard input lose and not fullscreen

https://bugs.winehq.org/show_bug.cgi?id=38064

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 3.1.