[Bug 16136] New: Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Summary: Full-screen app losing focus hangs when focus is
                    returned
           Product: Wine
           Version: 1.1.8
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Linux: 2.6.26.6-79 (Redhat distro)
X.Org X Server 1.5.0
Window manager: fvwm 2.5.24 (running with virtual screens)

When running Lord of the Rings Onine in full screen mode, if I switch screens
away from the app and then switch back, the app is hung, or at least can't
redraw.

A workaround is to not let the focus go to the desktop is by commenting out the
SetForegroundWindow() call in event.c, X11DRV_FocusOut().

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #1 from Eric Sandall   2008-11-22 16:58:02 ---
Created an attachment (id=17410)
 --> (http://bugs.winehq.org/attachment.cgi?id=17410)
Fixes focus crashing LoTRO MoM on some machines

This happens with wine 1.1.9 as well. The issue started after the Mines of
Moria (Volume II - Book I - Mines of Moria) patch was applied. Before that
patch, losing focus worked fine.

I tried the patch at
http://appdb.winehq.org/commentview.php?iAppId=4891&iVersionId=14566&...:
--- event.c~ 2008-11-07 11:09:33.000000000 -0500
+++ event.c 2008-11-20 13:10:15.000000000 -0500
@@ -685,7 +685,7 @@
if (hwnd == GetForegroundWindow())
{
TRACE( "lost focus, setting fg to desktop\n" );
- SetForegroundWindow( GetDesktopWindow() );
+ //SetForegroundWindow( GetDesktopWindow() );
}
}
}

As mentioned by the Requestor of this bug, and that patch fixes this issue.

I have attached a patch which removes the entire focus check, however I would
like to point out this bug is not happening on every box. I will do more
testing to try and find the culprit, but this is happening with the WM set to
Enlightenment DR 17 20081121 on one box, but not KDE 3.5.10 on a different box.
I do not believe this is the proper fix, but it does fix the issue for some.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Eric Sandall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #2 from Eric Sandall   2008-11-22 17:56:46 ---
Without this patch and running fluxbox 1.0.0 on my machine with this issue in
Enlightenment DR17 20081121 I can switch virtual desktops without LotRO
freezing. I will try KDE 3.5.10 on this box to do as direct a comparison as
possible between the box that was working and the one with this issue once it
finishes installing.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #3 from Eric Sandall   2008-11-27 19:27:39 ---
KDE 3.5.10 and 4.1.3 do not cause LotRO with the MoM expansion installed to
crash when switching virtual desktops. However, they (and fluxbox) do cause
LotRO+MoM to be minimized when I switch back to the virtual desktop. This did
not happen prior to the MoM expansion.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #4 from Eric Sandall   2008-12-01 01:33:06 ---
Another issue I've had (only tested in KDE 3.5.10), which seems related as I'll
mention below, since the Mines of Moria release is that when I switch virtual
desktops (e.g. with KDE 3.5.10 using CTRL+F1 to switch to Desktop 1, that game
being in Desktop 2), when I go back to the desktop with the game, it is
minimized. Before the Mines of Moria patch (no change in WINE) the game would
stay fullscreen (and also did not crash when switching desktops on some
WMs/DEs, as this bug is about).

Why it might be related to this bug:
When I apply this patch, the game stays maximized when I switch back and forth
between desktops (and also doesn't crash in some WMs/DEs, e.g. Enlightenment
DR17). However, when I switch back to the game, no matter what I do it will not
grab the keyboard or mouse input. I had a Konsole open in the background on
that Desktop and it was receiving the keyboard output, rather than the
maximized (and supposedly in the foreground) game. This happens with and
without an extra window on the same Desktop and both "Focus with Mouse" and
"Click to Focus" have this issue.

So the focus is being stolen and not given back when this patch is applied, but
without the patch on most WM/DE the app will be minimized when Desktops are
switched, and on a few (FVWM and Enlightenment DR17) the app crashes.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #5 from Austin English   2009-06-02 10:37:42 ---
Is this still an issue in current (1.1.22 or newer) wine?

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #6 from Eric Sandall   2009-06-07 16:40:20 ---
Still happens with Enlightenment DR17 and WINE 1.1.23, but not with fluxbox
1.0.0.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #7 from Eric Sandall   2009-06-19 13:55:35 ---
Still happens with WINE 1.1.24 and KDE 4.2.4.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from [e-mail]  2009-07-04 20:29:49 ---
*** This bug has been confirmed by popular vote. ***

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from [e-mail]  2009-07-04 20:40:42 ---
I have reproduced this bug on wine-1.1.25 with KDE 4.2.4 and NVIDIA display
drivers 180.60. The host operating system is Gentoo X86.

Symptoms: LOTRO freezes all X server functionality (except mouse movement and
sound) upon loosing focus in full screen mode. The freeze can be broken by
manually killing "lotroclient.exe" from a console session. "lotroclient.exe" is
listed as "<defunct>" in "ps ax" displays when this issue occurs.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Anton Vorobyov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Anton Vorobyov   2009-08-16 03:24:28 ---
Bug #15485 seems to be the same issue. It also has been introduced by some
patch from EVE's developer.

While i'm trying to see if issue get fixed, could you try to check if launching
LotR in the virtual desktop resolves issue for you?

If issues are the same we may try to push both devs to provide complete
changelog for both patches and see if there's anything similiar.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #11 from Anton Vorobyov   2009-08-16 03:51:16 ---
Commenting SetForegroundWindow( GetDesktopWindow() ); line helps in my case.
Thanks :)

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #12 from Don Koch   2009-10-05 12:23:54 ---
As of 1.1.30, even with the "patch", it now loses keyboard focus.  Mouse focus
still works.  I don't know if this is related or a new bug.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #13 from Eric Sandall   2010-03-20 01:05:34 ---
(In reply to comment #12)
> As of 1.1.30, even with the "patch", it now loses keyboard focus.  Mouse focus
> still works.  I don't know if this is related or a new bug.

When using Dungeons & Dragons Online: Eberron Unlimited
(http://appdb.winehq.org/objectManager.php?sClass=application&iId=2910 ) or
Lord of the Rings Online: Shadows of Angmar
(http://appdb.winehq.org/objectManager.php?sClass=application&iId=4891), the
keyboard definitely loses focus and the mouse somewhat does.

In the game, the mouse has the game cursor rather than the Window Manager (KDE
4.4 here) cursor and can mouse over items in the game and highlight the item,
but trying to interact with the game in any way (e.g. selecting an object by
clicking) does not work.

System 1:
WINE 1.1.41
KDE 4.4.1
X.org 1.7.6
nVidia's 190.53 and 195.36.15 stable drivers
CFLAGS=-march=core2 -m32 -pipe -DPIC -fPIC -O2
LDFLAGS=-z combreloc -s -Wl,-O1 -Wl,--hash-style=gnu

System 2:
WINE 1.1.41
KDE 4.3.5
X.org 1.7.6
nVidia's 190.53 and 195.36.15 stable drivers
CFLAGS=-march=athlon-xp -mmmx -mfpmath=sse -msse -m3dnow -pipe -DPIC -fPIC -O2
LDFLAGS=-z combreloc -s -Wl,-O1 -Wl,--hash-style=gnu

I have not tried with any patches, just a straight wine-1.1.41.tar.bz2 source
compile. Works fine if I use fluxbox 1.0.0 on either System 1 or System 2, so
must be an interaction with KDE's (and E17's or GNOME's) focus.

I normally use "Focus Follows Mouse" in KDE, but I also tried "Focus Follows
Under Mouse" and "Click to Focus" to no avail. I have not tried fiddling with
the "Focus Stealing Prevention" options.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #14 from Eric Sandall   2010-03-21 00:56:13 ---
Just now happened in Fluxbox 1.0.0 when the WINE file browser popped up
(minimizing LotRO) when trying to attach a screenshot to the Lord of the Rings
Online in-game ticket system. Fluxbox is where I could not seem to replicate
this issue.

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

--- Comment #15 from Austin English  2011-03-29 19:30:16 CDT ---
This is your friendly reminder that there has been no bug activity for 6
months. Is this still an issue in current (1.3.16 or newer) wine?

[Bug 16136] Full-screen app losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Jerome Leclanche  2011-03-29 23:10:38 CDT ---
(In reply to comment #15)
> This is your friendly reminder that there has been no bug activity for 6
> months. Is this still an issue in current (1.3.16 or newer) wine?

This bug is a dupe of bug 15485. Same patch fixes both issues.

[Bug 16136] Lord of the Rings Onine: losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Full-screen app losing      |Lord of the Rings Onine:
                   |focus hangs when focus is   |losing focus hangs when
                   |returned                    |focus is returned

[Bug 16136] Lord of the Rings Onine: losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #17 from Austin English  2011-03-30 12:18:40 CDT ---
Dupe.

*** This bug has been marked as a duplicate of bug 15485 ***

[Bug 16136] Lord of the Rings Onine: losing focus hangs when focus is returned

http://bugs.winehq.org/show_bug.cgi?id=16136

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Dmitry Timoshkov  2011-03-30 23:06:03 CDT ---
Closing duplicate.