[Bug 34305] New: League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

Bug #: 34305
           Summary: League of Legends 3.10.13_07_26_19_59: page fault in
                    read_map()
           Product: Wine
           Version: 1.7.0
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winmm&mci
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 45668
  --> http://bugs.winehq.org/attachment.cgi?id=45668
The page fault's backtrace.

Hello,

I have just compiled the latest git wine version.
wine-1.7.0-114-g73aef40

When I do
cd ~/lol/LoL_Prefix/drive_c/Riot\ Games/League\ of\ Legends && wine
./lol.launcher.exe
the LoL welcome window appears, with its prominent "Play" button.

Then when I click the "Play" button, a new large window appears with an
"Account Login" form that prompts for the account and password, and almost
simultaneously the Wine "Program Error" window appears, reporting a crash at
dlls/winmm/waveform.c:273 (see attached file backtrace.txt).

According to traces I added, I think I have located the problem.

Except from waveform.c's WOD_Open() function:

if(WINMM_IsMapper(info->req_device)){
            devices = g_out_mapper_devices;
            mmdevice = read_map(g_out_map, 0);
            lock = &g_devthread_lock;
            internal_index = MAPPER_INDEX;

When the user requests the WAVE_MAPPER, the code calls read_map() with device
index 0 without first checking whether the number of devices is greater than 0.

Could you please have a look?

Thanks!

Best regards
Fabrice

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

--- Comment #1 from Fabrice Bauzac  2013-08-19 22:44:28 CDT ---
Created attachment 45669
  --> http://bugs.winehq.org/attachment.cgi?id=45669
Proposed patch.

In this proposed patch, we handle this case by returning MMSYSERR_BADDEVICEID.

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

--- Comment #2 from Fabrice Bauzac  2013-08-20 12:12:57 CDT ---
Created attachment 45671
  --> http://bugs.winehq.org/attachment.cgi?id=45671
Patch which also targets WID_Open().

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |21e0f739bed023a903866a145ee
                   |                            |75bdc96e8bce8
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English  2013-08-21 14:14:53 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/21e0f739bed023a903866a145ee...

Patch committed, thanks!

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2013-08-30 13:05:07 CDT ---
Closing bugs fixed in 1.7.1.

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.x

[Bug 34305] League of Legends 3.10.13_07_26_19_59: page fault in read_map()

http://bugs.winehq.org/show_bug.cgi?id=34305

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.x                       |---

--- Comment #5 from Alexandre Julliard  2013-11-15 13:39:51 CST ---
Removing 1.6.x milestone from bugs included in 1.6.1.