[Bug 45312] New: AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Bug ID: 45312
           Summary: AC Syndicate needs bcrypt algorythm/functions
                    (ECDH_P256, BCryptGenerateKeyPair,
                    BCryptFinalizeKeyPair)
           Product: Wine
           Version: 3.9
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bcrypt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Gentoo

Assassin's Creed : Syndicate crashes when the game wants to access to the main
menu. Precisely after the Intro video (Nvidia, Ubisoft video) and the screen
with the message which say "Press any key to continue".

This issue exists only when you launch the game with UPlay on Online Mode.
If UPlay is on Offline mode (no cloud save, success etc...), you can to access
to the main menu without problem.

----------

1- When the game crashes, i have these line in my output console :
"0108:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"ECDH_P256" not
supported"

I created a hack to add the support of ECDH_P256 (see attached files)

2- With my 1st hack with ECDH_P256 support, the game still crashes but for an
other reason. This time, i have error line about a bcrypt function not
implemented : BCryptGenerateKeyPair

I created a hack to implement this function (see attached files)

3- With my both latest patches, the game continu to crash at the same place.
Now it crashes because a second function for bcrypt is not implemented :
BCryptFinalizeKeyPair

I created a hack to implement this function (see attached files)

----------

With my 3 workaround, the crash is gone and i can to access to the main menu
with UPlay on Online mode after pressing a key.

Now, i don't know if my workaround are correct to send these files to
wine-patches or if someone prefer to implement completly these
functions/algorythm.

Thanks,
Maxime

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

--- Comment #1 from Berillions  ---
Created attachment 61590
  --> https://bugs.winehq.org/attachment.cgi?id=61590
Add ECDH P256 support for Bcrypt

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

--- Comment #2 from Berillions  ---
Created attachment 61591
  --> https://bugs.winehq.org/attachment.cgi?id=61591
Add support for BCryptGenerateKeyPair

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

--- Comment #3 from Berillions  ---
Created attachment 61592
  --> https://bugs.winehq.org/attachment.cgi?id=61592
Add support for BCryptFinalizeKeyPair

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Alistair Leslie-Hughes  ---
(In reply to Berillions from comment #3)
> Created attachment 61592 [details]
> Add support for BCryptFinalizeKeyPair

This patch isn't correct the. The first argument is BCRYPT_ALG_HANDLE not
"BCRYPT_ALG_HANDLE *".

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Berillions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61592|0                           |1
        is obsolete|                            |

--- Comment #5 from Berillions  ---
Created attachment 61593
  --> https://bugs.winehq.org/attachment.cgi?id=61593
Add support for BCryptFinalizeKeyPair V2

(In reply to Alistair Leslie-Hughes from comment #4)
> (In reply to Berillions from comment #3)
> > Created attachment 61592 [details]
> > Add support for BCryptFinalizeKeyPair
>
> This patch isn't correct the. The first argument is BCRYPT_ALG_HANDLE not
> "BCRYPT_ALG_HANDLE *".

Oh yes sorry for the mistake :-)

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/bcrypt-BCryptGen
                   |                            |erateKeyPair
             Status|UNCONFIRMED                 |STAGED

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |73b695f059740715ebd3ea0ce3c
                   |                            |e88477977e628
         Resolution|---                         |FIXED

--- Comment #6 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=73b695f059740715ebd3ea0ce...

[Bug 45312] AC Syndicate needs bcrypt algorythm/functions (ECDH_P256, BCryptGenerateKeyPair, BCryptFinalizeKeyPair)

https://bugs.winehq.org/show_bug.cgi?id=45312

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 4.2.