https://bugs.winehq.org/show_bug.cgi?id=40236
Bug ID: 40236 Summary: winetricks ie6: buttons are missing Product: Wine Version: 1.9.4 Hardware: x86 OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: shell32 Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com Regression SHA1: 6e638d824b80e8a02cb830cd6bc25a7ef8507849 Distribution: Fedora
Created attachment 53780 --> https://bugs.winehq.org/attachment.cgi?id=53780 screenshot
Regression, introduced by: commit 6e638d824b80e8a02cb830cd6bc25a7ef8507849 Author: Dmitry Timoshkov dmitry@baikal.ru Date: Mon Mar 23 10:20:59 2015 +0800
shell32: Update version information to match XP values.
To reproduce: $ rm -rf ~/.wine $ winetricks -q ie6 $ cd ~/.wine/drive_c/Program\ Files/Internet\ Explorer/ $ wine "C:\program files\internet explorer\iexplore.exe"
see screenshot.
https://bugs.winehq.org/show_bug.cgi?id=40236
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@baikal.ru, | |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #1 from Dmitry Timoshkov dmitry@baikal.ru --- Looks like the culprit is dwMajorVersion=6 returned by shell32.GetDllVersion(). Changing GetDllVersion() to return dwMajorVersion=5 is a workaround.
https://bugs.winehq.org/show_bug.cgi?id=40236
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29986
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru --- When shell32 reports version 6 Internet Explorer tries to load bitmaps for toolbar buttons from shell32 resources which Wine's shell32 doesn't provide. For version 5 IE loads its own bitmaps.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #3 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 53782 --> https://bugs.winehq.org/attachment.cgi?id=53782 patch
Attached patch should fix the reported problem.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #4 from Austin English austinenglish@gmail.com --- Created attachment 53786 --> https://bugs.winehq.org/attachment.cgi?id=53786 screenshot with patch
With the patch, I get some tango icons, but others are missing (and they're not IE's builtin, but I don't know if that should be the case or not).
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #4)
Created attachment 53786 [details] screenshot with patch
With the patch, I get some tango icons, but others are missing (and they're not IE's builtin, but I don't know if that should be the case or not).
Yes, the ietoolbar.svg from dlls/ieframe contains only 6 icons, and IE6 expects to see 16. Since I'm not an artist I left the missing icons empty (and moved the Print icon 2 places to the right).
https://bugs.winehq.org/show_bug.cgi?id=40236
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #53782|0 |1 is obsolete| |
--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 53787 --> https://bugs.winehq.org/attachment.cgi?id=53787 1/2
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #7 from Dmitry Timoshkov dmitry@baikal.ru --- Created attachment 53788 --> https://bugs.winehq.org/attachment.cgi?id=53788 2/2
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #8 from Dmitry Timoshkov dmitry@baikal.ru --- I've added more Tango icons to IE toolbar in patch 2/2.
https://bugs.winehq.org/show_bug.cgi?id=40236
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |erich.e.hoover@wine-staging | |.com, michael@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/shell32-Toolba | |r_Bitmaps
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #9 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #7)
Created attachment 53788 [details] 2/2
I get a pretty reliable crash: wine: Unhandled page fault on read access to 0x00000001 at address 0xf75fde11 (thread 0024), starting debugger... Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0xf75fde11). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:f75fde11 ESP:0032dcc0 EBP:0032dcf8 EFLAGS:00010202( R- -- I - - - ) EAX:00000073 EBX:f7796898 ECX:f7603200 EDX:00000232 ESI:00000073 EDI:00000001 Stack dump: 0x0032dcc0: 00000073 0032dce0 0032dd3c 00002000 0x0032dcd0: 0001001e 00270032 0032dd18 711ab800 0x0032dce0: 00000010 00000010 f75fdddb 7bcd7084 0x0032dcf0: 711ab800 711ab800 0032dd38 7bc5354c 0x0032dd00: 711ab800 00000001 006d0065 00000000 0x0032dd10: 00000000 00000000 00000000 00000000 Backtrace: =>0 0xf75fde11 strcmpiW+0x41(str1="shell32.dll", str2=*** invalid address 0x1 ***) [/home/austin/wine-git/libs/wine/string.c:33] in libwine.so.1 (0x0032dcf8) 1 0x7bc5354c find_basename_module+0x2b(name="shell32.dll") [/home/austin/wine-git/dlls/ntdll/loader.c:374] in ntdll (0x0032dd38) 2 0x7bc54388 find_dll_file+0x2c7(load_path="C:\Program Files\Internet Explorer;.;C:\windows\system32;C:\windows\system;C:\windows;C:\windows\system32;C:\windows;C:\windows\system32\wbem", libname="shell32.dll", filename="??", size=0x32de18, pwm=0x32de1c, handle=(nil)) [/home/austin/wine-git/dlls/ntdll/loader.c:2127] in ntdll (0x0032ddd8) 3 0x7bc54d0d LdrGetDllHandle+0xac(load_path=<couldn't compute location>, flags=<couldn't compute location>, name=<couldn't compute location>, base=<couldn't compute location>) [/home/austin/wine-git/dlls/ntdll/loader.c:2373] in ntdll (0x0032df38) 4 0x7b855705 GetModuleHandleExW+0x74(flags=<couldn't compute location>, name=<couldn't compute location>, module=<couldn't compute location>) [/home/austin/wine-git/dlls/kernel32/module.c:581] in kernel32 (0x0032df98) 5 0x7b85591a GetModuleHandleW+0x29(module=<couldn't compute location>) [/home/austin/wine-git/dlls/kernel32/module.c:631] in kernel32 (0x0032dfd8) 6 0x70bfcb9f in shlwapi (+0x2cb9e) (0x0032e1fc) 7 0x711a3655 in browseui (+0x43654) (0x0032e42c) 0xf75fde11 strcmpiW+0x41 [/home/austin/wine-git/libs/wine/string.c:33] in libwine.so.1: movzwl 0x0(%edi),%eax 33 int ret = tolowerW(*str1) - tolowerW(*str2);
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #16 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #15)
winetricks -q ie6 cd ~/.wine/drive_c/Program\ Files/Internet\ Explorer wine "C:\Program Files\Internet Explorer\iexplore.exe"
crashes immediately for me.
Are you testing the staging build or just applied 2 attached patches?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #10 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #9)
(In reply to Dmitry Timoshkov from comment #7)
Created attachment 53788 [details] 2/2
I get a pretty reliable crash: wine: Unhandled page fault on read access to 0x00000001 at address 0xf75fde11 (thread 0024), starting debugger... Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0xf75fde11).
How is that related to new toolbar images?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #11 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #10)
(In reply to Austin English from comment #9)
(In reply to Dmitry Timoshkov from comment #7)
Created attachment 53788 [details] 2/2
I get a pretty reliable crash: wine: Unhandled page fault on read access to 0x00000001 at address 0xf75fde11 (thread 0024), starting debugger... Unhandled exception: page fault on read access to 0x00000001 in 32-bit code (0xf75fde11).
How is that related to new toolbar images?
I didn't see them before those two patches.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #12 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #11)
I didn't see them before those two patches.
Probably an addition of correct toolbar images triggered a bug in another place.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #13 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #12)
(In reply to Austin English from comment #11)
I didn't see them before those two patches.
Probably an addition of correct toolbar images triggered a bug in another place.
Sure, makes sense. Deserves its own bug (once it's triggered in upstream wine ;) )
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #14 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #13)
I didn't see them before those two patches.
Probably an addition of correct toolbar images triggered a bug in another place.
Sure, makes sense. Deserves its own bug (once it's triggered in upstream wine ;) )
Could you provide the steps to reproduce the crash?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #15 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #14)
(In reply to Austin English from comment #13)
I didn't see them before those two patches.
Probably an addition of correct toolbar images triggered a bug in another place.
Sure, makes sense. Deserves its own bug (once it's triggered in upstream wine ;) )
Could you provide the steps to reproduce the crash?
winetricks -q ie6 cd ~/.wine/drive_c/Program\ Files/Internet\ Explorer wine "C:\Program Files\Internet Explorer\iexplore.exe"
crashes immediately for me.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #17 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #16)
(In reply to Austin English from comment #15)
winetricks -q ie6 cd ~/.wine/drive_c/Program\ Files/Internet\ Explorer wine "C:\Program Files\Internet Explorer\iexplore.exe"
crashes immediately for me.
Are you testing the staging build or just applied 2 attached patches?
Plain wine + your 2 patches.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #18 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #17)
winetricks -q ie6 cd ~/.wine/drive_c/Program\ Files/Internet\ Explorer wine "C:\Program Files\Internet Explorer\iexplore.exe"
crashes immediately for me.
Are you testing the staging build or just applied 2 attached patches?
Plain wine + your 2 patches.
I can't reproduce the crash neither with staging nor with winehq+patches.
https://bugs.winehq.org/show_bug.cgi?id=40236
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #19 from André H. nerv@dawncrow.de --- Doesn't crash here with or without patches. What about upstreaming them?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #20 from Sebastian Lackner sebastian@fds-team.de --- (In reply to André H. from comment #19)
Doesn't crash here with or without patches. What about upstreaming them?
The patch currently duplicates icons because the Wine build system does not support resizing yet. Do you want to take a look into that?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #21 from André H. nerv@dawncrow.de --- (In reply to Sebastian Lackner from comment #20)
(In reply to André H. from comment #19)
Doesn't crash here with or without patches. What about upstreaming them?
The patch currently duplicates icons because the Wine build system does not support resizing yet. Do you want to take a look into that?
I had a look in maintainer mode, but it's too horrible :) so... no
https://bugs.winehq.org/show_bug.cgi?id=40236
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #22 from winetest@luukku.com --- Still valid against wine 2.0.rc3. But do you think this patch fixes bug 29986 too? I tried staging too and the buttons are drawn and I can't see any greenish thing. I don't remember anymore how IE6 looked at xp, but it feels that the icons are drawn somehow incorrectly. The icons are drawn on top of text. That doesnt look right.
https://bugs.winehq.org/show_bug.cgi?id=40236
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/shell32-Toolba |er/patches/shell32-Toolbar_ |r_Bitmaps |Bitmaps
https://bugs.winehq.org/show_bug.cgi?id=40236
Linards linards.liepins@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |linards.liepins@gmail.com
--- Comment #23 from Linards linards.liepins@gmail.com --- I suggest t a that this is only x86 (ia86 ) supported winetricks installation.
$ Lejupielādes/winetricks ie6 ------------------------------------------------------ You are using a 64-bit WINEPREFIX. Note that many verbs only install 32-bit versions of packages. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug. ------------------------------------------------------ Using winetricks 20190615-next - sha256sum: 2d3311f8cc0783b747c4e074008e701f2ce844765ba53d2fd4d27126d1df2383 with wine-4.13 (Staging) and WINEARCH=win64 Executing w_do_call ie6 Executing load_ie6 ------------------------------------------------------ This package (ie6) does not work on a 64-bit installation. You must use a prefix made with WINEARCH=win32.
https://bugs.winehq.org/show_bug.cgi?id=40236
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #24 from joaopa jeremielapuree@yahoo.fr --- Does the bug still occur with wine-6.23?
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #25 from Austin English austinenglish@gmail.com --- (In reply to joaopa from comment #24)
Does the bug still occur with wine-6.23?
There's a download, as you've been told before, you can test yourself.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #26 from joaopa jeremielapuree@yahoo.fr --- It is better that the owner of the bug reports. Moreover, there is no link in the URL place.
https://bugs.winehq.org/show_bug.cgi?id=40236
--- Comment #27 from Austin English austinenglish@gmail.com --- Still in wine-7.3-237-g18230d23c59
https://bugs.winehq.org/show_bug.cgi?id=40236
Alex Henrie alexhenrie24@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24@gmail.com
--- Comment #28 from Alex Henrie alexhenrie24@gmail.com --- I sent a patch that I think is a cleaner solution than the one in Wine Staging, but it hasn't been reviewed yet: https://gitlab.winehq.org/wine/wine/-/merge_requests/4174
I was hoping that Jacek would review it, but he's not the only one who can.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla