https://bugs.winehq.org/show_bug.cgi?id=36236
Bug ID: 36236 Summary: valgrind shows a leak in comctl32/tests/propsheet.c Product: Wine Version: 1.7.18 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com
==25320== 56 bytes in 1 blocks are definitely lost in loss record 389 of 894 ==25320== at 0x7BC4C735: notify_alloc (heap.c:255) ==25320== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==25320== by 0x7B84586B: HeapAlloc (heap.c:271) ==25320== by 0x7B845A92: GlobalAlloc (heap.c:364) ==25320== by 0x7B846ECF: LocalAlloc (heap.c:967) ==25320== by 0x4C84A16: Alloc (comctl32undoc.c:74) ==25320== by 0x4CD47F0: CreatePropertySheetPageA (propsheet.c:2918) ==25320== by 0x49BEBFD: test_PSM_ADDPAGE (propsheet.c:781) ==25320== by 0x49BF142: func_propsheet (propsheet.c:852) ==25320== by 0x4A14A1C: run_test (test.h:584) ==25320== by 0x4A14E0B: main (test.h:654) ==25320==
https://bugs.winehq.org/show_bug.cgi?id=36236
--- Comment #1 from Austin English austinenglish@gmail.com --- Also: ==20567== 84 bytes in 3 blocks are definitely lost in loss record 504 of 906 ==20567== at 0x7BC50A9B: RtlAllocateHeap (heap.c:255) ==20567== by 0x51B0B05: DIALOG_get_info (defdlg.c:342) ==20567== by 0x51B0BAD: DefDlgProcA (defdlg.c:369) ==20567== by 0x522B269: ??? (in /home/austin/wine-valgrind-known/dlls/user32/user32.dll.so) ==20567== by 0x522B9A5: call_window_proc (winproc.c:244) ==20567== by 0x522E072: WINPROC_call_window (winproc.c:909) ==20567== by 0x51EA89C: call_window_proc (message.c:2223) ==20567== by 0x51F1FE5: send_message (message.c:3260) ==20567== by 0x51F4510: SendMessageA (message.c:3476) ==20567== by 0x522277C: WIN_CreateWindowEx (win.c:1589) ==20567== by 0x521B34E: CreateWindowExA (win.c:1723) ==20567== by 0x51B5ED3: DIALOG_CreateIndirect (dialog.c:657) ==20567== by 0x51B799D: CreateDialogIndirectParamAorW (dialog.c:763) ==20567== by 0x51B79FC: CreateDialogIndirectParamA (dialog.c:772) ==20567== by 0x4DBFFC7: PROPSHEET_CreatePage (propsheet.c:1469) ==20567== by 0x4DC160E: PROPSHEET_SetCurSel (propsheet.c:2030) ==20567== by 0x4DC580E: PROPSHEET_DialogProc (propsheet.c:3491) ==20567== by 0x522B269: ??? (in /home/austin/wine-valgrind-known/dlls/user32/user32.dll.so) ==20567== by 0x522BAF6: call_dialog_proc (winproc.c:265) ==20567== by 0x522BEC0: WINPROC_CallProcWtoA (winproc.c:727) ==20567==
https://bugs.winehq.org/show_bug.cgi?id=36236
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind
https://bugs.winehq.org/show_bug.cgi?id=36236
Bernhard Übelacker bernhardu@vr-web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@vr-web.de
--- Comment #2 from Bernhard Übelacker bernhardu@vr-web.de --- Created attachment 51689 --> https://bugs.winehq.org/attachment.cgi?id=51689 Free memory used by property sheet intentionally not added to property page.
Patch concerning the leak in comment #0
https://bugs.winehq.org/show_bug.cgi?id=36236
--- Comment #3 from Bernhard Übelacker bernhardu@vr-web.de --- Created attachment 51690 --> https://bugs.winehq.org/attachment.cgi?id=51690 Free DIALOGINFO structure when destroying window.
Patch concerning the leak in comment #1
This affects probably also one of the leaks in bugs #26070 #26139 #36582.
(Are these patches already acceptable for sending to wine-patches?)
https://bugs.winehq.org/show_bug.cgi?id=36236
--- Comment #4 from Bernhard Übelacker bernhardu@vr-web.de --- Patch for comment #0 got commited: http://source.winehq.org/git/wine.git/commitdiff/ccf2ea61798979ae92e682e7396...
(now to the harder part in comment #1, comments for that patch #1 are very appreciated ...)
https://bugs.winehq.org/show_bug.cgi?id=36236
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ccf2ea61798979ae92e682e7396 | |ecdd27fc80d61 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Austin English austinenglish@gmail.com --- (In reply to Bernhard Übelacker from comment #4)
Patch for comment #0 got commited: http://source.winehq.org/git/wine.git/commitdiff/ ccf2ea61798979ae92e682e7396ecdd27fc80d61
Thanks, marking fixed.
https://bugs.winehq.org/show_bug.cgi?id=36236
Bernhard Übelacker bernhardu@vr-web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #51689|0 |1 is obsolete| |
https://bugs.winehq.org/show_bug.cgi?id=36236
--- Comment #6 from Bernhard Übelacker bernhardu@vr-web.de --- The leak visible in comment #1 is still visible and unfixed.
I had not sent the patch "Free DIALOGINFO structure..." to wine-patches because it is a way more central change as the first one.
https://bugs.winehq.org/show_bug.cgi?id=36236
--- Comment #7 from Austin English austinenglish@gmail.com --- (In reply to Bernhard Übelacker from comment #6)
The leak visible in comment #1 is still visible and unfixed.
I can't currently reproduce it on my machine. In any case, I'd like to avoid metabugs. It's not always simple to identify when various valgrind issues are related or not (aside from what tests they're in), so I try to mark each bug fixed whenever there is any noticeable change, then file remaining issues in new bugs.
Feel free to open a new bug for that issue (or I will if/when it reappears on my machine :)).
https://bugs.winehq.org/show_bug.cgi?id=36236
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.47.
-
wine-bugs＠winehq.org