[Bug 22821] New: Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

Summary: Tropico 3 - cursor is black rectangle everywhere in
                    game
           Product: Wine
           Version: 1.2-rc1
          Platform: x86
               URL: http://www.gamershell.com/download_50826.shtml
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

works in wine-1.1.44-380-g0d84ccb
but not wine-1.1.44-382-g6264bc2

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[45b7eb6858f8da0721101a19a9fcd46d53c08e94] winex11: Move X11 locking inside the
cursor creation functions.

its okay with
 git checkout -f 45b7eb6858f8da0721101a19a9fcd46d53c08e94

Here ->
http://source.winehq.org/git/wine.git/?a=commit;h=45b7eb6858f8da0721101a19a9... 
its winex11 but in bugzilla winex11.drv

I thought i was lucky because need to test only one day  of commits (i compiled
the day before) but there where 6 commits about cursor. So need to do it with
bisect anyway. The first was bad so too bad i didnt use 'checkout' in first
place anyway.

ps:
text from bugzilla:
There are ten types of people, those who know binary and those who don't.
that make no sense, should be:
There are 10 types of people, those who know binary and those who don't.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

zil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #1 from NSLW   2010-05-23 10:35:21 ---
I can confirm that. Cursor looks like normal system cursor on screenshots so
it's impossible to show that problem.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #2 from Vincent Povirk   2010-05-26 10:36:43 ---
"0 revisions left" means you need to test one more revision before the bisect
is done.

Does it work if you checkout 6264bc20bc8d5d812be9a46dee3b765efe8b02a9 ?

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #3 from zil   2010-05-26 13:14:11 ---
> "0 revisions left" means you need to test one more revision before the bisect

is done.

This 0 is confusing

git checkout -f 45b7eb6858f8da0721101a19a9fcd46d53c08e94 <- solve problem

git checkout -f 6264bc20bc8d5d812be9a46dee3b765efe8b02a9 <- black box still
there

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #4 from Vincent Povirk   2010-05-26 13:24:02 ---
So the commit that broke it is:

commit 6264bc20bc8d5d812be9a46dee3b765efe8b02a9
Author: Alexandre Julliard 
Date:   Thu May 20 14:54:41 2010 +0200

winex11: Retrieve the cursor info with GetIconInfo to create a color
cursor.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from GyB   2010-05-26 13:54:29 ---
Space Rangers 2 is also affected by the same commit: mouse pointer changed into
a black square...but only during planetary battles. Everywhere else in the game
the cursor is shown correctly.

Result of regression testing was the same:

6264bc20bc8d5d812be9a46dee3b765efe8b02a9 is the first bad commit
commit 6264bc20bc8d5d812be9a46dee3b765efe8b02a9
Author: Alexandre Julliard 
Date:   Thu May 20 14:54:41 2010 +0200

winex11: Retrieve the cursor info with GetIconInfo to create a color
cursor.

:040000 040000 715e726184daf8d465ae90b12d55e881e1c62fec
c20dabc1a7e0fb4caef90335de3d862888c3c805 M    dlls

git checkout 45b7eb6858f8da0721101a19a9fcd46d53c08e94 solved the problem.

Workaround (at least in Space Rangers 2): turn off hardware cursor and switch
to software cursor in the options menu. In this way the pointer is displayed
correctly.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #6 from Alexandre Julliard   2010-05-26 13:58:31 ---
Please retest with latest git.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #7 from zil   2010-05-26 13:59:43 ---
6264bc20bc8d5d812be9a46dee3b765efe8b02a9 is the first bad commit
commit 6264bc20bc8d5d812be9a46dee3b765efe8b02a9
Author: Alexandre Julliard 
Date:   Thu May 20 14:54:41 2010 +0200

winex11: Retrieve the cursor info with GetIconInfo to create a color
cursor.

:040000 040000 715e726184daf8d465ae90b12d55e881e1c62fec
c20dabc1a7e0fb4caef90335de3d862888c3c805 M    dlls

yes i run bisect this time to end.
Sorry first regression test, this time checked
http://wiki.winehq.org/RegressionTesting

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #8 from GyB   2010-05-26 14:13:38 ---
wine-1.2-rc1-108-g5d4a743: it is fixed now (Space Rangers 2)

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

--- Comment #9 from zil   2010-05-26 14:39:00 ---
wine-1.2-rc1-108-g5d4a743

yes fixed, I confirm

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Juan Lang   2010-05-26 14:53:22 ---
Reported fixed.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

http://bugs.winehq.org/show_bug.cgi?id=22821

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2010-05-28 12:52:06 ---
Closing bugs fixed in 1.2-rc2.

[Bug 22821] Tropico 3 - cursor is black rectangle everywhere in game

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=22821

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |6264bc20bc8d5d812be9a46dee3
                   |                            |b765efe8b02a9
                URL|http://www.gamershell.com/d |https://web.archive.org/web
                   |ownload_50826.shtml         |/20210227141220/http://dl.4
                   |                            |players.de/f1/pc2/tropico3/
                   |                            |Tropico3Demo.exe