[Bug 28962] New: Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Bug #: 28962
           Summary: Mount & Blade: WFAS texture quality slider isn't
                    moving
           Product: Wine
           Version: 1.3.31
          Platform: x86
               URL: http://www.fileplanet.com/219895/210000/fileinfo/Mount
                    &Blade-with-Fire-and-Sword-Demo
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37241
  --> http://bugs.winehq.org/attachment.cgi?id=37241
terminal output

Start Mount & Blade With Fire and Sword, click trial, configure, video panel
(partially hidden due to bug 28960), try to move texture quality slider. It
doesn't move, however texture quality number (visible next to the slider) is
changing. Winetricks comctl32 works around this.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #1 from Nikolay Sivov  2011-12-19 14:00:39 CST ---
Attach +trackbar log please (if I correctly understood what slider is).

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #2 from Pavel Ondračka  2011-12-20 04:17:47 CST ---
Created attachment 38042
  --> http://bugs.winehq.org/attachment.cgi?id=38042
+trackbar log

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Nikolay Sivov  2012-02-12 14:46:48 CST ---
I can confirm this running 1.4-rc3.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #4 from Nikolay Sivov  2012-02-12 16:16:03 CST ---
Created attachment 38840
  --> http://bugs.winehq.org/attachment.cgi?id=38840
patch

It looks like application subclasses trackbar, some messages including WM_PAINT
do not reach control procedure.

Call order:

- control procedure called with WM_MOUSEMOVE;
- position is updated and notification sent with TB_THUMBTRACK;
- application does TBM_GETPOS during notification (seems to work);
- during WM_PAINT handling application sends TBM_GETTHUMBRECT,
  but rectangle is not updated at this point cause we update it only in
  WM_PAINT handler in TRACKBAR_Refresh(). So application always get the same
  rectangle, that's what you see when slider is standing still.

Attached simple patch shows how this should be fixed, it's incomplete of course
and needs tests.

Could you confirm it works for you?

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #5 from Pavel Ondračka  2012-02-13 03:40:51 CST ---
(In reply to comment #4)
> Created attachment 38840 [details]
> patch
>
> It looks like application subclasses trackbar, some messages including WM_PAINT
> do not reach control procedure.
>
> Call order:
> - control procedure called with WM_MOUSEMOVE;
> - position is updated and notification sent with TB_THUMBTRACK;
> - application does TBM_GETPOS during notification (seems to work);
> - during WM_PAINT handling application sends TBM_GETTHUMBRECT,
> but rectangle is not updated at this point cause we update it only in
> WM_PAINT handler in TRACKBAR_Refresh(). So application always get the same
> rectangle, that's what you see when slider is standing still.
>
> Attached simple patch shows how this should be fixed, it's incomplete of course
> and needs tests.
>
> Could you confirm it works for you?

Your patch works when I drag the slider, however when I just click a new
position it still doesn't work.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #6 from Nikolay Sivov  2012-02-13 03:42:41 CST ---
(In reply to comment #5)
> Your patch works when I drag the slider, however when I just click a new
> position it still doesn't work.

That's expected, that's why I said it's incomplete. Thanks for testing.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #7 from Nikolay Sivov  2012-03-12 12:17:13 CDT ---
First patch is in as 3d4a4dae700698bcd68631d6dd38ddb0a4e3f60f. Will send
something similar for other cases soon.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3d4a4dae700698bcd68631d6dd3
                   |                            |8ddb0a4e3f60f
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Nikolay Sivov  2012-03-13 14:18:39 CDT ---
Another fix got in as f296c84feb94b8bb7f2194c77356c0b86decd9b9. This works fine
for me now, feel free to reopen if it's not fully fixed for you.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

--- Comment #9 from Alexandre Julliard  2012-03-16 14:07:59 CDT ---
Closing bugs fixed in 1.5.0.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2012-03-16 17:10:47 CDT ---
Really closing bugs fixed in 1.5.0.

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

http://bugs.winehq.org/show_bug.cgi?id=28962

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---

[Bug 28962] Mount & Blade: WFAS texture quality slider isn't moving

https://bugs.winehq.org/show_bug.cgi?id=28962

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]