https://bugs.winehq.org/show_bug.cgi?id=47820
Bug ID: 47820 Summary: Magic: The Gathering Arena - custom_get_thread_return Invalid Return Code 1627 Product: Wine Version: 4.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: werifGX@gmail.com Distribution: ---
Created attachment 65324 --> https://bugs.winehq.org/attachment.cgi?id=65324 Official installer fatal err
Magic: The Gathering Arena using official installer results in: `0070:err:msi:custom_get_thread_return Invalid Return Code 1627` for https://mtgarena.downloads.wizards.com/Live/Windows32/MTGAInstaller.exe
Tested with dotnet472 using winetricks which results in same issue (screenshot)
STEPS TO REPRODUCE: 1) Download https://mtgarena.downloads.wizards.com/Live/Windows32/MTGAInstaller.exe 2) Execute `wine msiexec path/to/MTGAInstaller.exe`
Workaround is to use https://mtgarena.downloads.wizards.com/Live/Windows32/MTGAInstaller.exe which doesn't use visualstudio installer
https://bugs.winehq.org/show_bug.cgi?id=47820
Anton Romanov theli.ua@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |theli.ua@gmail.com
--- Comment #1 from Anton Romanov theli.ua@gmail.com --- this is incredibly annoying but not sure how to debug
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #2 from Anton Romanov theli.ua@gmail.com --- Looks like at some point installer wants to run a powershell script and that part fails, not sure if this can even be resolved
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #3 from Anton Romanov theli.ua@gmail.com --- Created attachment 65450 --> https://bugs.winehq.org/attachment.cgi?id=65450 installer with WINEDEBUG=msi
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #4 from Jacob Hrbek werifGX@gmail.com --- Created attachment 65747 --> https://bugs.winehq.org/attachment.cgi?id=65747 Content of MTGAInstaller.exe which is used to reproduce this issue
https://bugs.winehq.org/show_bug.cgi?id=47820
Jacob Hrbek werifGX@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msi URL| |https://mtgarena.downloads. | |wizards.com/Live/Windows32/ | |MTGAInstaller.exe Version|4.16 |4.20
https://bugs.winehq.org/show_bug.cgi?id=47820
Jacob Hrbek werifGX@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #5 from Jacob Hrbek werifGX@gmail.com --- Created attachment 65748 --> https://bugs.winehq.org/attachment.cgi?id=65748 Screenshot of the message in the installer
https://bugs.winehq.org/show_bug.cgi?id=47820
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|msi |-unknown
--- Comment #6 from Hans Leidekker hans@meelstraat.net ---
003b:trace:msi:msi_set_property 0x17c148 L"POWERSHELL_EXECUTION_LOG" L"[ERR] Could not find PowerShell!" -1
It wants to run a PowerShell script in a custom action, which fails because Wine's implementation is a stub.
Implementing PowerShell is a big task, though maybe we can use code from the open source PowerShell Core project in some way.
https://bugs.winehq.org/show_bug.cgi?id=47820
Jacob Hrbek werifGX@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |48147
https://bugs.winehq.org/show_bug.cgi?id=47820
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|48147 |
--- Comment #7 from Zebediah Figura z.figura12@gmail.com --- Not really a dependency in the intended sense.
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #8 from Jacob Hrbek werifGX@gmail.com --- (In reply to Zebediah Figura from comment #7)
Not really a dependency in the intended sense.
elaborate?
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #9 from Zebediah Figura z.figura12@gmail.com --- (In reply to Jacob Hrbek from comment #8)
(In reply to Zebediah Figura from comment #7)
Not really a dependency in the intended sense.
elaborate?
Better to implement a builtin powershell in some form. Using native components is pretty much always just a workaround as far as bug tracking is concerned.
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #10 from Anton Romanov theli.ua@gmail.com --- Imo title could be changed to reflect root cause to something like "Magic Arena installer requires powershell" or "some VS installers require powershell" that way it'll be easier to dedupe bugs for similar installers.
Also FWIW I am working on adding powershell verb that works around this to winetricks https://github.com/Winetricks/winetricks/pull/1440
https://bugs.winehq.org/show_bug.cgi?id=47820
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Magic: The Gathering Arena |Magic: The Gathering Arena |- custom_get_thread_return |installer needs |Invalid Return Code 1627 |powershell.exe | |implementation
https://bugs.winehq.org/show_bug.cgi?id=47820
Jacob Hrbek werifGX@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Magic: The Gathering Arena |Some VisualStudio |installer needs |installers require |powershell.exe |powershell |implementation |
https://bugs.winehq.org/show_bug.cgi?id=47820
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com Summary|Some VisualStudio |Magic: The Gathering Arena |installers require |installer needs |powershell |powershell.exe | |implementation
--- Comment #11 from Zebediah Figura z.figura12@gmail.com --- Until other installers are found suffering from this bug, let's please leave the application in the bug title.
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #12 from Jacob Hrbek werifGX@gmail.com --- (In reply to Zebediah Figura from comment #11)
Until other installers are found suffering from this bug, let's please leave the application in the bug title.
Understood
https://bugs.winehq.org/show_bug.cgi?id=47820
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox.xerox2000x@gmail.com
--- Comment #13 from Louis Lenders xerox.xerox2000x@gmail.com --- Created attachment 65931 --> https://bugs.winehq.org/attachment.cgi?id=65931 patch to let the installer finish
The innstaller finishes for me if wine`s stub powershell.exe is moved to the (right) directory (see patch)
0049:Call KERNEL32.FindFirstFileW(00eb60e0 L"C:\windows\SysWOW64\WindowsPowerShell\v1.0\powershell.exe",014ef084) ret=01505ba5 0049:Ret KERNEL32.FindFirstFileW() retval=ffffffff ret=01505ba5
Apparently it`s enough to move (stub) powershell.exe to that directory. Now it also shows what the installer wants from powershell:
006d:fixme:advapi:ParseStringSidToSid String constant not supported: L"CY" 006d:fixme:advapi:ParseStringSidToSid String constant not supported: L"IS" 007c:fixme:powershell:wmain stub: L"" L"-NoProfile" L"-Noninteractive" L"-ExecutionPolicy" L"Bypass" L"-File" L"C:\users\louis\Temp\pss95fc.ps1" 0080:fixme:powershell:wmain stub: L"" L"-NoProfile" L"-Noninteractive" L"-ExecutionPolicy" L"Bypass" L"-File" L"C:\users\louis\Temp\pss968b.ps1" 0088:fixme:powershell:wmain stub: L"" L"-NoProfile" L"-Noninteractive" L"-ExecutionPolicy" L"Bypass" L"-File" L"C:\users\louis\Temp\pss96e1.ps1" 005b:fixme:uxtheme:IsCompositionActive : stub
Despite of stub powershell the installer finishes and the MTGALauncher.exe is installed. Did not test further
Without the patch: 006b:fixme:advapi:ParseStringSidToSid String constant not supported: L"CY" 006b:fixme:advapi:ParseStringSidToSid String constant not supported: L"IS" 005e:err:msi:custom_get_thread_return Invalid Return Code 1627
https://bugs.winehq.org/show_bug.cgi?id=47820
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #14 from Louis Lenders xerox.xerox2000x@gmail.com --- Hi Jacob and/or Anton,
Patch from previous comment is committed in current git, the installer finishes for me here now, could you try and see if it is fixed for you?
Regards
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #15 from Jacob Hrbek werifGX@gmail.com --- (In reply to Louis Lenders from comment #14)
Hi Jacob and/or Anton,
Patch from previous comment is committed in current git, the installer finishes for me here now, could you try and see if it is fixed for you?
Regards
Sorry for a delay i will test this asap
https://bugs.winehq.org/show_bug.cgi?id=47820
Louis Lenders xerox.xerox2000x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords| |download Fixed by SHA1| |a2aa1b01f065ecf6efd6caced0c | |bdfae933d7958 Status|NEW |RESOLVED Summary|Magic: The Gathering Arena |Magic: The Gathering Arena |installer needs |installer needs |powershell.exe |powershell.exe (cannot find |implementation |it)
--- Comment #16 from Louis Lenders xerox.xerox2000x@gmail.com --- (In reply to Jacob Hrbek from comment #15)
Sorry for a delay i will test this asap
I`m resolving this as fixed. The installer finishes for me; also starting MTGA-Launcher seems to work to get up to the initial screen. please open new bugreport for other issues.
https://bugs.winehq.org/show_bug.cgi?id=47820
--- Comment #17 from Jacob Hrbek werifGX@gmail.com --- (In reply to Louis Lenders from comment #16)
(In reply to Jacob Hrbek from comment #15)
Sorry for a delay i will test this asap
I`m resolving this as fixed. The installer finishes for me; also starting MTGA-Launcher seems to work to get up to the initial screen. please open new bugreport for other issues.
Sorry for the long delay again, testing was requested when i was in the middle of the experiment and i didn't have reliable system for tests.
I put together system to test this, but the testing might not be reliable (experimental toolchain used to build wine), but the installer finishes successfully with provided patch on wine-5.0-rc3
https://bugs.winehq.org/show_bug.cgi?id=47820
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.0-rc4.
https://bugs.winehq.org/show_bug.cgi?id=47820
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x
https://bugs.winehq.org/show_bug.cgi?id=47820
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |---
--- Comment #19 from Michael Stefaniuc mstefani@winehq.org --- Removing the 4.0.x milestone from bug fixes included in 4.0.4.
https://bugs.winehq.org/show_bug.cgi?id=47820
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net URL|https://mtgarena.downloads. |https://web.archive.org/web |wizards.com/Live/Windows32/ |/20191008184549/https://mtg |MTGAInstaller.exe |arena.downloads.wizards.com | |/Live/Windows32/MTGAInstall | |er.exe