[Bug 11241] New: Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Summary: Pokerstars font is underlined in chat window.
           Product: Wine
           Version: 0.9.53.
          Platform: PC
               URL: http://www.pokerstars.com/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fonts
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=10336)
 --> (http://bugs.winehq.org/attachment.cgi?id=10336)
Screenshot of underlined font in chat.

Chat box fonts are all underlined in 0.9.53.  This bug was not present in
0.9.52 and hence is a regression bug.  I'm attaching a screenshot of 0.9.53,
don't have one for 0.9.52 but there is an older screenshot at
http://appdb.winehq.org/appimage.php?bThumbnail=true&iId=3420

This has been confirmed in the discussion at
http://appdb.winehq.org/objectManager.php?sClass=version&iId=2899

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #1 from Peter Ajamian   2008-01-18 01:37:57 ---
Oops, wrong link to screenshot, try:
http://appdb.winehq.org/appimage.php?iId=3420

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #2 from Dmitry Timoshkov   2008-01-18 09:42:52 ---
Please perform a regression test as outlined in the wiki:

http://wiki.winehq.org/RegressionTesting

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Alexander Nicolaysen Sørnes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
          Component|fonts                       |richedit
     Ever Confirmed|0                           |1

--- Comment #3 from Alexander Nicolaysen Sørnes   2008-01-18 13:07:34 ---
I think this might be related to the regression in builtin wordpad caused by
the CFM_UNDERLINE bit not being set after an EM_GETCHARFORMAT

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #4 from Alexander Nicolaysen Sørnes   2008-01-18 14:12:14 ---
Created an attachment (id=10347)
 --> (http://bugs.winehq.org/attachment.cgi?id=10347)
Proposed patch

Does the following patch help?

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #5 from Peter Ajamian   2008-01-19 18:42:31 ---
(In reply to comment #3)
> I think this might be related to the regression in builtin wordpad caused by
> the CFM_UNDERLINE bit not being set after an EM_GETCHARFORMAT

Actually it appears to be caused by Dmitry's the scaling font metrics
patch/regression fix.  My regression testing shows that it was good before
wine-0.9.52-311-g535053b and bad on and after the regression fix of
wine-0.9.52-340-g92a74a8.

During the period in between PokerStarsUpdate would fail to load and if
PokerStars was run directly (bypassing the update) then I could go to a table
and display the table but it would immediately lock up with a blank chat
window.

I will try Alexander's proposed patch next.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #6 from Peter Ajamian   2008-01-19 19:12:33 ---
(In reply to comment #4)
> Created an attachment (id=10347)

--> (http://bugs.winehq.org/attachment.cgi?id=10347) [details]
> Proposed patch
>
> Does the following patch help?

Nope, fonts are still underlined.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Peter Ajamian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Peter Ajamian   2008-01-19 19:22:45 ---
Adding CC to Dmitry just to make sure he's getting these (I wasn't sure if he
was still after Alex took over).  Note comment #5 with regression testing
results.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #8 from Dmitry Timoshkov   2008-01-19 22:27:48 ---
What is the best/shortest way to reproduce the problem?

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #9 from Peter Ajamian   2008-01-19 22:39:13 ---
(In reply to comment #8)
> What is the best/shortest way to reproduce the problem?

Download the pokerstars client from http://www.pokerstars.com/ and install. 
You don't need to log in (which means you don't to create an account), just
observe a table and you'll see the underlines in the chat.

You may also want to install arial and tohoma fonts, I haven't checked to see
if the bug shows up without them.  I don't think you'll need any other
workarounds or tweaks to see the bug, but in case you do they're shown at
http://appdb.winehq.org/objectManager.php?sClass=version&iId=2899

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #10 from Peter Ajamian   2008-01-20 01:12:42 ---
One more thing.  The install will create a desktop launcher to run
PokerStarsUpdate.exe which checks for updates and then runs PokerStars.exe. 
You can just run PokerStars.exe directly and skip the update step saving you
that bit of time in launching the program each time for testing.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #11 from Dmitry Timoshkov   2008-01-20 07:22:35 ---
The following patch should fix the regression:

http://www.winehq.org/pipermail/wine-patches/2008-January/049214.html

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Alexander Nicolaysen Sørnes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|richedit                    |gdi32

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Dan Kegel   2008-01-20 15:06:12 ---
*** Bug 11283 has been marked as a duplicate of this bug. ***

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #13 from Dan Kegel   2008-01-20 15:07:01 ---
That patch fixed a regression in Photoshop 7 (bug 11283) so it
seems likely it'll help this too.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Jaime Rave   2008-01-20 20:52:52 ---
This can be related to the bug 11159 also.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #15 from Peter Ajamian   2008-01-20 22:32:25 ---
Tested, problem is fixed with wine-0.9.53-155-g3471f84 + patch.  So this should
get into 0.9.54?

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #16 from Dmitry Timoshkov   2008-01-20 22:43:06 ---
Once it's committed to git - yes.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #17 from Peter Ajamian   2008-01-20 22:53:12 ---
Excellent, thanks Dmitry!

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Dmitry Timoshkov   2008-01-21 06:09:45 ---
The patch has been committed.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

--- Comment #19 from Peter Ajamian   2008-01-21 09:13:53 ---
Tested latest git and it works great.  Thanks again Dmitry.

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

feydreva  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from feydreva   2008-01-22 13:26:14 ---
*** Bug 11302 has been marked as a duplicate of this bug. ***

[Bug 11241] Pokerstars font is underlined in chat window.

http://bugs.winehq.org/show_bug.cgi?id=11241

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Dan Kegel   2008-01-28 06:11:32 ---
Closing all RESOLVED FIXED bugs older than 0.9.54.