[Bug 13595] New: DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

Summary: DirectX : Sprite borders are 1 pixel lower in Double
                    Dragon Forever
           Product: Wine
           Version: 1.0-rc3
          Platform: PC-x86-64
               URL: http://clebercasali.blogspot.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=13561)
 --> (http://bugs.winehq.org/attachment.cgi?id=13561)
Notice the purple line below the sprite. This is not seen on windows.

The game is programmed in DarkBASIC Pro. It uses Direct3D to draw the sprites.
It must be a problem in the way wine stores or draws the textures.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #1 from cleber   2008-06-01 12:44:12 ---
Created an attachment (id=13562)
 --> (http://bugs.winehq.org/attachment.cgi?id=13562)
This is the expected behaviour.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #2 from cleber   2008-06-01 12:45:17 ---
Created an attachment (id=13563)
 --> (http://bugs.winehq.org/attachment.cgi?id=13563)
This is the sprite sheet, so one can see where the purple lines comes from.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

cleber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DirectX : Sprite borders are|DirectX : Sprite borders are
                   |1 pixel lower in Double     |1 pixel lower in Double
                   |Dragon Forever              |Dragon Forever ( ddf )

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

cleber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cleberdemattoscasali-
                   |                            |[e-mail]

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #3 from cleber   2008-07-25 21:40:56 ---
This one is still present in wine 1.1.2.
I don't think it's trivial. It's a problem with directx, probably with
textures. It may be causing problems in other games as well, like trying to
access data outside the image boundaries.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #4 from cleber   2008-07-31 18:31:23 ---
Created an attachment (id=15196)
 --> (http://bugs.winehq.org/attachment.cgi?id=15196)
Test program

This is a very simple test program to demonstrate the bug. Native d3dx9_28.dll
is required.
In windows, the image is shown as expected. In wine, the image is displayed
missing the first line of pixels, and the last line shows some pixels from the
missing first line, and some garbage.
According to my tests, it happens in offscreen drawing.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #5 from cleber   2008-07-31 18:33:18 ---
Created an attachment (id=15197)
 --> (http://bugs.winehq.org/attachment.cgi?id=15197)
Source of the test program (DarkBASIC)

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #6 from cleber   2008-07-31 18:35:05 ---
Created an attachment (id=15198)
 --> (http://bugs.winehq.org/attachment.cgi?id=15198)
Source of the test program (DarkBASIC)

oops. The previous one is wrong.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #7 from cleber   2008-07-31 18:51:05 ---
After a lot of research...

It goes like that:

1) My program loads the bitmap (big) and makes a big texture of it

2) It creates a smaller offscreen buffer

3) The big texture is pasted to the offscreen buffer, using determined
horizontal and vertical offsets. So, this offscreen buffer will contain only a
portion of our big texture image

4) The data from the offscreen buffer is used to generate a new smaller
texture, that will be used as a sprite frame

5) Program changes the offsets, and goes to 3 again. It will not stop until all
sprite frames are created.

The bug happens on step (3). The vertical offset is wrong. Wine's directx just
pastes the image one line higher than windows' directx.

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

Fernando Martins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Fernando Martins   2009-04-01 13:36:14 ---
bug still present on 1.1.18

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

RD  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from RD   2009-06-17 17:57:57 ---
I can confirm this bug is also present in wine v1.1.20

A current workaround is to add borderfix=1 to the ddragonf.ini file noted here:

http://doubledragon.classicgaming.gamespy.com/forums/viewtopic.php?p=1165#11...

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #10 from RD   2009-07-07 16:30:54 ---
bug still present on 1.1.25

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

RD  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #11 from RD   2009-07-07 16:31:34 ---
*** This bug has been confirmed by popular vote. ***

[Bug 13595] DirectX : Sprite borders are 1 pixel lower in Double Dragon Forever ( ddf )

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #12 from landeel   2010-04-15 15:05:37 ---
Wine 1.1.41.
Bug 14558 is fixed, but this one is still there.

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DirectX : Sprite borders    |Sprite borders are 1 pixel
                   |are 1 pixel lower in Double |lower in Double Dragon
                   |Dragon Forever ( ddf )      |Forever

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

landeel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://clebercasali.blogspo |http://cmcgames.blogspot.co
                   |t.com                       |m

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

landeel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

--- Comment #13 from landeel  2010-10-16 11:25:58 CDT ---
This is fixed since wine 1.3.4
Congratulations wine team!!! Wine rocks!!!

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Dmitry Timoshkov  2010-10-16 11:43:42 CDT ---
Reported fixed.

[Bug 13595] Sprite borders are 1 pixel lower in Double Dragon Forever

http://bugs.winehq.org/show_bug.cgi?id=13595

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2010-10-29 12:58:06 CDT ---
Closing bugs fixed in 1.3.6.