[Bug 53101] New: Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

Bug ID: 53101
           Summary: Public Peer silently exits
           Product: Wine
           Version: 7.10
          Hardware: x86-64
               URL: https://web.archive.org/web/20110710185832if_/http://l
                    astmile.gomez.com/PEERInstall.exe
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: db9b7b0f511197255d0cbe81605a42e34bf630d6
      Distribution: Ubuntu

Created attachment 72533
  --> https://bugs.winehq.org/attachment.cgi?id=72533
Wine 7.9 +x11drv +x11settings +imm

Public Peer (formerly Gómez Peer) exits silently on run since commit
db9b7b0f511197255d0cbe81605a42e34bf630d6.

commit db9b7b0f511197255d0cbe81605a42e34bf630d6
Author: Jacek Caban 
Date:   Tue Apr 19 15:31:41 2022 +0200

winex11: Use TEB to store driver thread data.

Signed-off-by: Jacek Caban 
    Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

Log-in not required and the service is down, but the app can still be tested.

On a successful run you are asked to enter your username, which isn't verified
so can be anything.

Console output:
0080:fixme:imm:ImeSetActiveContext (0x34c160, 0): stub
0080:fixme:imm:ImmReleaseContext (00010020, 0034C160): stub

[Bug 53101] Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |26549, 26550, 31517

[Bug 53101] Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

--- Comment #1 from Sven Baars  ---
This is caused by TlsGetValue previously calling SetLastError( ERROR_SUCCESS );
in X11DRV_MsgWaitForMultipleObjectsEx. The program starts working again by
calling RtlSetLastWin32Error( ERROR_SUCCESS ); from
X11DRV_MsgWaitForMultipleObjectsEx. That doesn't strike me as a proper fix
though.

[Bug 53101] Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

--- Comment #2 from Jacek Caban  ---
Yes, X11DRV_MsgWaitForMultipleObjectsEx should not modify last error, the
commit made it work more similar to Windows. The application actually depends
on Shell_NotifyIconA modifying the last error (which internally uses inter
process SendMessage, triggering X11DRV_MsgWaitForMultipleObjectsEx). I will
send a patch.

[Bug 53101] Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9e351472dd5fc7a9ceb0aacaadf
                   |                            |d431ea38a974e
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jacek Caban  ---
Fixed in git:
https://gitlab.winehq.org/wine/wine/-/commit/9e351472dd5fc7a9ceb0aacaadfd431...

Thanks for the report.

[Bug 53101] Public Peer silently exits

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53101

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc3.