https://bugs.winehq.org/show_bug.cgi?id=55720
Bug ID: 55720 Summary: msxml3:domdoc - test_domnode() fails in Wine Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: msxml3 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com Distribution: ---
msxml3:domdoc - test_domnode() fails in Wine:
domdoc.c:2521: Test failed: Unexpected hr 0x1.
See https://test.winehq.org/data/patterns.html#msxml3:domdoc
This does not happen in all test configurations. In particular it does not happen on any of the TestBot VMs (or my VMs), but it is systematic on the GitLab CI and Remi's Linux cloud machines.
A look at the commits shows that this failure was introduced by the commit below. The failure even showed up in the GitLab CI's pipeline but MR!4004 got merged anyway.
https://gitlab.winehq.org/wine/wine/-/merge_requests/4004/pipelines
commit 0770ba61ceb81794e5d03b6d6c48597d1b67c7ae Author: Alistair Leslie-Hughes leslie_alistair@hotmail.com Date: Tue Oct 3 17:08:16 2023 +1100
msxml3: IXMLDOMElement::selectSingleNode always assign a value to the output parameter.
https://bugs.winehq.org/show_bug.cgi?id=55720
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |0770ba61ceb81794e5d03b6d6c4 | |8597d1b67c7ae CC| |leslie_alistair@hotmail.com Keywords| |regression, source, | |testcase
https://bugs.winehq.org/show_bug.cgi?id=55720
--- Comment #1 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- The failure of the CI is strange. I'm not able to reproduce it locally or as stated on the Testbox VM's.
The basics are that XSLPattern_to_XPath fails to parse the string (correctly) which returns the original string. The string is then passed in to xmlXPathEvalExpression and for some reason it returns it as a valid query.
Next it attempts to find the first element, which doesn't exist, thus the S_FALSE return value.
The questions. 1. Does the CI build use local libxml or wine builtin? 2. Is the CI using mingw/gcc/clang/other?
https://bugs.winehq.org/show_bug.cgi?id=55720
--- Comment #2 from François Gouget fgouget@codeweavers.com --- 1. I don't think one can use anything but the builtin PE libs/xml2 library. Also the Linux libxml2 library is not installed in the build environment.
Note also that on can find the binaries that the GitLab CI uses to run the tests in the artifacts of the build-daily-linux jobs on Wine's pipeline page: https://gitlab.winehq.org/wine/wine/-/pipelines
artifacts.zip actually contains a zip of the /usr/local tree and there is no trace of linking to a native libxml2 library.
2. The GitLab CI uses gcc. See tools/gitlab/image.docker for the list of build tools it uses.
https://bugs.winehq.org/show_bug.cgi?id=55720
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |60e8b78e4d232c09818b4a2b797 | |7a3841df84338
--- Comment #3 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Fixed by https://gitlab.winehq.org/wine/wine/-/commit/60e8b78e4d232c09818b4a2b7977a38...
https://bugs.winehq.org/show_bug.cgi?id=55720
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.19.
-
WineHQ Bugzilla