[Bug 50845] New: jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Bug ID: 50845
           Summary: jscript crashes on internal assert(0) in PE build with
                    clang
           Product: Wine
           Version: 6.4
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: jscript
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

Jacek, adding you to cc:, you might be interested.

This doesn't happen in an ELF build.

In order to reproduce build Wine in PE with clang, and run 'make test' in
dlls/jscript/tests:

Assertion failed: 0, file ../wine/dlls/jscript/jsutils.c, line 245

This the result of the call
hres = jsdisp_define_data_property(ctx->global, L"NaN", const_flags,
jsval_number(NAN));
https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/jscript/global.c#l111...
during initialization, no user provided script is even gets started being
interpreted.

It seems that the reason is difference in 'struct _jsval_t' layout
https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/jscript/jsval.h#l54
between gcc and clang.

$ clang --version
clang version 11.0.0
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

--- Comment #1 from Dmitry Timoshkov  ---
The problem is caused by difference in the code, generated by clang and gcc for
jsdisp_define_data_property() for storing the jsval_t value: clang generates 
fldl + fstpl while gcc uses ordinal movl instructions.

That leads to the following (with additional debug output):

clang:

0024:err:jscript:init_global NAN: v = 7ff00000ffffffff => tag 0x7ff00000,
jsval_type() = 0x7ff80005
1: NaN: 7ff8000000000000 => tag 0x7ff80000, jsval_type() = 0x7ff80000
2: NaN: 7ff00000ffffffff => tag 0x7ff00000, jsval_type() = 0x7ff80005
0024:err:jscript:jsdisp_define_property L"NaN", v = 7ff80000ffffffff => tag
0x7ff80000, jsval_type() = 0x7ff80000
0024:err:jscript:jsval_copy v = 7ff80000ffffffff => tag 0x7ff80000,
jsval_type() = 0x7ff80000
Assertion failed: 0, file ../wine.src/dlls/jscript/jsutils.c, line 247

gcc:

0024:err:jscript:init_global NAN: v = 7ff00000ffffffff => tag 0x7ff00000,
jsval_type() = 0x7ff80005
1: NaN: 7ff8000000000000 => tag 0x7ff80000, jsval_type() = 0x7ff80000
2: NaN: 7ff00000ffffffff => tag 0x7ff00000, jsval_type() = 0x7ff80005
0024:err:jscript:jsdisp_define_property L"NaN", v = 7ff00000ffffffff => tag
0x7ff00000, jsval_type() = 0x7ff80005
0024:err:jscript:jsval_copy v = 7ff00000ffffffff => tag 0x7ff00000,
jsval_type() = 0x7ff80005

Adding 'ULONGLONG ull;' to struct _jsval_t definition forces clang to use movl
instead of fldl + fstpl like gcc does, and fixes the problem.

I'll attach the diff here.

Jacek, what do you think? Is that an acceptable solution? Is there a concern
that there might be more places in Wine that suffer from the same problem?

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

--- Comment #2 from Dmitry Timoshkov  ---
Created attachment 69665
  --> https://bugs.winehq.org/attachment.cgi?id=69665
tentative ifx

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69665|tentative ifx               |tentative fix
        description|                            |

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
https://source.winehq.org/patches/data/203239

this was merged.

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |d9a4392d6bbd50b0a9690aa20fe
                   |                            |7baa199f38d96

--- Comment #4 from Dmitry Timoshkov  ---
Confirming fixed by d9a4392d6bbd50b0a9690aa20fe7baa199f38d96.

Thanks Jacek.

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 6.6.

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0.x

[Bug 50845] jscript crashes on internal assert(0) in PE build with clang

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50845

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|6.0.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing the 6.0.x milestone from bug fixes included in 6.0.2.