[Bug 16087] New: wine spews innumerable "Unable to check compatibility for Format..." errors in some games
http://bugs.winehq.org/show_bug.cgi?id=16087
Summary: wine spews innumerable "Unable to check compatibility for Format..." errors in some games Product: Wine Version: 1.1.8 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: trivial Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: bogdanb+bugs.winehq.org@gmail.com
Created an attachment (id=17312) --> (http://bugs.winehq.org/attachment.cgi?id=17312) avoids silly error messages
In dlls/wined3d/directx.c there is a function called IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt which tries to compute if a certain WINED3DFORMAT is compatible with a certain WineD3D_PixelFormat.
The function has separate paths for WGL_TYPE_RGBA_ARB (integer) and WGL_TYPE_RGBA_FLOAT_ARB (float) WineD3D_PixelFormats. The float path explicitly tests several WINED3DFORMATs, which seems OK. The integer part, however, tries getColorBits() on the WINED3DFORMAT and prints an error if it doesn't get a "correct" answer.
However, getColorBits() always throws an error for float formats, thus when comparing an integer WineD3D_PixelFormat with a float WINED3DFORMAT the function always outputs two errors instead of just saying "no".
The attached patch checks if the format is one where getColorBits works and avoids spewing the error messages is that case. This duplicates the check in getColorBits, so it's a bit of a hack, but a correct fix would need adding a few more functions, so someone more experienced should do it. The patch is against 1.1.8.
Fallout3 in particular is plagued by this problem: at every start-up wine spews out errors for half a minute.
http://bugs.winehq.org/show_bug.cgi?id=16087
bogdanb bogdanb+bugs.winehq.org@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #17312|0 |1 is obsolete| |
--- Comment #1 from bogdanb bogdanb+bugs.winehq.org@gmail.com 2008-11-16 11:33:22 --- Created an attachment (id=17313) --> (http://bugs.winehq.org/attachment.cgi?id=17313) avoids silly error messages
The previous patch contained a thinko, sorry.
http://bugs.winehq.org/show_bug.cgi?id=16087
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Austin English austinenglish@gmail.com 2008-11-16 15:16:18 --- Please send patches to wine-patches@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #3 from bogdanb bogdanb+bugs.winehq.org@gmail.com 2008-11-17 13:36:18 --- I did, but isn't that a bit redundant?
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #4 from Austin English austinenglish@gmail.com 2008-11-17 14:22:05 --- (In reply to comment #3)
I did, but isn't that a bit redundant?
Patches in bugzilla aren't picked up for inclusion in the main tree.
Be sure to send it in git diff format.
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #5 from Sigurdur J. sigurdur.jo@gmail.com 2008-12-31 18:25:18 --- Created an attachment (id=18356) --> (http://bugs.winehq.org/attachment.cgi?id=18356) wine fallout3.exe output
Still getting this on Fallout 3 with 1.1.11 It spews out over 10000 lines of this, then exits without a peep.
http://bugs.winehq.org/show_bug.cgi?id=16087
Flash aleksey.kamenskikh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #6 from Flash aleksey.kamenskikh@gmail.com 2009-01-10 04:59:49 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #7 from Austin English austinenglish@gmail.com 2009-07-21 14:03:47 --- Is this still an issue in current (1.1.26 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=16087
Mikael Åkersund mikael.akersund@bigfoot.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikael.akersund@bigfoot.com
--- Comment #8 from Mikael Åkersund mikael.akersund@bigfoot.com 2009-07-23 11:51:02 --- (In reply to comment #7)
Is this still an issue in current (1.1.26 or newer) wine?
Yes. Tried with wine-git as of 2009-07-23. Last commit according to git log was: c6570a50f89b20a652e37530cca01991eb57d7d6 winex11: Make X11DRV_SetupGCForPatBlt independent of screen_depth(In reply to comment #7)
Is this still an issue in current (1.1.26 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=16087
Elmo Mäntynen elmo13@jippii.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |elmo13@jippii.fi
--- Comment #9 from Elmo Mäntynen elmo13@jippii.fi 2010-01-02 00:15:59 --- Still a problem with 1.1.35
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #10 from no one lycanos@hotmail.com 2010-03-10 12:38:45 --- Created an attachment (id=26732) --> (http://bugs.winehq.org/attachment.cgi?id=26732) system info and error outputs
Note there are too many lines of errors not all lines were stored in terminal for me to copy.
http://bugs.winehq.org/show_bug.cgi?id=16087
no one lycanos@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lycanos@hotmail.com
--- Comment #11 from no one lycanos@hotmail.com 2010-03-10 12:39:48 --- Also occurs with: wine 1.0.0.1 wine 1.1.36 wine 1.1.38
Both the GOTY edition and the 1.7 patched version Fallout 3 (1.7 patch may also change Securom and cause other errors)
Fallout 3 then tries to run FalloutLauncher.exe and faults.
(Also see above attachment)
http://bugs.winehq.org/show_bug.cgi?id=16087
--- Comment #12 from Austin English austinenglish@gmail.com 2010-07-05 20:44:35 --- Seems fine for me in 1.2-rc6.
http://bugs.winehq.org/show_bug.cgi?id=16087
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #13 from Austin English austinenglish@gmail.com 2010-07-05 21:08:41 --- (In reply to comment #12)
Seems fine for me in 1.2-rc6.
Fixed.
http://bugs.winehq.org/show_bug.cgi?id=16087
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org 2010-07-09 11:56:57 --- Closing bugs fixed in 1.2-rc7.
-
wine-bugs＠winehq.org