[Bug 28708] New: gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

Bug #: 28708
           Summary: gdiplus/tests/image.ok: test_fromhicon triggers
                    reference of uninitialized variable from SetDIBits
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Running "make image.ok" in gdiplus/tests, Valgrind complains:

Conditional jump or move depends on uninitialised value(s)
   at colorref_to_pixel_colortable (primitives.c:1088)
   by convert_to_1 (primitives.c:2903)
   by convert_bitmapinfo (dc.c:293) 
   by SetDIBits (dib.c:594)
   by nulldrv_StretchDIBits (dib.c:443)
   by StretchDIBits (dib.c:474)
   by stretch_blt_icon (cursoricon.c:2077)
   by CreateIconIndirect (cursoricon.c:2135)
   by test_fromhicon (image.c:1167)
   by func_image (image.c:2583)
   by run_test (test.h:556)
   by main (test.h:624)
 Uninitialised value was created by a stack allocation
   at SetDIBits (dib.c:503)

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #1 from Dan Kegel  2011-10-15 16:33:51 CDT ---
Seeing something similar in "make cursoricon.ok" in user32:

Conditional jump or move depends on uninitialised value(s)
   at rgb_to_pixel_colortable (primitives.c:1103)
   by convert_to_1 (primitives.c:3213)
   by convert_bitmapinfo (dc.c:293) 
   by SetDIBits (dib.c:603)
   by nulldrv_StretchDIBits (dib.c:443)
   by StretchDIBits (dib.c:474)
   by CopyImage (cursoricon.c:2832)
   by test_CopyImage_Check (cursoricon.c:485)
   by test_CopyImage_Bitmap (cursoricon.c:604)
   by func_cursoricon (cursoricon.c:2481)
   by run_test (test.h:556)
   by main (test.h:624)
 Uninitialised value was created by a stack allocation
   at SetDIBits (dib.c:503)

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

Huw Davies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Huw Davies  2011-10-21 05:33:48 CDT ---
Is this still an issue?

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #3 from Dan Kegel  2011-10-21 07:22:32 CDT ---
Yes, it shows up in current git, rather often:
$ grep 28708 */tests/test.log
gdiplus/tests/test.log:--19509-- used_suppression:    256 wine_bug_28708
user32/tests/test.log:--25100-- used_suppression:    112 wine_bug_28708

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #4 from Huw Davies  2011-10-21 07:28:24 CDT ---
Can you post the updated backtraces then? (nulldrv_StretchDIBits no longer
calls SetDIBits... )

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #5 from Dan Kegel  2011-10-21 08:01:37 CDT ---
256 errors in context 1 of 1:
Conditional jump or move depends on uninitialised value(s) 
   at rgb_to_pixel_colortable (primitives.c:1148)
   by convert_to_1 (primitives.c:3158)
   by convert_bitmapinfo (dc.c:293) 
   by convert_bits (bitblt.c:179)
   by nulldrv_StretchDIBits (dib.c:504)
   by StretchDIBits (dib.c:547)
   by stretch_blt_icon (cursoricon.c:2077)
   by CreateIconIndirect (cursoricon.c:2135)
   by test_fromhicon (image.c:1167)
   by func_image (image.c:2584)
   by run_test (test.h:556)
   by main (test.h:624)
 Uninitialised value was created by a stack allocation
   at StretchDIBits (dib.c:531)

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #6 from Huw Davies  2011-10-21 11:06:48 CDT ---
commit f53d73a017a4ca5682f6ae6d216d71828488eb21 should help.

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

http://bugs.winehq.org/show_bug.cgi?id=28708

--- Comment #7 from Bruno Jesus  2013-01-30 07:33:14 CST ---
Dan, is this still an issue? As Huw says it's possibly fixed by the commit in
the previous message.

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

https://bugs.winehq.org/show_bug.cgi?id=28708

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Austin English  ---
That error is fixed in git.

[Bug 28708] gdiplus/tests/image.ok: test_fromhicon triggers reference of uninitialized variable from SetDIBits

https://bugs.winehq.org/show_bug.cgi?id=28708

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.18.