[Bug 47350] New: Winecfg crashes on exit (macOS wine built without mingw)

https://bugs.winehq.org/show_bug.cgi?id=47350

Bug ID: 47350
           Summary: Winecfg crashes on exit (macOS wine built without
                    mingw)
           Product: Wine
           Version: 4.10
          Hardware: x86-64
                OS: Mac OS X
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 60df3b14b5e9c94c3b12f959cc71c492caedd647

Created attachment 64685
  --> https://bugs.winehq.org/attachment.cgi?id=64685
backtrace

The issues started with e4e2e8e551b1778ad434a4c013a91bc41b20e947
> From that commit until 60df3b14b5e9c94c3b12f959cc71c492caedd647 winecfg crashed

on start, after the latter, winecfg still crashes at exit.

I couldn't reproduce this issue on Linux and also not on macOS when building
with mingw.

I've attached the backtrace I got, there was no other output.

I'm running macOS High Sierra.

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

https://bugs.winehq.org/show_bug.cgi?id=47350

--- Comment #1 from Gijs Vermeulen  ---
Forgot to mention that this only happens in a 64bit prefix.

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

https://bugs.winehq.org/show_bug.cgi?id=47350

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Piotr Caban  ---
I don't know if it's related to this bug but in my builds (64-bit, clang)
arguments are passed incorrectly to wmain because -mabi=ms is not supported.
E.g. after starting `wine uninstaller --list` the --list argument is ignored
(negative count of arguments) or the application crashes.

This is unrelated but probably also worth mentioning - in mingw builds strip
removes information if dll is builtin. So after running e.g.
`i686-w64-mingw32-strip kernelbase.dll` wine fails to start.

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

https://bugs.winehq.org/show_bug.cgi?id=47350

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Stefan Dösinger  ---
I can confirm this issue on Mac OS, 64 bit Wine built with Xcode 10.3 and
--without-mingw. In my case I noticed it because net.exe couldn't be persuaded
to do anything except write the usage text. The parameters passed to wmain()
contained garbage.

Should we mark all those wmain functions as CDECL?

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47350

--- Comment #4 from Alexandre Julliard  ---
Is this still broken?

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47350

--- Comment #5 from Gijs Vermeulen  ---
(In reply to Alexandre Julliard from comment #4)
> Is this still broken?

This particular one was fixed by ed6a5e97e055fe8dcf424f2b20a8f3accef86a7c

There are, however, still a few issues when compiling without mingw.

1) There is a wineboot crash when creating a new prefix. Winecfg still opens.
2) There is a crash when clicking the "Audio" tab of winecfg.

IIRC these didn't happen for me when compiling without mingw on Linux. I'll
double check that.

Should I create different reports for these or should we keep it in this one?

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47350

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |ed6a5e97e055fe8dcf424f2b20a
                   |                            |8f3accef86a7c
         Resolution|---                         |FIXED

--- Comment #6 from Alexandre Julliard  ---
Marking fixed then.

Yes, please create new bugs for the other issues.

[Bug 47350] Winecfg crashes on exit (macOS wine built without mingw)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47350

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 5.0-rc2.