[Bug 21553] New: ntdll reporting freed block to valgrind twice?

http://bugs.winehq.org/show_bug.cgi?id=21553

Summary: ntdll reporting freed block to valgrind twice?
           Product: Wine
           Version: 1.1.37
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ntdll
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

http://kegel.com/wine/valgrind/logs/2010-01-29-20.52/diff-avifil32_api.txt
shows
 Invalid free() / delete / delete[]
    at  notify_free (heap.c:262)
    by  subheap_notify_free_all (heap.c:286)
    by  RtlDestroyHeap (heap.c:1608)
    by  HeapDestroy (heap.c:164)
I've got a funny feeling that the block was reported
freed once in RtlFreeHeap at line 1747, and again
in subheap_notify_free_all at line 286.  Maybe line
286 should be surrounded by
if (pArena->magic != ARENA_PENDING_MAGIC).

[Bug 21553] ntdll reporting freed block to valgrind twice?

http://bugs.winehq.org/show_bug.cgi?id=21553

--- Comment #1 from Dan Kegel   2010-01-30 13:42:06 ---
Created an attachment (id=25968)
 --> (http://bugs.winehq.org/attachment.cgi?id=25968)
Draft patch to avoid extra notification

The patch seems to do the trick in light testing.

[Bug 21553] ntdll reporting freed block to valgrind twice?

http://bugs.winehq.org/show_bug.cgi?id=21553

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Nikolay Sivov   2010-02-01 09:15:43 ---
Looks fixed by commit 156d66ec24f93657e3001d5ba4ea2e4cf5ffd248.

[Bug 21553] ntdll reporting freed block to valgrind twice?

http://bugs.winehq.org/show_bug.cgi?id=21553

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard   2010-02-05 11:39:25 ---
Closing bugs fixed in 1.1.38.