[Bug 35533] New: Make it possible to see the sent patch files inline without extra download step
http://bugs.winehq.org/show_bug.cgi?id=35533
Bug ID: 35533 Summary: Make it possible to see the sent patch files inline without extra download step Product: Wine-Testbot Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: unknown Assignee: wine-bugs@winehq.org Reporter: dmitry@baikal.ru Classification: Unclassified
Currently clicking on a patch file attached to a job leads to a save file dialog, it would be preferable (at least to me) to be able to see it inline.
https://bugs.winehq.org/show_bug.cgi?id=35533
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget@codeweavers.com
--- Comment #1 from François Gouget fgouget@codeweavers.com ---
From WineConf:
The reason for the multiple steps is that once the file has been uploaded the TestBot analyzes it and figures out the command line, showing it to the user and letting him change it if appropriate.
Dmitry contends that going through all three screens is way too long. He'd rather have a way to go with all the defaults from the first screen.
We would however have to retain a way to customize the VM set and the test command/settings, resulting in two code paths.
https://bugs.winehq.org/show_bug.cgi?id=35533
--- Comment #2 from François Gouget fgouget@codeweavers.com --- Sorry, the previous comment was for another bug (and redundant). Dmitry feels that it's probably just a matter of tweaking the MIME type.
https://bugs.winehq.org/show_bug.cgi?id=35533
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jactry92@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=35533
--- Comment #3 from François Gouget fgouget@codeweavers.com --- I remember playing with the MIME type at the time to try and get the patch to simply open in the browser as a text file but with the differing behavior between browsers I could not obtain anything that made sense. Maybe someone else would have more luck.
Another option, the one preferred by Dmitry I believe, would be to display the patch inline in the page, something like click on the [+] and here's the patch. That would require escaping. Bonus points for color highlighting and avoiding a page reload. But there would still need to be a way to download the raw patch so one can apply it locally.
https://bugs.winehq.org/show_bug.cgi?id=35533
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #4 from Zebediah Figura z.figura12@gmail.com --- Page currently reports text/plain. Possibly this should be patch/x-diff (although probably not), but regardless I think this is really the browser's/configuration's job.
An inline view the same way we have for attachments in the bugzilla might be nice.
https://bugs.winehq.org/show_bug.cgi?id=35533
--- Comment #5 from François Gouget fgouget@codeweavers.com --- On the JobDetails page one can download two types of files: * Patches * The resulting Windows executables (or those uploaded by the developer).
GetFile.pl used to indiscriminately return application/octet-stream. Now it sets the MIME type to test/plain for patches so the browser typically offers opening them in a text editor (at least that's what happens in Firefox).
It's maybe not quite as nice as viewing the patch inline but it's still better than the previous situation.
commit 6dde8de8257a1333a8951a0e6cd11f5f41e01d80 Author: Francois Gouget fgouget@codeweavers.com Date: Tue Jun 26 13:40:47 2018 +0200
testbot/web: Adjust the GetFile MIME type based on Step->FileType.
This lets the browser offer to open the patches in a text editor instead of systematically suggesting to save them to disk.
Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=35533
--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to François Gouget from comment #5)
On the JobDetails page one can download two types of files:
- Patches
- The resulting Windows executables (or those uploaded by the developer).
GetFile.pl used to indiscriminately return application/octet-stream. Now it sets the MIME type to test/plain for patches so the browser typically offers opening them in a text editor (at least that's what happens in Firefox).
I have two browsers in my Linux system: Firefox 52.8.0 (64-bit) and Chromium version 61.0.3163.100 (64-bit). After going for instance to the following URL https://testbot.winehq.org/JobDetails.pl?Key=39460 in both browsers and clicking patch.diff Firefox does show an "Open file with..." dialog and after choosing the text editor the file gets opened in the editor. However Chromium still suggests only to save the file to disk.
It's maybe not quite as nice as viewing the patch inline but it's still better than the previous situation.
I'm sorry, but no, it's not better in any way. It's ugly and unusable. For a comparison just see how Wine bugzilla manages the text attachments.
-
wine-bugs＠winehq.org