[Bug 16550] New: ConnectNamedPort should never return OK in overlapped mode

http://bugs.winehq.org/show_bug.cgi?id=16550

Summary: ConnectNamedPort should never return OK in overlapped
                    mode
           Product: Wine
           Version: 1.1.10
          Platform: Other
               URL: http://chromium.org
        OS/Version: other
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Chromium contains the following code in 
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/ipc_channel_wi...

BOOL ok = ConnectNamedPipe(pipe_, &input_state_.context.overlapped);

DWORD err = GetLastError();
  if (ok) {
    // Uhm, the API documentation says that this function should never
    // return success when used in overlapped mode.
    NOTREACHED();
    return false;
  }

switch (err) {
  case ERROR_IO_PENDING:
    input_state_.is_pending = true;
    break;
  case ERROR_PIPE_CONNECTED:
    waiting_connect_ = false;
    break;
  default:
    NOTREACHED();
    return false;
  }

This triggers, for instance, if you build and run Debug/ui_tests.exe:
[1217/155712:FATAL:ipc_channel_win.cc(206)] Check failed: false.

The obvious one-line change to our ConnectNamedPipe lets the test
get further.  I'll post a patch once I have a test case.

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode

http://bugs.winehq.org/show_bug.cgi?id=16550

--- Comment #1 from Dan Kegel   2008-12-17 18:29:32 ---
I'm not so sure I can tighten our existing test, so I'm just going to
post the patch without a test.

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode

http://bugs.winehq.org/show_bug.cgi?id=16550

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

http://bugs.winehq.org/show_bug.cgi?id=16550

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ConnectNamedPort should     |ConnectNamedPort should
                   |never return OK in          |never return OK in
                   |overlapped mode             |overlapped mode (affects
                   |                            |chromium ui_tests.exe)

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

http://bugs.winehq.org/show_bug.cgi?id=16550

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Bruno Jesus  2012-04-26 20:11:20 CDT ---
The current tests suggests that this is covered.

http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L609
http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L731
http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L1481

Dan, what do you think? I have no idea of how to test this.

Also, why the "patch" keyword?

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

http://bugs.winehq.org/show_bug.cgi?id=16550

--- Comment #3 from Dan Kegel  2012-04-26 21:04:42 CDT ---
The patch was
http://www.winehq.org/pipermail/wine-patches/2008-December/066314.html, and it
doesn't seem to have made it in.

I suspect AJ wants to see a real app that complains about this,
not just some app's test suite.

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

https://bugs.winehq.org/show_bug.cgi?id=16550

--- Comment #4 from Ken Sharp  ---
Is this still an issue in Wine 1.7.45 or later?

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

https://bugs.winehq.org/show_bug.cgi?id=16550

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
                 CC|                            |[e-mail],
                   |                            |[e-mail]
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/kernel32-Named
                   |                            |_Pipe

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode (affects chromium ui_tests.exe)

https://bugs.winehq.org/show_bug.cgi?id=16550

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |NEW

--- Comment #5 from Sebastian Lackner  ---
I suspect that this issue is not present anymore (since a while). Has anyone
retested recently?

[Bug 16550] ConnectNamedPort should never return OK in overlapped mode ( affects chromium ui_tests.exe)

https://bugs.winehq.org/show_bug.cgi?id=16550

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] ---
I havent tested this, but I just found

https://github.com/wine-compholio/wine-staging/tree/d3d10

and it has a list of fixed bugs that contain this one too.