[Bug 17428] New: Taskmgr unicode: Blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Summary: Taskmgr unicode: Blank process names in Process list.
           Product: Wine
           Version: 1.1.15
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Thanks, arethusa, for the regression test.
A bunch of commits starting with b28a6c18898ae1b469ecc393b23964cb2b95ea61 broke
it. The patch was:

taskmgr: Converted some functions and variables to Unicode.

How to reproduce:
wine notepad
wine taskmgr

click on the taskmgr Process tab.
Processes show up as blank lines. They are clickable and you can terminate a
process, but how will a user tell which one?

Expected behavior: A list of processes should be shown here.

[Bug 17428] Taskmgr unicode: Blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Henry Kroll  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|---                         |Hours
           Keywords|                            |regression

[Bug 17428] Taskmgr unicode: Blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #1 from Austin English   2009-02-16 18:22:17 ---
Confirming.

[Bug 17428] Regression: Taskmgr unicode: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Henry Kroll  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|other                       |Linux
           Platform|Other                       |PC
            Summary|Taskmgr unicode: Blank      |Regression: Taskmgr unicode:
                   |process names in Process    |blank process names in
                   |list.                       |Process list.

[Bug 17428] Regression: Taskmgr unicode: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Henry Kroll  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |
         Difficulty|Hours                       |---
            Summary|Regression: Taskmgr unicode:|Taskmgr: blank process names
                   |blank process names in      |in Process list.
                   |Process list.               |

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Henry Kroll  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |integration, source

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #2 from Nikolay Sivov   2009-06-16 15:51:19 ---
Application isn't fully converted to Unicode support. I'll try to fix it.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Paul Vriens   2009-06-23 04:14:01 ---
There was already a patch for this:

http://www.winehq.org/pipermail/wine-patches/2008-August/060298.html

Still applies (with warnings) to current Git and does make the processes
visible again.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #4 from Nikolay Sivov   2009-06-24 17:03:21 ---
Original developer is back:

http://www.winehq.org/pipermail/wine-patches/2009-June/074779.html

So I'm not needed here anymore.

P.S. The easiest solution is to set processes page ListView to ANSI
notifications with LVM_SETUNICODEFORMAT...

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

--- Comment #5 from Ky6uk   2009-08-01 16:25:27 ---
Created an attachment (id=22766)
 --> (http://bugs.winehq.org/attachment.cgi?id=22766)
taskmgr bug

Wine 1.1.26. Problem exists.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dylan Smith   2009-08-24 00:01:59 ---
I sent the following patch to wine-patches that fixes the bug.

taskmgr: Finish partial unicode conversion of process page. (Bug 17428)
http://www.winehq.org/pipermail/wine-patches/2009-August/077547.html

The issue was that unicode conversion of the taskmgr was partially complete,
but the process page was missing a lot of necessary unicode conversions.

The main issue that caused the blank process list bug was that taskmgr was
coded to process the LVN_GETDISPINFOA notification, but not the
LVN_GETDISPINFOW notification that it was receiving now receiving.  Of course
the text fields also needed to be appropriately handled as unicode text.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

--- Comment #7 from Dylan Smith   2009-08-24 11:35:07 ---
(In reply to comment #6)
> I sent the following patch to wine-patches that fixes the bug.
>
> taskmgr: Finish partial unicode conversion of process page. (Bug 17428)
> http://www.winehq.org/pipermail/wine-patches/2009-August/077547.html

Accepted as commit fc888d683526a353676fb2ab84556551526f7fea, so you can test it
to make sure it is fixed.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Nikolay Sivov   2009-08-24 11:57:59 ---
Fixed. Thanks Dylan.

[Bug 17428] Taskmgr: blank process names in Process list.

http://bugs.winehq.org/show_bug.cgi?id=17428

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2009-09-02 14:23:04 ---
Closing bugs fixed in 1.1.29.