https://bugs.winehq.org/show_bug.cgi?id=39661
Bug ID: 39661 Summary: Font width incorrect in wineconsole Product: Wine Version: 1.7.55 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: sickvolo@gmail.com Distribution: ---
Created attachment 52875 --> https://bugs.winehq.org/attachment.cgi?id=52875 Incorrect font rendering in wineconsole
Variable width fonts have incorrect character width when displayed in wineconsole. The character rendering is unaffected, but the character space padded, making the text stretched horizontally, see attachments.
Examples with DejaVu Sans Mono, size 14 attached.
Regression in 1.7.55, used to work normally in 1.7.50
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #1 from Sic Volo sickvolo@gmail.com --- Created attachment 52876 --> https://bugs.winehq.org/attachment.cgi?id=52876 Incorrect font rendering in wineconsole
https://bugs.winehq.org/show_bug.cgi?id=39661
Sic Volo sickvolo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sickvolo@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #2 from Sic Volo sickvolo@gmail.com --- Created attachment 52877 --> https://bugs.winehq.org/attachment.cgi?id=52877 Correct font rendering in 1.7.50
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- That was done on purpose, it's a workaround for the fact that we don't support DBCS properly yet.
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #4 from Sic Volo sickvolo@gmail.com --- This breaks console apps that rely on proper character width and use box drawing characters for curses-like dos interface.
For example it breaks the app I maintain - https://appdb.winehq.org/objectManager.php?sClass=version&iId=27377
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Sure, I'm hoping we can get a more correct solution in after code freeze. In the meantime, you probably need to select a different font.
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #6 from Sic Volo sickvolo@gmail.com --- Unfortunately none of the fixed width standard console fonts have box drawing characters AND rendered with correct width proportions anymore.
I've tried Andale Mono, Bitstream Vera, Courier, Courier New, Droid sans, FixedSys, FreeMono, Oxygen Mono, Ubuntu Mono, TlwgMono and the Ume set
Liberation Mono comes close, but still has small gaps between symbols.
I'd be happy to test patches when they come out, but right now have to go back to 1.7.50.
https://bugs.winehq.org/show_bug.cgi?id=39661
Sagawa sagawa.aki+winebugs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs@gmail.c | |om
https://bugs.winehq.org/show_bug.cgi?id=39661
Cosmin Truta ctruta@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ctruta@gmail.com
--- Comment #7 from Cosmin Truta ctruta@gmail.com --- Created attachment 54665 --> https://bugs.winehq.org/attachment.cgi?id=54665 Revert "wineconsole: Deal with fonts that don't have a uniform character width."
This is not a DBCS issue, but a regression caused by 15f8b01223: "wineconsole: Deal with fonts that don't have a uniform character width."
I haven't been able to find a monospaced font that can be rendered properly. I use FAR Manager in wineconsole extensively, and, since upgrading to Wine-1.8.2, I feel eye strain after any non-trivial amount of use.
Therefore, I would really appreciate if you could please revert 15f8b01223 (or implement a fix, if an entire revert is not necessary), and apply that not only to the master branch, but also to the stable branch.
I am hereby attaching the revert patch.
https://bugs.winehq.org/show_bug.cgi?id=39661
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |15f8b012239cd53d9e1a7bb2d1d | |01371f1cd3aa1 CC| |julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=39661
Cosmin Truta ctruta@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #54665|0 |1 is obsolete| |
--- Comment #8 from Cosmin Truta ctruta@gmail.com --- Created attachment 54668 --> https://bugs.winehq.org/attachment.cgi?id=54668 The same patch as before, but with a more brief commit message.
I noticed that the patch I'm reverting here was addressing an RTL issue: Bug 28193: wineconsole does not support RTL locales
However, from what I understand, that patch did not actually fix the issue, and the RTL strings are still displayed incorrectly. (I did not test that myself, though.)
Would it be acceptable to have it undone as I'm proposing in this patch, until the RTL does get a working fix, and without regressing the commonly-used monospaced fonts?
https://bugs.winehq.org/show_bug.cgi?id=39661
kyrab@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kyrab@mail.ru
--- Comment #9 from kyrab@mail.ru --- Please, please, revert this horrible decision! Use the patch from Cosmin or whatever!
Now it's impossible to use FAR Manager with any font except 'Liberation Mono' which looks pretty ugly.
https://bugs.winehq.org/show_bug.cgi?id=39661
Sic Volo sickvolo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P1 Severity|normal |major Version|1.7.55 |1.9.21
--- Comment #10 from Sic Volo sickvolo@gmail.com --- This bug is still present in 1.9.21. It affects multiple wineconsole applications, especially ones relying on the the console box character graphics.
Please resolve it, regress to pre-DBCS code, or at least mark it confirmed.
https://bugs.winehq.org/show_bug.cgi?id=39661
Hugh McMaster hugh.mcmaster@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hugh.mcmaster@outlook.com
--- Comment #11 from Hugh McMaster hugh.mcmaster@outlook.com --- Patch submitted: http://source.winehq.org/patches/data/127441
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #12 from Cosmin Truta ctruta@gmail.com --- (In reply to Hugh McMaster from comment #11)
Patch submitted: http://source.winehq.org/patches/data/127441
Many thanks!
Tested on both development (1.9.23) and stable (1.8.5). Verified that it works.
This is an excellent fix. Can we please have it applied to both 'master' and 'stable'?
https://bugs.winehq.org/show_bug.cgi?id=39661
--- Comment #13 from Hugh McMaster hugh.mcmaster@outlook.com --- (In reply to Cosmin Truta from comment #12)
(In reply to Hugh McMaster from comment #11)
Patch submitted: http://source.winehq.org/patches/data/127441
Many thanks!
Tested on both development (1.9.23) and stable (1.8.5). Verified that it works.
This is an excellent fix. Can we please have it applied to both 'master' and 'stable'?
The patch was rejected because it causes DBCS characters to render incorrectly.
We are working on supporting both SBCS and DBCS, but it will take some time.
For the moment, everyone affected by this bug should apply the patch and build from source.
https://bugs.winehq.org/show_bug.cgi?id=39661
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |29533e4844761c499c16be73e2d | |b7dc055776fdf
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- It should be fixed by 29533e4844761c499c16be73e2db7dc055776fdf.
The handling of DBCS codepages is still not quite right, but that should probably be a different bug.
https://bugs.winehq.org/show_bug.cgi?id=39661
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.0-rc3.
https://bugs.winehq.org/show_bug.cgi?id=39661
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x
https://bugs.winehq.org/show_bug.cgi?id=39661
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #16 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.7.
-
wine-bugs＠winehq.org