[Bug 46772] New: Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Bug ID: 46772
           Summary: Creo Elements/Direct Modeling Express 6.0 installer
                    fails with VBScript parser error: parser_lex '_' not
                    followed by newline
           Product: Wine
           Version: 4.3
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

encountered while revisiting bug 27827 and bug 38950

The installer fails now which is a regression.

--- snip ---
$ WINEDEBUG=+seh,+relay,+msi,+vbscript,+ole,+variant wine
./ModelingPE__setup_EN.exe >>log.txt 2>&1
...
0048:trace:msi:ACTION_CustomAction Handling custom action L"ExportProperties"
(6 L"NewBinary20" L"ExportProperties")
0048:trace:msi:HANDLE_CustomType5_6 L"NewBinary20" L"ExportProperties" 
...
0053:trace:msi:ACTION_CallScript function L"ExportProperties", script L"option
explicit\r\non error resume next\r\n\r\nfunction ExportProperties( )\r\n\r\n 
Dim svLang\r\n  Dim svInstallLang\r\n  Dim svLanguageID\r\n    \r\n  On Error
Resume Next\r\n\r\n  svLang = Session.Property( "UserLanguageID" )\r\n\r\n 
Select Case svLang\r\n\r\n    Case "1031", "2055", "307"... 
...
0053:trace:vbscript:VBScript_AddNamedItem (0x5e2bf8)->(L"Session" a) 
...
0053:trace:vbscript:VBScriptParse_ParseScriptText (0x5e2bf8)->(L"option
explicit\r\non error resume next\r\n\r\nfunction ExportProperties( )\r\n\r\n 
Dim svLang\r\n  Dim svInstallLang\r\n  Dim svLanguageID\r\n    \r\n  On Error
Resume Next\r\n\r\n  svLang = Session.Property( "UserLanguageID" )\r\n\r\n 
Select Case svLang\r\n\r\n    Case "1031", "2055", "307"... (null) (nil)
(null) 0 0 0 (nil) (nil))
...
0053:fixme:vbscript:parser_lex '_' not followed by newline
0053:fixme:vbscript:parse_script parser failed around L"", "5129", "6153",
_\r\n         "7177", "8201", "9225", "10249", "11273"\r\n        
svInstallLang = "english"\r\n         svLanguageID  = "1033"\r\n\r\n   
Case "1034", "2058", "3082", "4106", "5130", "6154", "7178",
"8202", "9226", _\r\n         "10250", "11"... 
...
0053:trace:msi:ScriptThread custom action (53) returned 1603 
...
0048:err:msi:ITERATE_Actions Execution halted, action L"ExportProperties"
returned 1603 
--- snip ---

The embedded VB scriptlet with all DOS line-endings (CR+LF), including
multi-line statements.

--- snip ---
option explicit
on error resume next

function ExportProperties( )

Dim svLang
  Dim svInstallLang
  Dim svLanguageID

On Error Resume Next

svLang = Session.Property( "UserLanguageID" )

Select Case svLang

Case "1031", "2055", "3079", "4103", "5127"
         svInstallLang = "german"
         svLanguageID  = "1031"

Case "1033", "2057", "3081", "4105", "5129", "6153", _
         "7177", "8201", "9225", "10249", "11273"
         svInstallLang = "english"
         svLanguageID  = "1033"

Case "1034", "2058", "3082", "4106", "5130", "6154", "7178", "8202",
"9226", _
         "10250", "11274", "12298", "13322", "14346", "15370", "16394",
"17418", _
         "18442", "19466", "20490"
         svInstallLang = "spanish"
         svLanguageID  = "1034"

Case "1036", "2060", "3084", "4108", "5132"
         svInstallLang = "french"
         svLanguageID  = "1036"

Case "1040", "2064"
         svInstallLang = "italian"
         svLanguageID  = "1040"

Case "1041"
         svInstallLang = "japanese"
         svLanguageID  = "1041"

Case Else
         svInstallLang = svLang
         svLanguageID  = svLang

End Select

Session.Property( "InstallLanguage" ) = svInstallLang
  Session.Property( "GroupLanguageID" ) = svLanguageID

ExportProperties = 0

End Function
--- snip ---

The regression is caused by
https://source.winehq.org/git/wine.git/commitdiff/5800c9ed23a5c720843445d91c...

$ git show 5800c9ed23a5c720843445d91c8547925493df8a
commit 5800c9ed23a5c720843445d91c8547925493df8a
Author: Zebediah Figura 
Date:   Sat Jun 16 19:05:30 2018 -0500

vbscript: Treat \r as a newline separator.

Signed-off-by: Zebediah Figura 
    Signed-off-by: Jacek Caban 
    Signed-off-by: Alexandre Julliard

Reverting this commit on top of current master HEAD makes the installer work
again.

$ sha1sum ModelingPE__setup_EN.exe 
333736c553c2eb985436e63f20bfcbb59932b6fb  ModelingPE__setup_EN.exe

$ du -sh ModelingPE__setup_EN.exe 
207M    ModelingPE__setup_EN.exe

$ wine --version
wine-4.3

Regards

[Bug 46772] Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.ptc.com/products
                   |                            |/creo-elements-direct/model
                   |                            |ing-express/
           Keywords|                            |download, Installer,
                   |                            |regression
    Regression SHA1|                            |5800c9ed23a5c720843445d91c8
                   |                            |547925493df8a

[Bug 46772] Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1bd7dbfbc42af85ad5309759d63
                   |                            |11427f2860de9
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
Not sure how this possibly could have worked before, but it seems to be fixed
by
https://source.winehq.org/git/wine.git/commit/1bd7dbfbc42af85ad5309759d6311427f2860de9.

[Bug 46772] Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 4.4.

[Bug 46772] Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 46772] Creo Elements/ Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

https://bugs.winehq.org/show_bug.cgi?id=46772

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #3 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.2.

[Bug 46772] Creo Elements/Direct Modeling Express 6.0 installer fails with VBScript parser error: parser_lex '_' not followed by newline

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46772

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.ptc.com/products |https://web.archive.org/web
                   |/creo-elements-direct/model |/20190317221046/https://www
                   |ing-express/                |.ptc.com/-/media/Files/creo
                   |                            |/elements-direct/32-bit/Mod
                   |                            |elingPE__setup_EN.exe