[Bug 19415] New: Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

Summary: Dlt and Std keys for timezone Singapore Standard Time
                    are wrong
           Product: Wine
           Version: 1.1.26
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: tools
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22531)
 --> (http://bugs.winehq.org/attachment.cgi?id=22531)
Fix

The "HKLM\Software\Microsoft\Windows NT\CurrentVersion\Time Zones\Singapore
Standard Time" key in the registry contains Dlt="Singapore Daylight Time" and
Std="Singapore Standard Time" but Windows XP SP3 (and others, probably) contain
Dlt="Malay Peninsula Daylight Time" and Std="Malay Peninsula Standard Time".

The attached patch to tools/wine.inf.in fixes this issue.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #1 from Austin English   2009-07-22 12:04:23 ---
Please send patches in git diff format to [e-mail].

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tools                       |-unknown
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #2 from Dmitry Timoshkov   2009-07-22 20:09:25 ---
Is there an application that depends on this?

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #3 from Pau Garcia i Quiles   2009-07-23 00:16:25 ---
Patch sent to wine-patches

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #4 from Dmitry Timoshkov   2009-07-23 01:48:44 ---
You haven't answered the question.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #5 from Pau Garcia i Quiles   2009-07-23 04:00:30 ---
I do not know any application which depends on this but that means nothing: 
- the Dlt and Std strings are shown to users in applications which offer
timezone management or information, and users expect those strings to have the
same values they have on Windows
- there might be applications that depend on the Dlt and Std strings being
correct
- it's a matter staying compliant to what MS does in Windows
- the patch is trivial

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #6 from Dmitry Timoshkov   2009-07-23 04:32:36 ---
This kind of thing doesn't matter, for instance all european users
have the same time zone in Wine, because most of european time zones
have the same day light time switching parameters.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Dmitry Timoshkov   2009-07-23 04:33:05 ---
Closing.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #8 from Pau Garcia i Quiles   2009-07-23 05:17:34 ---
(In reply to comment #6)
> This kind of thing doesn't matter, for instance all european users
> have the same time zone in Wine, because most of european time zones
> have the same day light time switching parameters.

Huh? This is not a matter of having the same timezone but a matter of:
- displaying the right text to the user
- if my app does a string comparison on Dlt and Std, it will fail under wine

I cannot understand the WONTFIX given that this is clearly wrong in Wine and
the patch is trivial.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

--- Comment #9 from Dmitry Timoshkov   2009-07-23 05:25:51 ---
(In reply to comment #8)
> Huh? This is not a matter of having the same timezone but a matter of:
> - displaying the right text to the user

See my comment about european time zones.
> - if my app does a string comparison on Dlt and Std, it will fail under wine

It will fail under any localized version of Windows as well.

[Bug 19415] Dlt and Std keys for timezone Singapore Standard Time are wrong

http://bugs.winehq.org/show_bug.cgi?id=19415

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Dan Kegel   2009-07-23 07:49:43 ---
PG, I think you need to submit a conformance test first.
Once that passes in Windows and fails in Wine, you can resubmit your fix.