http://bugs.winehq.org/show_bug.cgi?id=19563
Summary: Guitar Hero World Tour crashes after dinput's QueryInterface Product: Wine Version: 1.1.26 Platform: PC URL: http://worldtour.guitarhero.com/uk/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dinput AssignedTo: wine-bugs@winehq.org ReportedBy: andras@csevego.net
After fixing bug 19562, the next problem will be, we are not offering IDirectInputDevice8W in IDirectInputDevice2AImpl_QueryInterface. This will result in null pointer access.
It can fixed by adding IDirectInputDevice8W to IDirectInputDevice2AImpl_QueryInterface, but proper tests needed, what does dinput on windows.
Patch:
diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index 941206c..cb66b03 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -753,6 +753,14 @@ HRESULT WINAPI IDirectInputDevice2AImpl_QueryInterface( *ppobj = This; return DI_OK; } + + if (IsEqualGUID(&IID_IDirectInputDevice8W,riid)) { + IDirectInputDevice8_AddRef(iface); + *ppobj = This; + return DI_OK; + } + + TRACE("Unsupported interface !\n"); return E_FAIL; }
http://bugs.winehq.org/show_bug.cgi?id=19563
Andras Kovacs andras@csevego.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19562
http://bugs.winehq.org/show_bug.cgi?id=19563
Andras Kovacs andras@csevego.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19564
http://bugs.winehq.org/show_bug.cgi?id=19563
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=19563
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19565
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2009-08-17 00:43:03 --- No, this patch is wrong. You can't return Unicode interface for the ASCII object. This should be the same sort of thing as DirectInput itself - all interfaces in one.
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #2 from Austin English austinenglish@gmail.com 2010-09-07 16:48:42 CDT --- This is your friendly reminder that there has been no bug activity for a year. Is this still an issue in current (1.3.2 or newer) wine?
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #3 from Andras Kovacs andras@csevego.net 2010-09-09 17:42:15 CDT --- (In reply to comment #2)
This is your friendly reminder that there has been no bug activity for a year. Is this still an issue in current (1.3.2 or newer) wine?
yes
http://bugs.winehq.org/show_bug.cgi?id=19563
Bug 19563 depends on bug 19562, which changed state.
Bug 19562 Summary: Guitar Hero World Tour crashes after dinput GetProperty http://bugs.winehq.org/show_bug.cgi?id=19562
What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
http://bugs.winehq.org/show_bug.cgi?id=19563
MisterE mistere2002@zonnet.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mistere2002@zonnet.nl
--- Comment #4 from MisterE mistere2002@zonnet.nl 2010-11-14 06:05:34 CST --- i am no developer. But applying this patch makes the game not crash anymore. Normally it stops working after: "checking game data...".
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #5 from MisterE mistere2002@zonnet.nl 2010-11-14 06:06:34 CST --- i am no developer. But applying this patch makes the game not crash anymore. Normally it stops working after: "checking game data...".
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #6 from MisterE mistere2002@zonnet.nl 2010-11-14 06:07:22 CST --- i am no developer. But applying this patch makes the game not crash anymore. Normally it stops working after: "checking game data...".
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #7 from MisterE mistere2002@zonnet.nl 2010-11-14 06:11:31 CST --- sorry, about the multiple replys (damn you konqueror!)
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #8 from Al-Mutawa, Hussain A. s200458460@kfupm.edu.sa 2011-01-16 02:08:15 CST --- Created an attachment (id=32867) --> (http://bugs.winehq.org/attachment.cgi?id=32867) copressed log files, wine 1.3.11, ghwt 1.0.1.25215
http://bugs.winehq.org/show_bug.cgi?id=19563
Al-Mutawa, Hussain A. s200458460@kfupm.edu.sa changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |s200458460@kfupm.edu.sa
--- Comment #9 from Al-Mutawa, Hussain A. s200458460@kfupm.edu.sa 2011-01-16 02:08:53 CST --- Guitar Hero World Tour still crashes on wine 1.3.11. I don't know if it is caused by this bug, so I tested running the game with and without dinput. Attached are the log files.
It does not crash at a certain point, but it take variable time before crashing.
http://bugs.winehq.org/show_bug.cgi?id=19563
--- Comment #10 from Al-Mutawa, Hussain A. s200458460@kfupm.edu.sa 2011-01-16 02:35:07 CST --- I applied that patch and tested again and it still crashes after some time.
http://bugs.winehq.org/show_bug.cgi?id=19563
Vitaliy Margolen vitaliy-bugzilla@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #11 from Vitaliy Margolen vitaliy-bugzilla@kievinfo.com 2011-02-01 21:18:57 CST --- This should be fixed in current GIT. Last wine version (wine-1.1.12) has only partial fix.
http://bugs.winehq.org/show_bug.cgi?id=19563
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org 2011-02-04 13:20:59 CST --- Closing bugs fixed in 1.3.13.
-
wine-bugs＠winehq.org