[Bug 32136] New: Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Bug #: 32136
           Summary: Kugou: some text didn't display normally
           Product: Wine
           Version: 1.5.16
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 42400
  --> http://bugs.winehq.org/attachment.cgi?id=42400
'kugou.txt' is the log

When installed Kugou(酷狗音乐) I found that was some chinese text can't be
displayed normally.

And there is a workaround:
add a key in [HKEY_CURRENT_USER\Software\Wine\Fonts\Replacements] name "宋体"
with value 'WenQuanYi Micro Hei'

my test environment:
- Ubuntu 12.04.1
- Wine 1.1.16
- Kugou:http://www.kugou.com/topic/download.php

reproduce follow:
0. download it 
1. 'wine kugouxxxx.exe'

attachments:
wine.png is what it look like in wine;
windows.png is what it look like in windows;
kugou.txt is the log.

[Bug 32136] Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.kugou.com/topic/
                   |                            |download.php

[Bug 32136] Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #1 from Jactry Zeng  2012-11-05 06:46:47 CST ---
Created attachment 42401
  --> http://bugs.winehq.org/attachment.cgi?id=42401
'wine.png' what it look like in wine

[Bug 32136] Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #2 from Jactry Zeng  2012-11-05 06:47:27 CST ---
Created attachment 42402
  --> http://bugs.winehq.org/attachment.cgi?id=42402
'windows.png' what it look like in windows

[Bug 32136] Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.kugou.com/topic/ |http://downmini.kugou.com/K
                   |download.php                |ugou2012.exe

[Bug 32136] Kugou: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #3 from Jactry Zeng  2012-11-05 06:59:51 CST ---
I found the url 'http://www.kugou.com/topic/download.php' will download a
random version , so please download it
'here:http://downmini.kugou.com/Kugou2012.exe' :-)

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Kugou: some text didn't     |Kugou2012: some text didn't
                   |display normally            |display normally

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #4 from Qian Hong  2012-11-05 21:18:16 CST ---
Confirming, I think this bug is partial wine bug and partial downstream
(distributions) bug.

Some CJK programs hardcode localized font names, such as "宋体","新細明體" and "ＭＳ
Ｐゴシック", wine does not provide these fonts, one solution is copying those fonts
from Windows to Linux if you have the license, a free solution is setting a
font replacement for them.

Currently we leave the default font replacement setting work to the
distribution folks, similar settings could be found in Ubuntu/Fedora's
/usr/share/wine/wine.inf:
--- snip ---
HKCU,Software\Wine\Fonts\Replacements,"SimSun",,"WenQuanYi Micro Hei"
--- snip ---

Unfortunately currently SetupOpenInfFileW() interprets wine.inf as ANSI
encoding,
this will bring troubles when trying to add localized font replacements for
different locales, fortunaterly dlls/setupapi/parser.c:parse_file() already
supports ANSI, UTF8 (with BOM) and UTF16, so IMO the simpliest solution is
adding UTF8 BOM header to our tools/wine.inf.in, and leave the font replacement
patches for the distribution folks.

Regards.

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.bierfert@lowlatency
                   |                            |.de, [e-mail]

--- Comment #5 from Qian Hong  2012-11-05 21:32:41 CST ---
CC our dear Ubuntu packager and Fedora packager :)

I'll contact to other packagers later, after the wine side of this bug is
fixed.

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dan Kegel  2012-11-06 09:47:02 CST ---
Should there be a comment at the top of wine.inf.in
explaining that there's a BOM there, and why?
Otherwise somebody's editor might strip it out.

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #7 from Qian Hong  2012-11-06 09:52:43 CST ---
(In reply to comment #6)
> Should there be a comment at the top of wine.inf.in
> explaining that there's a BOM there, and why?
> Otherwise somebody's editor might strip it out.

I agree, thanks for the suggestion!
However I'm not sure whether my wine.inf.in patch would be accept, should I
re-send with the BOM comment or wait for Dmitry's comment on wine-devel and
invest a new solution?

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #8 from Nikolay Sivov  2012-11-06 10:04:11 CST ---
Why do you need BOM in a first place? I don't see how it's helpful at all, even
if UTF-8 could possibly work in .inf files, which is doubtful.

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #9 from Qian Hong  2012-11-06 10:47:16 CST ---
(In reply to comment #8)
> Why do you need BOM in a first place? I don't see how it's helpful at all,

Hello, thanks for comment, but I'm a bit confused, could you be more details
what do you mean by "in a fisrt place"? Did my comment 4 and my reply in
wine-devel answer your question? Thanks a lot!
> even if UTF-8 could possibly work in .inf files, which is doubtful.

We support three encoding of .inf files, ANSI, UTF8 with BOM, and UCS-16, you
could either take a look at dlls/setupapi/parser.c:parse_file() or create real
.inf files with these encoding and test by hand.

[Bug 32136] Kugou2012: some text didn't display normally

http://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #10 from Nikolay Sivov  2012-11-06 11:04:54 CST ---
(In reply to comment #9)
> > even if UTF-8 could possibly work in .inf files, which is doubtful.
>
> We support three encoding of .inf files, ANSI, UTF8 with BOM, and UCS-16, you
> could either take a look at dlls/setupapi/parser.c:parse_file() or create real
> .inf files with these encoding and test by hand.

Ok, I wasn't aware of that. If it's supported way to use .inf files it's
probably okay if it's a part of API that is supposed to work this way. What I
meant is that BOM is not useful for UTF-8, it doesn't depend on byte order and
handles ANSI range. I thought you were trying to invent some workaround.

[Bug 32136] Kugou2012: some text didn't display normally

https://bugs.winehq.org/show_bug.cgi?id=32136

--- Comment #11 from Ken Sharp  ---
Is this still an issue in Wine 1.7.45 or later?

[Bug 32136] Kugou2012: some text didn't display normally

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32136

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from joaopa  ---
Bug still occurs with wine-5.12.