https://bugs.winehq.org/show_bug.cgi?id=50761
Bug ID: 50761 Summary: ntdll-Junction_Points update broke macOS compilation Product: Wine-staging Version: 6.3 Hardware: x86-64 OS: Mac OS X Status: NEW Keywords: regression Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: gijsvrm@gmail.com CC: erich.e.hoover@gmail.com, leslie_alistair@hotmail.com, z.figura12@gmail.com Regression SHA1: 750044c08c49c7a117fcc911506a198969379144
Created attachment 69550 --> https://bugs.winehq.org/attachment.cgi?id=69550 output
This is on a fully updated macOS 10.14 system, using mingw and the macOS 10.13 SDK to compile wine.
https://bugs.winehq.org/show_bug.cgi?id=50761
--- Comment #1 from Erich E. Hoover erich.e.hoover@gmail.com --- I'm really sorry Gijs, it appears that I missed whatever headers are necessary on MacOS to pull that in when I moved this code. Would you please try adding these headers (from the fstatfs mac man page)?: #ifdef HAVE_SYS_PARAM_H #include <sys/param.h> #endif #ifdef HAVE_SYS_MOUNT_H #include <sys/mount.h> #endif
https://bugs.winehq.org/show_bug.cgi?id=50761
--- Comment #2 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Erich E. Hoover from comment #1)
I'm really sorry Gijs, it appears that I missed whatever headers are necessary on MacOS to pull that in when I moved this code. Would you please try adding these headers (from the fstatfs mac man page)?: #ifdef HAVE_SYS_PARAM_H #include <sys/param.h> #endif #ifdef HAVE_SYS_MOUNT_H #include <sys/mount.h> #endif
Adding these fixes the problem, thanks for the quick fix!
https://bugs.winehq.org/show_bug.cgi?id=50761
Gcenx gcenx83@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gcenx83@gmail.com
--- Comment #3 from Gcenx gcenx83@gmail.com --- Thank you both, now I can update my wine-staging package.
https://bugs.winehq.org/show_bug.cgi?id=50761
--- Comment #4 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Gcenx from comment #3)
Thank you both, now I can update my wine-staging package.
No problem, this should now be fixed by staging commit a2ca43d98b3a45ae3bd66e8c71090b42e18c9bdd.
https://bugs.winehq.org/show_bug.cgi?id=50761
Erich E. Hoover erich.e.hoover@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #5 from Erich E. Hoover erich.e.hoover@gmail.com --- Fixed in wine-staging 6.4.
https://bugs.winehq.org/show_bug.cgi?id=50761
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a2ca43d98b3a45ae3bd66e8c710 | |90b42e18c9bdd
https://bugs.winehq.org/show_bug.cgi?id=50761
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Zebediah Figura z.figura12@gmail.com --- Closing bugs fixed in wine-staging 6.4.
-
WineHQ Bugzilla