[Bug 10233] New: TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

Summary: TCM_GETCURFOCUS returns negative value
           Product: Wine
           Version: 0.9.48.
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello,

Before patch

Author: Hagop Hagopian 
Date:   17-03-2007 19:16:08
Parent: comctl32: tab: Added message sequence tests for the tab c...
Child: winex11.drv: In the case requested glyphs do not present...
Branch: master (d3drm: Implement D3DRMCreateColorRGB.) 
Follows: wine-0.9.33 (Release 0.9.33.)
Precedes: wine-0.9.34 (Release 0.9.34.)
    comctl32: tab: Minor bug fixes in the curSel and curFocus getters and
setters.

The TCM_GETCURFOCUS messages refused to return negative values. This seems to
be the correctly M$ Windows behavior. With the patch, if the tab is not already
rendered, TCM_GETCURFOCUS returns -1.

0009:Ret  window proc 0x4eb6b7
(hwnd=0x10056,msg=TCM_GETCURFOCUS,wp=00000000,lp=00000000)
retval=ffffffff

[Bug 10233] TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

Luiz Angelo Daros De Luca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 10233] TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Lei Zhang   2007-10-29 18:35:52 ---
I don't think your assumption that TCM_GETCURFOCUS never returns negative
values is correct. In dlls/comctl32/tests/tab.c, Hagop wrote tests where the
expected return value from Windows is -1. These tests pass on WinXP and Win2K
for me, so I'd say those tests are correct.

Now I looked at the log you posted to wine-devel, and it looks like there
exists cases where Wine gets it wrong. I have written a test to show the
regression and I'll have it fixed in a bit.

[Bug 10233] TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

--- Comment #2 from Lei Zhang   2007-10-29 21:12:16 ---
Patches sent:

http://www.winehq.org/pipermail/wine-patches/2007-October/045933.html
http://www.winehq.org/pipermail/wine-patches/2007-October/045934.html
http://www.winehq.org/pipermail/wine-patches/2007-October/045935.html
http://www.winehq.org/pipermail/wine-patches/2007-October/045936.html

[Bug 10233] TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Lei Zhang   2007-10-30 11:17:11 ---
Patches have been committed. Please try with the latest wine from GIT or wait
for Wine 0.9.49.

[Bug 10233] TCM_GETCURFOCUS returns negative value

http://bugs.winehq.org/show_bug.cgi?id=10233

Luiz Angelo Daros De Luca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Luiz Angelo Daros De Luca   2007-10-30 14:28:25 ---
Thanks. It worked perfectly!