[Bug 40433] New: Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Bug ID: 40433
           Summary: Fifa 11 EU demo fails to install when run from custom
                    DVD
           Product: Wine
           Version: 1.7.29
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

"Fifa 11 EU Demo" fails to install from DVD created by myself under
wine-1.9.7-118-gaaddf13. This demo is distributed as zip file. I took to
content of the ZIP and created the ISO by MagicISO. As a volume label i chose
"fifa2011_eu_demo".

When i copy content of the DVD back to some folder on HDD, then the
installation succeeded.

This could be interpreted as invalid bug report, but this DVD, created by me,
works under Win8.1.

Installer pops-up at the end "Please insert the disc: FIFA 11 Demo".

Console: "err:msi:msi_view_get_row Error fetching data for 1"

This is a regression caused by wine-1.7.28-130-g5cb10c9:

commit 5cb10c96b26d07b7d0aabe3b8e337c7ce144b8af
Author: Hans Leidekker 
Date:   Wed Oct 15 15:30:23 2014 +0200

msi: Don't skip the media check for the first volume.

Some installers require the first volume to be reinserted.

This commit fixed bug 20444. This commit was also indicated as a regression in
bug 38401. There he did reverse, i.e. real DVD copied and created ISO which
finally worked. IMHO he interpreted it as invalid by mistake.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #1 from Wylda  ---
Created attachment 54180
  --> https://bugs.winehq.org/attachment.cgi?id=54180
console log with WINEDEBUG=+msi from wine-1.9.7-118-gaaddf13

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |download, regression
       Distribution|---                         |Debian
                URL|                            |http://static.cdn.ea.com/fi
                   |                            |fa/u/f/fifa11_pc_demo_EU.zi
                   |                            |p
    Regression SHA1|                            |5cb10c96b26d07b7d0aabe3b8e3
                   |                            |37c7ce144b8af

--- Comment #2 from Wylda  ---
Filling some fields...

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #3 from Hans Leidekker  ---
How exactly did you mount the image? The reporter of bug 38401 said it worked
if he mounted the image with cdemu. Does that also help in your case?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #4 from Wylda  ---

Cdemu or burning the image on real DVD produces described issue. The burned DVD
works under WinXP & Win8.1.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #5 from Hans Leidekker  ---
Created attachment 54183
  --> https://bugs.winehq.org/attachment.cgi?id=54183
debug patch

Can you get a +volume,+file,+msi trace with this patch applied?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #6 from Wylda  ---
Created attachment 54184
  --> https://bugs.winehq.org/attachment.cgi?id=54184
console log from wine-1.9.7-118-gaaddf13 +volume,+file,+msi

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #7 from Hans Leidekker  ---
(In reply to Wylda from comment #6)
> Created attachment 54184 [details]
> console log from wine-1.9.7-118-gaaddf13 +volume,+file,+msi

Thanks. Can you send me the msi file?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #8 from Hans Leidekker  ---
Thanks. I had a look at the media table and it doesn't make much sense. It has
some 37 entries, most of which are unused and they all have the same volume
label: 'FIFA 11 Demo'

The logic that satisfies both Doom3 and FIFA 11 is:

1. assume that the disk with DiskId 1 is already in the drive
2. only perform the media check when the label of the next disk entry differs
from the current disk entry

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #9 from Wylda  ---

For the record. I did another test. Created ISO with proper DVD volume name
"FIFA 11 Demo". As expected, this works properly under Win8.1 and Wine.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from André H.  ---
Sounds like this bug can be closed

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #11 from Wylda  ---
(In reply to André H. from comment #10)
> Sounds like this bug can be closed

This is due to comment #9? But that is not what this bug is about. Also could
be "wrongly" tested as newly discovered Case #1 (bellow).

Hans, i noticed, that the DVD with improper label sometimes install
successfully like in real Windows.

Case #1: When i run winecfg without DVD in drive and then i mount the DVD and
run EASetup.exe. Demo is installed successfully.

Case #2: I mount the DVD, then run winecfg. Drive's tab has automaticaly DVD
drive letter entry. If i run EASetup.exe, the installation fails with message
box "Please insert the disc: FIFA 11 Demo".

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from joaopa  ---
Is still a bug in current wine (3.20)?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #13 from Wylda  ---
Created attachment 62985
  --> https://bugs.winehq.org/attachment.cgi?id=62985
Screenshot comparing wine-2.5 vs. wine-4.0-rc1

Still present in wine-4.0-rc1.

Message changed between wine versions. It used to be application's message box,
not it looks like wine itself is complaining.

But successful FIFA's installation still depends on winecfg:

* If winecfg is not run before installtion, FIFA installs without any issues.
 * If i run winecfg and then run installation, it fails with attached
message-box.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #14 from Hans Leidekker  ---
(In reply to Wylda from comment #13)
> Created attachment 62985 [details]
> Screenshot comparing wine-2.5 vs. wine-4.0-rc1
>
> Still present in wine-4.0-rc1.
>
> Message changed between wine versions. It used to be application's message
> box, not it looks like wine itself is complaining.
>
> But successful FIFA's installation still depends on winecfg:
> - If winecfg is not run before installtion, FIFA installs without any
>
> issues.
> - If i run winecfg and then run installation, it fails with attached
>
> message-box.

Can you attach +volume,+file,+msi traces for these two cases?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #15 from Wylda  ---
> Can you attach +volume,+file,+msi traces for these two cases?

Hi Hans, here is the archive with both logs:

https://drive.google.com/uc?export=download&id=10dChgQELJ7cpfge3t9X_LeWZ...

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #16 from Hans Leidekker  ---
Created attachment 63038
  --> https://bugs.winehq.org/attachment.cgi?id=63038
patch

Thanks. Can you try this patch with FIFA 11 and Doom 3 (bug 20444)? 
If it fails with any of these, please attach +msi,+volume logs.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #17 from Wylda  ---
Created attachment 63046
  --> https://bugs.winehq.org/attachment.cgi?id=63046
Logs with Hans' patch and requested debug channels

Thanks Hans, the problem with FIFA 11 installer persist. Fresh logs attached.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63038|0                           |1
        is obsolete|                            |

--- Comment #18 from Hans Leidekker  ---
Created attachment 63078
  --> https://bugs.winehq.org/attachment.cgi?id=63078
patch

How about this version?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #19 from Wylda  ---
Created attachment 63080
  --> https://bugs.winehq.org/attachment.cgi?id=63080
both good logs

Hi Hans, yes you nailed it down :c) Now both cases work now. Just in case you
want to double check, there are both logs attached.

Thank you!

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #20 from Wylda  ---
Created attachment 63081
  --> https://bugs.winehq.org/attachment.cgi?id=63081
Doom3 regression

Unfortunately we have a Doom3 regression. It has nothing to do with this patch,
i.e. there is Doom3 regression even in vanilla wine-4.0-rc2.

It used to ask by Windows's messagebox "Please insert Disk 2". Now it displays
??Wine's Error Message?? - see the attachement. But even if i replace the disk,
Doom3 installation fails.

Like i mentioned here, couple of comments above (message box difference):

https://bugs.winehq.org/attachment.cgi?id=62985

It belongs to separate bug report, but maybe you could be aware of that commit
saving me one regression hunt ;c)

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #21 from Hans Leidekker  ---
(In reply to Wylda from comment #20)
> Created attachment 63081 [details]
> Doom3 regression
>
> Unfortunately we have a Doom3 regression. It has nothing to do with this
> patch, i.e. there is Doom3 regression even in vanilla wine-4.0-rc2.
>
> It used to ask by Windows's messagebox "Please insert Disk 2". Now it
> displays ??Wine's Error Message?? - see the attachement. But even if i
> replace the disk, Doom3 installation fails.

Can you attach a trace with this patch applied?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #22 from Wylda  ---
Created attachment 63083
  --> https://bugs.winehq.org/attachment.cgi?id=63083
wine-4.0-rc2-53-gf6896e062d with Hans' 2nd patch

Log attached.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #23 from Hans Leidekker  ---
(In reply to Wylda from comment #22)
> Created attachment 63083 [details]
> wine-4.0-rc2-53-gf6896e062d with Hans' 2nd patch
>
> Log attached.

Thanks. I should have asked for a +volume,+msi trace, but with a bit of
guesswork I think this happens because your cdrom drive is not recognized as
such. Does it help if you run winecfg and have it detect your drives?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #24 from Wylda  ---
Created attachment 63084
  --> https://bugs.winehq.org/attachment.cgi?id=63084
Doom3 with debug channels +volume,+msi
> ...Does it help if you run winecfg and have it detect your drives?

No, it does not make any difference. New trace attached.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #25 from Hans Leidekker  ---
(In reply to Wylda from comment #20)
> Created attachment 63081 [details]
> Doom3 regression
>
> Unfortunately we have a Doom3 regression. It has nothing to do with this
> patch, i.e. there is Doom3 regression even in vanilla wine-4.0-rc2.
>
> It used to ask by Windows's messagebox "Please insert Disk 2". Now it
> displays ??Wine's Error Message?? - see the attachement. But even if i
> replace the disk, Doom3 installation fails.
>
> Like i mentioned here, couple of comments above (message box difference):
>
> https://bugs.winehq.org/attachment.cgi?id=62985
>
> It belongs to separate bug report, but maybe you could be aware of that
> commit saving me one regression hunt ;c)

This might be fixed with a47343b97369e5f64bb78a7421f2d75258da282a. Could you
verify that?

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #26 from Wylda  ---
> This might be fixed with a47343b97369e5f64bb78a7421f2d75258da282a. Could you
> verify that?

Hi Hans, yes Doom3 is fixed - to track that, i created Bug 46430.

Fifa 11 Demo still fails in wine-4.0-rc5.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

--- Comment #27 from Wylda  ---
> Hi Hans, yes Doom3 is fixed - to track that, i created Bug 46430.
>
> Fifa 11 Demo still fails in wine-4.0-rc5.

Now in wine-4.0-rc5 with applied patch from Comment 18, both Fifa 11 and Doom3
install successfully. Thank you!

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |85fea53af80d324a4cf7f80a45f
                   |                            |43fed8d8d65e1
         Resolution|---                         |FIXED

--- Comment #28 from Hans Leidekker  ---
Fixed with 85fea53af80d324a4cf7f80a45f43fed8d8d65e1. Thanks for your testing
efforts Wylda.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #29 from Alexandre Julliard  ---
Closing bugs fixed in 4.0-rc6.

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 40433] Fifa 11 EU demo fails to install when run from custom DVD

https://bugs.winehq.org/show_bug.cgi?id=40433

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #30 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bug fixes included in 3.0.5.