[Bug 40194] New: drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Bug ID: 40194
           Summary: drag and drop doesn't work because of typo in xdnd.c
           Product: Wine
           Version: 1.9.4
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 53700
  --> https://bugs.winehq.org/attachment.cgi?id=53700
patch for dlls/winex11.drv/xdnd.c

Drag and Drop(D&D), from nemo (Cinnamon's file manager) to Hidemaru.exe
(Windows text editor), does not work.

Step to reproduce:
(1) drag a textfile icon in nemo.
(2) drop off on a Hidemaru window.

Expected Result: Hidemaru opens the textfile.
Actual Result: Nothing happens.

debug log
> 150512.532:0008:0009:warn:xdnd:X11DRV_XDND_PositionEvent IDropTarget_DragOver failed, error 0x00000000
> 150512.532:0008:0009:trace:xdnd:X11DRV_XDND_PositionEvent action req: 528 accept(1) at x(754),y(358)
> 150512.539:0008:0009:trace:xdnd:X11DRV_XDND_DropEvent
> 150512.541:0008:0009:trace:xdnd:create_stream_from_map size 4096
> 150512.810:0008:0009:trace:xdnd:X11DRV_XDND_FreeDragDropOp

hr == 0x00000000 (S_OK) should be successful return, but the return value
logged as error.

I found a miscoding in xdnd.c (c965894),
http://source.winehq.org/git/wine.git/commitdiff/c96589421a5fdf216daed54f207...

and fixed it, D&D worked correctly.

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

--- Comment #1 from Austin English  ---
See https://wiki.winehq.org/SubmittingPatches for how to submit patches, they
are not picked up from bugzilla.

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail],
                   |                            |[e-mail]
    Regression SHA1|                            |c96589421a5fdf216daed54f207
                   |                            |52e63cb31e1a5

--- Comment #2 from Sebastian Lackner  ---
I would say this qualifies as a regression because the commit exactly inverted
the logic. There was also confusion on the wine-devel mailing list, but I
couldn't find a reply / explanation if this change was intentional or really a
typo.

https://www.winehq.org/pipermail/wine-devel/2016-January/111044.html

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Piotr Caban  ---
(In reply to Sebastian Lackner from comment #2)
> There was also confusion on the wine-devel mailing list,
> but I couldn't find a reply / explanation if this change was intentional or
> really a typo.

It's a typo. I've missed the email on wine-devel (that's why there was no
reply).

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

--- Comment #4 from Piotr Caban  ---
(In reply to yokoyama from comment #0)
> Created attachment 53700 [details]
> patch for dlls/winex11.drv/xdnd.c

Could you please send the patch to wine-patches mailing list?

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

--- Comment #5 from [e-mail] ---
(In reply to Piotr Caban from comment #4)
> Could you please send the patch to wine-patches mailing list?

I've submitted. Thanks.
https://source.winehq.org/patches/data/119527

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Shu Yokoyama  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Shu Yokoyama  ---
resolved: commit 5ccf039

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |5ccf039fc72e86674794b444125
                   |                            |3bce04ceff616
                 CC|                            |[e-mail]

[Bug 40194] drag and drop doesn't work because of typo in xdnd.c

https://bugs.winehq.org/show_bug.cgi?id=40194

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.5.